Changeset 12539 in josm for trunk/src/org

Timestamp:

2017-07-30T01:00:55+02:00 (7 years ago)

Author:

Don-vip

Message:

PMD - enable naming rules

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/imagery/TMSCachedTileLoader.java (modified) (1 diff)
• data/osm/visitor/paint/StyledMapRenderer.java (modified) (1 diff)
• data/validation/tests/InternetTags.java (modified) (2 diffs)
• gui/mappaint/styleelement/StyleElement.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/imagery/TMSCachedTileLoader.java

@@ -47 +47 @@
      * and for TMS imagery
      */
-    private static ThreadPoolExecutor DEFAULT_DOWNLOAD_JOB_DISPATCHER = getNewThreadPoolExecutor("TMS-downloader-%d");
-
+    private static final ThreadPoolExecutor DEFAULT_DOWNLOAD_JOB_DISPATCHER = getNewThreadPoolExecutor("TMS-downloader-%d");
 
     private ThreadPoolExecutor downloadExecutor = DEFAULT_DOWNLOAD_JOB_DISPATCHER;

trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/StyledMapRenderer.java

@@ -206 +206 @@
     }
 
-    private static Map<Font, Boolean> IS_GLYPH_VECTOR_DOUBLE_TRANSLATION_BUG = new HashMap<>();
+    private static final Map<Font, Boolean> IS_GLYPH_VECTOR_DOUBLE_TRANSLATION_BUG = new HashMap<>();
 
     /**

trunk/src/org/openstreetmap/josm/data/validation/tests/InternetTags.java

@@ -30 +30 @@
      * List of keys subject to URL validation.
      */
-    private static String[] URL_KEYS = new String[] {
+    private static final String[] URL_KEYS = new String[] {
         "url", "source:url",
         "website", "contact:website", "heritage:website", "source:website"
@@ -38 +38 @@
      * List of keys subject to email validation.
      */
-    private static String[] EMAIL_KEYS = new String[] {
+    private static final String[] EMAIL_KEYS = new String[] {
         "email", "contact:email"
     };

trunk/src/org/openstreetmap/josm/gui/mappaint/styleelement/StyleElement.java

@@ -137 +137 @@
      * a JOSM session. Should have a listener listening to preference changes.
      */
-    private static volatile String DEFAULT_FONT_NAME;
-    private static volatile Float DEFAULT_FONT_SIZE;
+    private static volatile String defaultFontName;
+    private static volatile Float defaultFontSize;
     private static final Object lock = new Object();
 
     // thread save access (double-checked locking)
     private static Float getDefaultFontSize() {
-        Float s = DEFAULT_FONT_SIZE;
+        Float s = defaultFontSize;
         if (s == null) {
             synchronized (lock) {
-                s = DEFAULT_FONT_SIZE;
+                s = defaultFontSize;
                 if (s == null) {
-                    DEFAULT_FONT_SIZE = s = (float) Main.pref.getInteger("mappaint.fontsize", 8);
+                    defaultFontSize = s = (float) Main.pref.getInteger("mappaint.fontsize", 8);
                 }
             }
@@ -156 +156 @@
 
     private static String getDefaultFontName() {
-        String n = DEFAULT_FONT_NAME;
+        String n = defaultFontName;
         if (n == null) {
             synchronized (lock) {
-                n = DEFAULT_FONT_NAME;
+                n = defaultFontName;
                 if (n == null) {
-                    DEFAULT_FONT_NAME = n = Main.pref.get("mappaint.font", "Droid Sans");
+                    defaultFontName = n = Main.pref.get("mappaint.font", "Droid Sans");
                 }
             }