Changeset 12518 in josm for trunk/src/org/openstreetmap

Timestamp:

2017-07-26T23:31:41+02:00 (8 years ago)

Author:

Don-vip

Message:

see #11924 - use ListenerList, fix javadoc

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/mapmode/MapMode.java (modified) (1 diff)
• gui/util/AdvancedKeyPressDetector.java (modified) (6 diffs)
• gui/util/ModifierExListener.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/mapmode/MapMode.java

@@ -173 +173 @@
      * Update internal ctrl, alt, shift mask from given extended modifiers mask.
      * @param modifiers event extended modifiers mask
-     * @since 12516
+     * @since 12517
      */
     protected void updateKeyModifiersEx(int modifiers) {

trunk/src/org/openstreetmap/josm/gui/util/AdvancedKeyPressDetector.java

@@ -20 +20 @@
 
 import org.openstreetmap.josm.Main;
+import org.openstreetmap.josm.tools.ListenerList;
 
 /**
@@ -37 +38 @@
     @Deprecated
     private final List<ModifierListener> modifierListeners = new CopyOnWriteArrayList<>();
-    private final List<ModifierExListener> modifierExListeners = new CopyOnWriteArrayList<>();
+    private final ListenerList<ModifierExListener> modifierExListeners = ListenerList.create();
+    @Deprecated
     private int previousModifiers;
     private int previousModifiersEx;
@@ -64 +66 @@
      * Adds an object that wants to receive extended key modifier changed events.
      * @param l listener to add
-     * @since 12516
+     * @since 12517
      */
     public void addModifierExListener(ModifierExListener l) {
-        modifierExListeners.add(l);
+        modifierExListeners.addListener(l);
     }
 
@@ -91 +93 @@
      * Removes the extended key modifier listener.
      * @param l listener to remove
-     * @since 12516
+     * @since 12517
      */
     public void removeModifierExListener(ModifierExListener l) {
-        modifierExListeners.remove(l);
+        modifierExListeners.removeListener(l);
     }
 
@@ -131 +133 @@
             Main.warn(tr("Some of the key modifier listeners forgot to remove themselves: {0}"), modifierListeners.toString());
         }
-        if (!modifierExListeners.isEmpty()) {
+        if (modifierExListeners.hasListeners()) {
             Main.warn(tr("Some of the key modifier listeners forgot to remove themselves: {0}"), modifierExListeners.toString());
         }
@@ -195 +197 @@
         if (previousModifiersEx != modifEx) {
             previousModifiersEx = modifEx;
-            for (ModifierExListener m: modifierExListeners) {
-                m.modifiersExChanged(modifEx);
-            }
+            modifierExListeners.fireEvent(m -> m.modifiersExChanged(modifEx));
         }
 

trunk/src/org/openstreetmap/josm/gui/util/ModifierExListener.java

@@ -4 +4 @@
 /**
  * Listener called when pressed extended modifier keys change is detected.
- * @since 12516
+ * @since 12517
  */
 @FunctionalInterface