Changeset 12489 in josm

Timestamp:

2017-07-22T16:15:09+02:00 (7 years ago)

Author:

Don-vip

Message:

sonar - squid:S2325 - "private" methods that don't access instance data should be "static"

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/search/SearchCompiler.java (modified) (1 diff)
• io/session/SessionReader.java (modified) (2 diffs)
• io/session/SessionWriter.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/actions/search/SearchCompiler.java

@@ -1606 +1606 @@
         }
 
-        private boolean presetNameMatch(String name, TaggingPreset preset, boolean matchStrictly) {
+        private static boolean presetNameMatch(String name, TaggingPreset preset, boolean matchStrictly) {
             if (matchStrictly) {
                 return name.equalsIgnoreCase(preset.getRawName());

trunk/src/org/openstreetmap/josm/io/session/SessionReader.java

@@ -615 +615 @@
     }
 
-    private SessionViewportData readViewportData(Element root) {
+    private static SessionViewportData readViewportData(Element root) {
         Element viewportEl = getElementByTagName(root, "viewport");
         if (viewportEl == null) return null;
@@ -639 +639 @@
     }
 
-    private SessionProjectionChoiceData readProjectionChoiceData(Element root) {
+    private static SessionProjectionChoiceData readProjectionChoiceData(Element root) {
         Element projectionEl = getElementByTagName(root, "projection");
         if (projectionEl == null) return null;

trunk/src/org/openstreetmap/josm/io/session/SessionWriter.java

@@ -255 +255 @@
     }
 
-    private void writeViewPort(Element root) {
+    private static void writeViewPort(Element root) {
         Document doc = root.getOwnerDocument();
         Element viewportEl = doc.createElement("viewport");
@@ -271 +271 @@
     }
 
-    private void writeProjection(Element root) {
+    private static void writeProjection(Element root) {
         Document doc = root.getOwnerDocument();
         Element projectionEl = doc.createElement("projection");