Changeset 12154 in josm

Timestamp:

2017-05-15T13:29:59+02:00 (8 years ago)

Author:

michael2402

Message:

Fix #12926: Don't draw direction arrows on short selection segments.

Location:

trunk/src/org/openstreetmap/josm/data/osm/visitor/paint

Files:

• ArrowPaintHelper.java (modified) (1 diff)
• StyledMapRenderer.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/ArrowPaintHelper.java

@@ -49 +49 @@
         }
     }
+
+    /**
+     * Gets the length of the arrow along the line segment.
+     * @return the length along the line
+     * @since 12154
+     */
+    public double getOnLineLength() {
+        return length * cos;
+    }
 }

trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/StyledMapRenderer.java

@@ -1222 +1222 @@
         Iterator<MapViewPoint> it = new OffsetIterator(mapState, wayNodes, offset);
         boolean initialMoveToNeeded = true;
+        ArrowPaintHelper drawArrowHelper = null;
+        if (showOrientation) {
+            drawArrowHelper = new ArrowPaintHelper(PHI, 10 + line.getLineWidth());
+        }
         while (it.hasNext()) {
             MapViewPoint p = it.next();
@@ -1235 +1239 @@
 
                 /* draw arrow */
-                if (showHeadArrowOnly ? !it.hasNext() : showOrientation) {
-                    //TODO: Cache
-                    ArrowPaintHelper drawHelper = new ArrowPaintHelper(PHI, 10 + line.getLineWidth());
-                    drawHelper.paintArrowAt(orientationArrows, p2, p1);
+                if (drawArrowHelper != null) {
+                    boolean drawArrow;
+                    if (showHeadArrowOnly) {
+                        // always draw last arrow - no matter how short the segment is
+                        drawArrow = !it.hasNext();
+                    } else {
+                        // draw arrows in between only if there is enough space
+                        drawArrow = p1.distanceToInView(p2) > drawArrowHelper.getOnLineLength() * 1.3;
+                    }
+                    if (drawArrow) {
+                        drawArrowHelper.paintArrowAt(orientationArrows, p2, p1);
+                    }
                 }
             }