Changeset 11921 in josm for trunk/src

Timestamp:

2017-04-15T20:20:00+02:00 (8 years ago)

Author:

Don-vip

Message:

improve unit test coverage of utilities classes thanks to ​https://trajano.github.io/commons-testing

Location:

trunk/src/org/openstreetmap/josm

Files:

• Main.java (modified) (1 diff)
• actions/OrthogonalizeAction.java (modified) (1 diff)
• data/imagery/GetCapabilitiesParseHelper.java (modified) (1 diff)
• data/oauth/SignpostAdapters.java (modified) (1 diff)
• gui/ConditionalOptionPaneUtil.java (modified) (1 diff)
• gui/ExceptionDialogUtil.java (modified) (1 diff)
• gui/datatransfer/ClipboardUtils.java (modified) (1 diff)
• tools/StreamUtils.java (modified) (1 diff)
• tools/date/DateUtils.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/Main.java

@@ -1221 +1221 @@
         private static MasterWindowListener INSTANCE;
 
+        /**
+         * Returns the unique {@code MasterWindowListener} instance.
+         * @return the unique {@code MasterWindowListener} instance
+         */
         public static synchronized MasterWindowListener getInstance() {
             if (INSTANCE == null) {

trunk/src/org/openstreetmap/josm/actions/OrthogonalizeAction.java

@@ -539 +539 @@
      * Class contains some auxiliary functions
      */
-    private static final class EN {
+    static final class EN {
         private EN() {
             // Hide implicit public constructor for utility class

trunk/src/org/openstreetmap/josm/data/imagery/GetCapabilitiesParseHelper.java

@@ -15 +15 @@
 /**
  * Helper class for handling OGC GetCapabilities documents
- *
+ * @since 10993
  */
 public final class GetCapabilitiesParseHelper {

trunk/src/org/openstreetmap/josm/data/oauth/SignpostAdapters.java

@@ -18 +18 @@
 
     private SignpostAdapters() {
+        // Hide constructor for utility classes
     }
 

trunk/src/org/openstreetmap/josm/gui/ConditionalOptionPaneUtil.java

@@ -45 +45 @@
      * this is a static utility class only
      */
-    private ConditionalOptionPaneUtil() {}
+    private ConditionalOptionPaneUtil() {
+        // Hide default constructor for utility classes
+    }
 
     /**

trunk/src/org/openstreetmap/josm/gui/ExceptionDialogUtil.java

@@ -38 +38 @@
      */
     private ExceptionDialogUtil() {
+        // Hide default constructor for utility classes
     }
 

trunk/src/org/openstreetmap/josm/gui/datatransfer/ClipboardUtils.java

@@ -34 +34 @@
 
     private ClipboardUtils() {
+        // Hide default constructor for utility classes
     }
 

trunk/src/org/openstreetmap/josm/tools/StreamUtils.java

@@ -16 +16 @@
      * Utility class
      */
-    private StreamUtils() {}
+    private StreamUtils() {
+        // Hide default constructor for utility classes
+    }
 
     /**

trunk/src/org/openstreetmap/josm/tools/date/DateUtils.java

@@ -59 +59 @@
      * Constructs a new {@code DateUtils}.
      */
-    protected DateUtils() {
+    private DateUtils() {
         // Hide default constructor for utils classes
     }