Changeset 11613 in josm

Timestamp:

2017-02-25T14:27:05+01:00 (8 years ago)

Author:

Don-vip

Message:

sonar - squid:S2325 - "private" methods that don't access instance data should be "static"

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/search/SearchCompiler.java (modified) (1 diff)
• gui/layer/gpx/GpxDrawHelper.java (modified) (3 diffs)
• tools/PlatformHookUnixoid.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/search/SearchCompiler.java

@@ -1669 +1669 @@
     }
 
-    private Match parseExpressionStep2(List<Object> list) {
+    private static Match parseExpressionStep2(List<Object> list) {
         Match result = null;
         for (int i = list.size() - 1; i >= 0; i--) {

trunk/src/org/openstreetmap/josm/gui/layer/gpx/GpxDrawHelper.java

@@ -1236 +1236 @@
     }
 
-
     /**
      * Draw a dotted heat map
@@ -1245 +1244 @@
      * @param drawSize        draw size of draw element
      */
-    private void drawHeatGrayDotMap(Graphics2D gB, MapView mv, List<WayPoint> listSegm, int drawSize) {
+    private static void drawHeatGrayDotMap(Graphics2D gB, MapView mv, List<WayPoint> listSegm, int drawSize) {
 
         // typical rendering rate -> use realtime preview instead of accurate display
@@ -1289 +1288 @@
      * @param dropRate          Pixel render drop rate
      */
-    private void drawHeatSurfaceLine(Graphics2D g, Point fromPnt, Point toPnt, int drawSize, double rmsSizeX, double rmsSizeY, double dropRate) {
+    private static void drawHeatSurfaceLine(Graphics2D g,
+            Point fromPnt, Point toPnt, int drawSize, double rmsSizeX, double rmsSizeY, double dropRate) {
 
         // collect frequently used items

trunk/src/org/openstreetmap/josm/tools/PlatformHookUnixoid.java

@@ -384 +384 @@
      * @return true if the dot directory should be used
      */
-    private boolean useDotDirectory() {
+    private static boolean useDotDirectory() {
         return getDotDirectory().exists();
     }