Changeset 11520 in josm

Timestamp:

2017-01-31T23:38:13+01:00 (8 years ago)

Author:

Don-vip

Message:

sonar - fb-contrib:ITU_INAPPROPRIATE_TOSTRING_USE - Correctness - Method performs algorithmic operations on the result of a toString() call

File:

• trunk/src/org/openstreetmap/josm/gui/help/HelpBrowser.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/help/HelpBrowser.java

@@ -610 +610 @@
             if (e.getEventType() != HyperlinkEvent.EventType.ACTIVATED)
                 return;
-            if (e.getURL() == null || e.getURL().toString().startsWith(url+'#')) {
+            if (e.getURL() == null || e.getURL().toExternalForm().startsWith(url+'#')) {
                 // Probably hyperlink event on a an A-element with a href consisting of a fragment only, i.e. "#ALocalFragment".
                 String fragment = getUrlFragment(e);
@@ -633 +633 @@
                     );
                 }
-            } else if (e.getURL().toString().endsWith("action=edit")) {
-                OpenBrowser.displayUrl(e.getURL().toString());
+            } else if (e.getURL().toExternalForm().endsWith("action=edit")) {
+                OpenBrowser.displayUrl(e.getURL().toExternalForm());
             } else {
-                url = e.getURL().toString();
-                openUrl(e.getURL().toString());
+                url = e.getURL().toExternalForm();
+                openUrl(url);
             }
         }