Changeset 11516 in josm for trunk

Timestamp:

2017-01-31T22:58:50+01:00 (8 years ago)

Author:

Don-vip

Message:

sonar - fb-contrib:SPP_USE_GET0 - Performance - Method uses iterator().next() on a List to get the first item

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/imagery/WMTSTileSource.java (modified) (2 diffs)
• io/OverpassDownloadReader.java (modified) (1 diff)
• tools/Geometry.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/imagery/WMTSTileSource.java

@@ -227 +227 @@
                 return null; //nothing selected
             }
-            Layer selectedLayer = layers.get(index).getValue().iterator().next();
+            Layer selectedLayer = layers.get(index).getValue().get(0);
             return new WMTSDefaultLayer(selectedLayer.name, selectedLayer.tileMatrixSet.identifier);
         }
@@ -270 +270 @@
         // if there is only one layer name no point in asking
         if (grouppedLayers.size() == 1) {
-            Layer selectedLayer = grouppedLayers.iterator().next().getValue().iterator().next();
+            Layer selectedLayer = grouppedLayers.iterator().next().getValue().get(0);
             return new WMTSDefaultLayer(selectedLayer.name, selectedLayer.tileMatrixSet.identifier);
         }

trunk/src/org/openstreetmap/josm/io/OverpassDownloadReader.java

@@ -115 +115 @@
         try {
             final List<NameFinder.SearchResult> results = NameFinder.queryNominatim(area);
-            final PrimitiveId osmId = results.iterator().next().getOsmId();
+            final PrimitiveId osmId = results.get(0).getOsmId();
             return String.format("area(%d)", osmId.getUniqueId() + idOffset.get(osmId.getType()));
         } catch (IOException | NoSuchElementException ex) {

trunk/src/org/openstreetmap/josm/tools/Geometry.java

@@ -88 +88 @@
 
         OsmDataLayer layer = Main.getLayerManager().getEditLayer();
-        DataSet dataset = ways.iterator().next().getDataSet();
+        DataSet dataset = ways.get(0).getDataSet();
 
         //iterate over all way pairs and introduce the intersections