Changeset 11481 in josm for trunk

Timestamp:

2017-01-18T09:04:51+01:00 (8 years ago)

Author:

Don-vip

Message:

sonar - squid:S3518 - Zero should not be a possible denominator

File:

• trunk/src/org/openstreetmap/josm/actions/MergeNodesAction.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/actions/MergeNodesAction.java

@@ -111 +111 @@
             return candidates.get(size - 1);
         case 1:
-            double east1 = 0, north1 = 0;
+            double east1 = 0;
+            double north1 = 0;
             for (final Node n : candidates) {
                 EastNorth en = n.getEastNorth();
@@ -132 +133 @@
             }
 
-            double east2 = 0, north2 = 0, weight = 0;
+            double east2 = 0;
+            double north2 = 0;
+            double weight = 0;
             for (int i = 0; i < size; i++) {
                 final EastNorth en = candidates.get(i).getEastNorth();
@@ -140 +143 @@
                 weight += w;
             }
+
+            if (weight == 0) // to avoid division by 0
+                return candidates.get(0);
 
             return new Node(new EastNorth(east2 / weight, north2 / weight));