Changeset 11469 in josm for trunk

Timestamp:

2017-01-16T22:10:58+01:00 (8 years ago)

Author:

bastiK

Message:

see #13124 - fix some Heat Map issues (patch by kidelo)

File:

• trunk/src/org/openstreetmap/josm/gui/layer/gpx/GpxDrawHelper.java (modified) (5 diffs)

trunk/src/org/openstreetmap/josm/gui/layer/gpx/GpxDrawHelper.java

@@ -1009 +1009 @@
         g.setStroke(new BasicStroke(outlineWidth));
 
-        int lastPixelY = 0;
+        int lastPixelX = 0;
         int lastPixelColor = 0;
 
         // resample gray scale image with line linear weight of next sample in line
         // process each line and draw pixels / rectangles with same color with one operations
-        for (int x = 0; x < maxPixelX; x += offX) {
-            for (int y = 0; y < maxPixelY; y += offY) {
-
-                int thePixelColor = 0;
+        for (int y = 0; y < maxPixelY; y += offY) {
+
+            // the lines offsets
+            final int lastLineOffset = maxPixelX * (y+0);
+            final int nextLineOffset = maxPixelX * (y+1);
+
+            for (int x = 0; x < maxPixelX; x += offX) {
+
+                int thePixelColor = 0; int thePixelCount = 0;
 
                 // sample the image (it is gray scale)
-                int offset = (x * maxPixelX) + y;
+                int offset = lastLineOffset + x;
 
                 // merge next pixels of window of line
-                for (int k = 0; k < offX && offset + k < imgPixels.length; k++) {
+                for (int k = 0; k < offX && (offset + k) < nextLineOffset; k++) {
                     thePixelColor += imgPixels[offset+k] & 0xFF;
+                    thePixelCount++;
                 }
 
                 // mean value
-                thePixelColor /= offX;
+                thePixelColor = thePixelCount > 0 ? (thePixelColor / thePixelCount) : 0;
 
                 // restart -> use initial sample
-                if (0 == y) {
-                    lastPixelY = 0; lastPixelColor = thePixelColor - 1;
+                if (0 == x) {
+                    lastPixelX = 0; lastPixelColor = thePixelColor - 1;
                 }
 
@@ -1056 +1062 @@
                         // box from from last Y pixel to current pixel
                         if (drawOutlines) {
-                            g.drawRect(lastPixelY, x, offY + y - lastPixelY, offX);
+                            g.drawRect(lastPixelX, y, offX + x - lastPixelX, offY);
                         } else {
-                            g.fillRect(lastPixelY, x, offY + y - lastPixelY, offX);
+                            g.fillRect(lastPixelX, y, offX + x - lastPixelX, offY);
                         }
                     }
 
                     // restart detection
-                    lastPixelY = y; lastPixelColor = thePixelColor;
+                    lastPixelX = x; lastPixelColor = thePixelColor;
                 }
             }
@@ -1081 +1087 @@
 
         // get bounds of screen image and projection, zoom and adjust input parameters
-        final Rectangle screenBounds = g.getDeviceConfiguration().getBounds();
+        final Rectangle screenBounds = new Rectangle(mv.getWidth(), mv.getHeight());
         final double zoomScale = mv.getScale();
 
@@ -1088 +1094 @@
 
         // 1st setup virtual paint area ----------------------------------------
-
-        // HACK: sometime screen bounds does not return valid values when picture is shifted
-        // therefore we use a bigger area to avoid missing parts of image
-        screenBounds.width = screenBounds.width * 3 / 2;
-        screenBounds.height = screenBounds.height * 3 / 2;
 
         // new image buffer needed
@@ -1142 +1143 @@
             heatMapCacheVisibleSegments = visibleSegments.size();
             heatMapCacheZoomScale = zoomScale;
-            heatMapCacheLineWith = lineWidth;
+            heatMapCacheLineWith = globalLineWidth;
         }
 
         // 4th. Draw data on target layer, map data via color lookup table --------------
-        drawHeatMapGrayMap(g, heatMapImgGray,
-                lineWidthB > 2 ? (lineWidthB / 2) : 1,
-                lineWidth > 2 ? (lineWidth - 2) : 1);
+        drawHeatMapGrayMap(g, heatMapImgGray, lineWidthB > 2 ? (lineWidthB / 2) : 1, lineWidth > 2 ? (lineWidth - 2) : 1);
     }