Changeset 11454 in josm

Timestamp:

2017-01-12T01:42:44+01:00 (8 years ago)

Author:

Don-vip

Message:

sonar - fb-contrib:NAB_NEEDLESS_BOOLEAN_CONSTANT_CONVERSION - Performance - Method needlessly boxes a boolean constant

Location:

trunk/src/org/openstreetmap/josm

Files:

• gui/datatransfer/ClipboardUtils.java (modified) (1 diff)
• gui/mappaint/mapcss/ConditionFactory.java (modified) (1 diff)
• tools/RightAndLefthandTraffic.java (modified) (1 diff)
• tools/Shortcut.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/datatransfer/ClipboardUtils.java

@@ -141 +141 @@
             try {
                 getClipboard().setContents(transferable, new DoNothingClipboardOwner());
-                return true;
+                return Boolean.TRUE;
             } catch (IllegalStateException ex) {
                 Main.error(ex);
-                return false;
+                return Boolean.FALSE;
             }
         });

trunk/src/org/openstreetmap/josm/gui/mappaint/mapcss/ConditionFactory.java

@@ -197 +197 @@
                     testFloat = Float.parseFloat(test);
                 } catch (NumberFormatException e) {
-                    return false;
+                    return Boolean.FALSE;
                 }
                 float prototypeFloat = Float.parseFloat(prototype);

trunk/src/org/openstreetmap/josm/tools/RightAndLefthandTraffic.java

@@ -157 +157 @@
              OsmWriter w = OsmWriterFactory.createOsmWriter(new PrintWriter(writer), false, ds.getVersion())
             ) {
-            w.header(false);
+            w.header(Boolean.FALSE);
             w.writeContent(ds);
             w.footer();

trunk/src/org/openstreetmap/josm/tools/Shortcut.java

@@ -404 +404 @@
         return shortcuts.stream()
                 .map(Shortcut::save)
-                .reduce(false, Boolean::logicalOr); // has changed
+                .reduce(Boolean.FALSE, Boolean::logicalOr); // has changed
     }