Changeset 11389 in josm for trunk/src/org/openstreetmap

Timestamp:

2016-12-13T12:41:03+01:00 (8 years ago)

Author:

Don-vip

Message:

findbugs - DLS_DEAD_LOCAL_STORE

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/CombineWayAction.java (modified) (1 diff)
• actions/OrthogonalizeAction.java (modified) (2 diffs)
• tools/Diff.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/CombineWayAction.java

@@ -150 +150 @@
                 Collections.reverse(path);
                 List<Way> tempWays = unreversedWays;
-                unreversedWays = reversedWays;
+                unreversedWays = null;
                 reversedWays = tempWays;
             }

trunk/src/org/openstreetmap/josm/actions/OrthogonalizeAction.java

@@ -46 +46 @@
             "(Afterwards, you can undo the movement for certain nodes:<br>"+
             "Select them and press the shortcut for Orthogonalize / Undo. The default is Shift-Q.)");
+
+    private static final double EPSILON = 1E-6;
 
     /**
@@ -415 +417 @@
             final double dy = tmp.north() - n.getEastNorth().north();
             if (headingNodes.contains(n)) { // The heading nodes should not have changed
-                final double epsilon = 1E-6;
-                if (Math.abs(dx) > Math.abs(epsilon * tmp.east()) ||
-                        Math.abs(dy) > Math.abs(epsilon * tmp.east()))
-                    throw new AssertionError();
+                if (Math.abs(dx) > Math.abs(EPSILON * tmp.east()) ||
+                    Math.abs(dy) > Math.abs(EPSILON * tmp.east()))
+                    throw new AssertionError("heading node has changed");
             } else {
                 OrthogonalizeAction.rememberMovements.put(n, new EastNorth(dx, dy));

trunk/src/org/openstreetmap/josm/tools/Diff.java

@@ -812 +812 @@
                     if (end != iEnd && equivs[start] == equivs[end] && !otherChanged[1+j]
                          && !((preceding >= 0 && start == preceding) || (otherPreceding >= 0 && otherStart == otherPreceding))) {
-                        changed[1+end++] = true;
+                        changed[1+end] = true;
                         changed[1+start++] = false;
                         ++i;