Changeset 11377 in josm

Timestamp:

2016-12-10T15:26:36+01:00 (8 years ago)

Author:

Don-vip

Message:

findbugs - SE_BAD_FIELD

Location:

trunk

Files:

• src/org/openstreetmap/josm/gui/dialogs/DeleteFromRelationConfirmationDialog.java (modified) (1 diff)
• src/org/openstreetmap/josm/gui/io/UploadSelectionDialog.java (modified) (2 diffs)
• tools/findbugs/josm-filter.xml (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/dialogs/DeleteFromRelationConfirmationDialog.java

@@ -187 +187 @@
     public static class RelationMemberTableModel extends DefaultTableModel {
         private static class RelationToChildReferenceComparator implements Comparator<RelationToChildReference>, Serializable {
-            private final NameFormatter nf = DefaultNameFormatter.getInstance();
-
             @Override
             public int compare(RelationToChildReference o1, RelationToChildReference o2) {
+                NameFormatter nf = DefaultNameFormatter.getInstance();
                 int cmp = o1.getChild().getDisplayName(nf).compareTo(o2.getChild().getDisplayName(nf));
                 if (cmp != 0) return cmp;

trunk/src/org/openstreetmap/josm/gui/io/UploadSelectionDialog.java

@@ -198 +198 @@
     static class OsmPrimitiveListModel extends AbstractListModel<OsmPrimitive> {
         static final class OsmPrimitiveComparator implements Comparator<OsmPrimitive>, Serializable {
-            private final DefaultNameFormatter formatter = DefaultNameFormatter.getInstance();
-
             @Override
             public int compare(OsmPrimitive o1, OsmPrimitive o2) {
@@ -205 +203 @@
                 if (ret != 0)
                     return ret;
+                DefaultNameFormatter formatter = DefaultNameFormatter.getInstance();
                 return o1.getDisplayName(formatter).compareTo(o1.getDisplayName(formatter));
             }

trunk/tools/findbugs/josm-filter.xml

@@ -3 +3 @@
         <Match>
                 <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE" />
+        </Match>
+        <Match>
+                <Bug pattern="SE_BAD_FIELD" />
         </Match>
         <Match>