Changeset 11096 in josm

Timestamp:

2016-10-08T02:01:09+02:00 (8 years ago)

Author:

Don-vip

Message:

sonar - squid:S3725 - Java 8's Files.exists should not be used (The Files.exists method has noticeably poor performance in JDK 8, and can slow an application significantly when used to check files that don't actually exist)

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/validation/OsmValidator.java (modified) (1 diff)
• io/remotecontrol/RemoteControlHttpsServer.java (modified) (1 diff)
• tools/PlatformHookUnixoid.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/validation/OsmValidator.java

@@ -183 +183 @@
         if (ValidatorPreference.PREF_USE_IGNORE.get()) {
             Path path = Paths.get(getValidatorDir()).resolve("ignorederrors");
-            if (Files.exists(path)) {
+            if (path.toFile().exists()) {
                 try {
                     ignoredErrors.addAll(Files.readAllLines(path, StandardCharsets.UTF_8));

trunk/src/org/openstreetmap/josm/io/remotecontrol/RemoteControlHttpsServer.java

@@ -207 +207 @@
         Files.createDirectories(dir);
 
-        if (!Files.exists(path)) {
+        if (!path.toFile().exists()) {
             Main.debug("No keystore found, creating a new one");
 

trunk/src/org/openstreetmap/josm/tools/PlatformHookUnixoid.java

@@ -217 +217 @@
         try {
             // CHECKSTYLE.OFF: SingleSpaceSeparator
-            boolean dpkg = Files.exists(Paths.get("/usr/bin/dpkg-query"));
-            boolean eque = Files.exists(Paths.get("/usr/bin/equery"));
-            boolean rpm  = Files.exists(Paths.get("/bin/rpm"));
+            boolean dpkg = Paths.get("/usr/bin/dpkg-query").toFile().exists();
+            boolean eque = Paths.get("/usr/bin/equery").toFile().exists();
+            boolean rpm  = Paths.get("/bin/rpm").toFile().exists();
             // CHECKSTYLE.ON: SingleSpaceSeparator
             if (dpkg || rpm || eque) {
@@ -390 +390 @@
             if (path != null) {
                 Path p = Paths.get(path);
-                if (Files.exists(p)) {
+                if (p.toFile().exists()) {
                     try (BufferedReader reader = Files.newBufferedReader(p, StandardCharsets.UTF_8)) {
                         String id = null;