Changeset 10597 in josm for trunk/src/org/openstreetmap

Timestamp:

2016-07-23T01:02:41+02:00 (8 years ago)

Author:

Don-vip

Message:

see #12905 - sonar - pmd:BooleanGetMethodName - A getX() method which returns a boolean should be named isX()

Location:

trunk/src/org/openstreetmap/josm/tools/bugreport

Files:

• BugReport.java (modified) (4 diffs)
• BugReportSettingsPanel.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/tools/bugreport/BugReport.java

@@ -55 +55 @@
 
     /**
-     * Get if this report should include a system status report
+     * Determines if this report should include a system status report
      * @return <code>true</code> to include it.
-     * @since 10585
-     */
-    public boolean getIncludeStatusReport() {
+     * @since 10597
+     */
+    public boolean isIncludeStatusReport() {
         return includeStatusReport;
     }
@@ -74 +74 @@
 
     /**
-     * Get if this report should include the data that was traced.
+     * Determines if this report should include the data that was traced.
      * @return <code>true</code> to include it.
-     * @since 10585
-     */
-    public boolean getIncludeData() {
+     * @since 10597
+     */
+    public boolean isIncludeData() {
         return includeData;
     }
@@ -93 +93 @@
 
     /**
-     * Get if this report should include the stack traces for all other threads.
+     * Determines if this report should include the stack traces for all other threads.
      * @return <code>true</code> to include it.
-     * @since 10585
-     */
-    public boolean getIncludeAllStackTraces() {
+     * @since 10597
+     */
+    public boolean isIncludeAllStackTraces() {
         return includeAllStackTraces;
     }
@@ -119 +119 @@
         StringWriter stringWriter = new StringWriter();
         PrintWriter out = new PrintWriter(stringWriter);
-        if (getIncludeStatusReport()) {
+        if (isIncludeStatusReport()) {
             out.println(ShowStatusReportAction.getReportHeader());
         }
-        if (getIncludeData()) {
+        if (isIncludeData()) {
             exception.printReportDataTo(out);
         }
         exception.printReportStackTo(out);
-        if (getIncludeAllStackTraces()) {
+        if (isIncludeAllStackTraces()) {
             exception.printReportThreadsTo(out);
         }

trunk/src/org/openstreetmap/josm/tools/bugreport/BugReportSettingsPanel.java

@@ -22 +22 @@
 
         JCheckBox statusReport = new JCheckBox(tr("Include the system status report."));
-        statusReport.setSelected(report.getIncludeStatusReport());
+        statusReport.setSelected(report.isIncludeStatusReport());
         statusReport.addChangeListener(e -> report.setIncludeStatusReport(statusReport.isSelected()));
         add(statusReport);
 
         JCheckBox data = new JCheckBox(tr("Include information about the data that was worked on."));
-        data.setSelected(report.getIncludeData());
+        data.setSelected(report.isIncludeData());
         data.addChangeListener(e -> report.setIncludeData(data.isSelected()));
         add(data);
 
         JCheckBox allStackTraces = new JCheckBox(tr("Include all stack traces."));
-        allStackTraces.setSelected(report.getIncludeAllStackTraces());
+        allStackTraces.setSelected(report.isIncludeAllStackTraces());
         allStackTraces.addChangeListener(e -> report.setIncludeAllStackTraces(allStackTraces.isSelected()));
         add(allStackTraces);