Changeset 10569 in josm

Timestamp:

2016-07-20T00:25:18+02:00 (8 years ago)

Author:

Don-vip

Message:

fix #13157 - Make DateUtilsTest not time out on some time zones (patch by michael2402) - gsoc-core

Location:

trunk/test/unit/org/openstreetmap/josm

Files:

• testutils/JOSMTestRules.java (modified) (6 diffs)
• tools/ExifReaderTest.java (modified) (1 diff)
• tools/date/DateUtilsTest.java (modified) (1 diff)

trunk/test/unit/org/openstreetmap/josm/testutils/JOSMTestRules.java

@@ -4 +4 @@
 import java.io.File;
 import java.io.IOException;
+import java.text.MessageFormat;
 import java.util.TimeZone;
 
-import org.junit.rules.DisableOnDebug;
 import org.junit.rules.TemporaryFolder;
 import org.junit.rules.TestRule;
-import org.junit.rules.Timeout;
 import org.junit.runner.Description;
 import org.junit.runners.model.InitializationError;
@@ -33 +32 @@
  */
 public class JOSMTestRules implements TestRule {
-    private Timeout timeout = Timeout.seconds(10);
+    private int timeout = 10 * 1000;
     private TemporaryFolder josmHome;
     private boolean usePreferences = false;
@@ -46 +45 @@
      */
     public JOSMTestRules noTimeout() {
-        timeout = null;
+        timeout = -1;
         return this;
     }
@@ -56 +55 @@
      */
     public JOSMTestRules timeout(int millis) {
-        timeout = Timeout.millis(millis);
+        timeout = millis;
         return this;
     }
@@ -135 +134 @@
 
     @Override
-    public Statement apply(final Statement base, Description description) {
-        Statement statement = new Statement() {
-            @Override
-            public void evaluate() throws Throwable {
-                before();
-                try {
-                    base.evaluate();
-                } finally {
-                    after();
-                }
-            }
-        };
-        if (timeout != null) {
-            statement = new DisableOnDebug(timeout).apply(statement, description);
-        }
+    public Statement apply(Statement base, Description description) {
+        Statement statement = base;
+        if (timeout > 0) {
+            // TODO: new DisableOnDebug(timeout)
+            statement = new FailOnTimeoutStatement(statement, timeout);
+        }
+        statement = new CreateJosmEnvironment(statement);
         if (josmHome != null) {
             statement = josmHome.apply(statement, description);
@@ -254 +245 @@
     }
 
+    private final class CreateJosmEnvironment extends Statement {
+        private final Statement base;
+
+        private CreateJosmEnvironment(Statement base) {
+            this.base = base;
+        }
+
+        @Override
+        public void evaluate() throws Throwable {
+            before();
+            try {
+                base.evaluate();
+            } finally {
+                after();
+            }
+        }
+    }
+
     enum APIType {
         NONE, FAKE, DEV
     }
+
+    /**
+     * The junit timeout statement has problems when switchting timezones. This one does not.
+     * @author Michael Zangl
+     */
+    private static class FailOnTimeoutStatement extends Statement {
+
+        private int timeout;
+        private Statement original;
+
+        FailOnTimeoutStatement(Statement original, int timeout) {
+            this.original = original;
+            this.timeout = timeout;
+        }
+
+        @Override
+        public void evaluate() throws Throwable {
+            TimeoutThread thread = new TimeoutThread(original);
+            thread.setDaemon(true);
+            thread.start();
+            thread.join(timeout);
+            thread.interrupt();
+            if (!thread.isDone) {
+                Throwable exception = thread.getExecutionException();
+                if (exception != null) {
+                    throw exception;
+                } else {
+                    throw new Exception(MessageFormat.format("Test timed out after {0}ms", timeout));
+                }
+            }
+        }
+    }
+
+    private static final class TimeoutThread extends Thread {
+        public boolean isDone;
+        private Statement original;
+        private Throwable exceptionCaught;
+
+        private TimeoutThread(Statement original) {
+            super("Timeout runner");
+            this.original = original;
+        }
+
+        public Throwable getExecutionException() {
+            return exceptionCaught;
+        }
+
+        @Override
+        public void run() {
+            try {
+                original.evaluate();
+                isDone = true;
+            } catch (Throwable e) {
+                exceptionCaught = e;
+            }
+        }
+    }
 }

trunk/test/unit/org/openstreetmap/josm/tools/ExifReaderTest.java

@@ -35 +35 @@
     @Rule
     @SuppressFBWarnings(value = "URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD")
-    public JOSMTestRules test = new JOSMTestRules().timeout(60000);
+    public JOSMTestRules test = new JOSMTestRules();
 
     private File orientationSampleFile, directionSampleFile;

trunk/test/unit/org/openstreetmap/josm/tools/date/DateUtilsTest.java

@@ -23 +23 @@
 
     /**
-     * Set the timezone and no timeout (junit timeout task seems to have problems with it when switching time zones).
+     * Set the timezone and timeout.
+     * <p>
+     * Timeouts need to be disabled because we change the time zone.
      */
     @Rule
     @SuppressFBWarnings(value = "URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD")
-    public JOSMTestRules test = new JOSMTestRules().i18n().preferences().noTimeout();
+    public JOSMTestRules test = new JOSMTestRules().i18n().preferences();
 
     /**