Changeset 10558 in josm for trunk/src/org/openstreetmap

Timestamp:

2016-07-17T20:43:22+02:00 (8 years ago)

Author:

wiktorn

Message:

Do not cache IOException in JCS, they should be cached only in memory.

Caching IOException in JCS Cache leads to the situation, where errors
are cached for DEFAULT_EXPIRE_TIME which causes the error message to
stay too long on user screen.

Fix tests for JCSCachedTileLoaderJob

See: #13128

File:

• trunk/src/org/openstreetmap/josm/data/cache/JCSCachedTileLoaderJob.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/cache/JCSCachedTileLoaderJob.java

@@ -391 +391 @@
             } else {
                 attributes.setError(e);
-                attributes.setResponseCode(499); // set dummy error code
-                boolean doCache = isResponseLoadable(null, 499, null) || cacheAsEmpty(); //generic 499 error code returned
-                if (doCache) {
-                    cacheData = createCacheEntry(new byte[]{});
-                    cache.put(getCacheKey(), createCacheEntry(new byte[]{}), attributes);
-                }
-                return doCache;
+                attributes.setResponseCode(599); // set dummy error code, greater than 500 so it will be not cached
+                return false;
             }