Changeset 10396 in josm for trunk/test/unit/org/openstreetmap

Timestamp:

2016-06-16T12:38:56+02:00 (8 years ago)

Author:

Don-vip

Message:

gsoc-core - remove more deprecation warnings (unit tests)

Location:

trunk/test/unit/org/openstreetmap/josm

Files:

• JOSMFixture.java (modified) (1 diff)
• actions/AddImageryLayerActionTest.java (modified) (1 diff)
• actions/mapmode/DrawActionTest.java (modified) (1 diff)
• actions/mapmode/MapViewMock.java (modified) (2 diffs)
• actions/mapmode/SelectActionTest.java (modified) (1 diff)
• gui/dialogs/layer/LayerVisibilityActionTest.java (modified) (2 diffs)
• gui/layer/geoimage/GeoImageLayerTest.java (modified) (1 diff)
• io/NoteImporterTest.java (modified) (1 diff)
• io/session/SessionReaderTest.java (modified) (1 diff)

trunk/test/unit/org/openstreetmap/josm/JOSMFixture.java

@@ -125 +125 @@
             } else {
                 for (Layer l: Main.getLayerManager().getLayers()) {
-                    Main.map.mapView.removeLayer(l);
+                    Main.getLayerManager().removeLayer(l);
                 }
             }

trunk/test/unit/org/openstreetmap/josm/actions/AddImageryLayerActionTest.java

@@ -54 +54 @@
             assertEquals(1, wmsLayers.size());
 
-            Main.map.mapView.removeLayer(wmsLayers.get(0));
+            Main.getLayerManager().removeLayer(wmsLayers.get(0));
         } finally {
-            Main.map.mapView.removeLayer(tmsLayers.get(0));
+            Main.getLayerManager().removeLayer(tmsLayers.get(0));
         }
     }

trunk/test/unit/org/openstreetmap/josm/actions/mapmode/DrawActionTest.java

@@ -56 +56 @@
         Field mapView = MapFrame.class.getDeclaredField("mapView");
         Utils.setObjectsAccessible(mapView);
-        mapView.set(Main.map, new MapViewMock(dataSet, layer));
+        mapView.set(Main.map, new MapViewMock());
 
         Node n1 = new Node(new EastNorth(0, 0));

trunk/test/unit/org/openstreetmap/josm/actions/mapmode/MapViewMock.java

@@ -8 +8 @@
 import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.data.coor.EastNorth;
-import org.openstreetmap.josm.data.osm.DataSet;
 import org.openstreetmap.josm.gui.MapView;
-import org.openstreetmap.josm.gui.layer.Layer;
-import org.openstreetmap.josm.gui.layer.OsmDataLayer;
 
 class MapViewMock extends MapView {
-    private final transient OsmDataLayer layer;
-    private final transient DataSet currentDataSet;
-
-    MapViewMock(DataSet dataSet, OsmDataLayer layer) {
+    MapViewMock() {
         super(Main.getLayerManager(), null, null);
-        this.layer = layer;
-        this.currentDataSet = dataSet;
     }
 
@@ -52 +44 @@
         return p != null ? new Point2D.Double(p.getX(), p.getY()) : null;
     }
-
-    @Override
-    public void setActiveLayer(Layer layer) {}
-
-    @Override
-    public Layer getActiveLayer() {
-        return layer;
-    }
-
-    @Override
-    protected DataSet getCurrentDataSet() {
-        return currentDataSet;
-    }
 }

trunk/test/unit/org/openstreetmap/josm/actions/mapmode/SelectActionTest.java

@@ -55 +55 @@
                 Field mv = SelectAction.class.getDeclaredField("mv");
                 Utils.setObjectsAccessible(mv);
-                mv.set(this, new MapViewMock(dataSet, layer));
+                mv.set(this, new MapViewMock());
             } catch (ReflectiveOperationException e) {
                 e.printStackTrace();

trunk/test/unit/org/openstreetmap/josm/gui/dialogs/layer/LayerVisibilityActionTest.java

@@ -40 +40 @@
             assertFalse(action.isEnabled());
 
-            Main.map.mapView.addLayer(layer);
+            Main.getLayerManager().addLayer(layer);
             action.updateEnabledState();
             assertTrue(action.isEnabled());
@@ -87 +87 @@
 
         } finally {
-            Main.map.mapView.removeLayer(layer);
+            Main.getLayerManager().removeLayer(layer);
         }
     }

trunk/test/unit/org/openstreetmap/josm/gui/layer/geoimage/GeoImageLayerTest.java

@@ -58 +58 @@
                 } finally {
                     // Ensure we clean the place before leaving, even if test fails.
-                    Main.map.mapView.removeLayer(layer);
+                    Main.getLayerManager().removeLayer(layer);
                 }
             } finally {

trunk/test/unit/org/openstreetmap/josm/io/NoteImporterTest.java

@@ -24 +24 @@
         if (Main.map != null) {
             for (Layer l: Main.getLayerManager().getLayers()) {
-                Main.map.mapView.removeLayer(l);
+                Main.getLayerManager().removeLayer(l);
             }
             Main.main.setMapFrame(null);

trunk/test/unit/org/openstreetmap/josm/io/session/SessionReaderTest.java

@@ -140 +140 @@
         if (Main.isDisplayingMapView()) {
             for (NoteLayer nl : Main.getLayerManager().getLayersOfType(NoteLayer.class)) {
-                Main.map.mapView.removeLayer(nl);
+                Main.getLayerManager().removeLayer(nl);
             }
         }