Changeset 10372 in josm for trunk/src/org

Timestamp:

2016-06-14T18:50:32+02:00 (8 years ago)

Author:

Don-vip

Message:

fix #12945 - Better exception wrapping for runInEDTAndWaitWithException (patch by michael2402) - gsoc-core

File:

• trunk/src/org/openstreetmap/josm/gui/util/GuiHelper.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/util/GuiHelper.java

@@ -62 +62 @@
 import org.openstreetmap.josm.tools.ImageProvider.ImageSizes;
 import org.openstreetmap.josm.tools.LanguageInfo;
+import org.openstreetmap.josm.tools.bugreport.BugReport;
+import org.openstreetmap.josm.tools.bugreport.ReportedException;
 
 /**
@@ -135 +137 @@
      * <p>
      * Passes on the exception that was thrown to the thread calling this.
-     * The exception is wrapped in a {@link RuntimeException} if it was a normal {@link Throwable}.
+     * The exception is wrapped using a {@link ReportedException}.
      * @param task The runnable to execute
      * @see SwingUtilities#invokeAndWait
@@ -146 +148 @@
             try {
                 SwingUtilities.invokeAndWait(task);
-            } catch (InterruptedException e) {
-                Main.error(e);
-            } catch (InvocationTargetException e) {
-                if (e.getCause() instanceof RuntimeException) {
-                    throw (RuntimeException) e.getCause();
-                } else {
-                    throw new RuntimeException("Exception while calling " + task, e.getCause());
-                }
+            } catch (InterruptedException | InvocationTargetException e) {
+                throw BugReport.intercept(e).put("task", task);
             }
         }