Changeset 10093 in josm for trunk/src

Timestamp:

2016-04-01T15:40:44+02:00 (9 years ago)

Author:

Don-vip

Message:

add more unit tests

Location:

trunk/src/org/openstreetmap/josm

Files:

• gui/MainApplication.java (modified) (4 diffs)
• gui/SplashScreen.java (modified) (1 diff)
• plugins/PluginHandler.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/gui/MainApplication.java

@@ -52 +52 @@
 import org.openstreetmap.josm.data.CustomConfigurator;
 import org.openstreetmap.josm.data.Version;
+import org.openstreetmap.josm.gui.SplashScreen.SplashProgressMonitor;
 import org.openstreetmap.josm.gui.download.DownloadDialog;
 import org.openstreetmap.josm.gui.preferences.server.OAuthAccessTokenHolder;
@@ -446 +447 @@
         Collection<PluginInformation> pluginsToLoad = null;
 
-
         if (!skipLoadingPlugins) {
-            pluginsToLoad = PluginHandler.buildListOfPluginsToLoad(splash, monitor.createSubTaskMonitor(1, false));
-            if (!pluginsToLoad.isEmpty() && PluginHandler.checkAndConfirmPluginUpdate(splash)) {
-                monitor.subTask(tr("Updating plugins"));
-                pluginsToLoad = PluginHandler.updatePlugins(splash, null, monitor.createSubTaskMonitor(1, false), false);
-            }
-
-            monitor.indeterminateSubTask(tr("Installing updated plugins"));
-            PluginHandler.installDownloadedPlugins(true);
-
-            monitor.indeterminateSubTask(tr("Loading early plugins"));
-            PluginHandler.loadEarlyPlugins(splash, pluginsToLoad, monitor.createSubTaskMonitor(1, false));
+            pluginsToLoad = updateAndLoadEarlyPlugins(splash, monitor);
         }
 
@@ -468 +458 @@
 
         if (!skipLoadingPlugins) {
-            monitor.indeterminateSubTask(tr("Loading plugins"));
-            PluginHandler.loadLatePlugins(splash, pluginsToLoad,  monitor.createSubTaskMonitor(1, false));
-            toolbar.refreshToolbarControl();
+            loadLatePlugins(splash, monitor, pluginsToLoad);
         }
 
@@ -525 +513 @@
             RepaintManager.setCurrentManager(new CheckThreadViolationRepaintManager());
         }
+    }
+
+    static Collection<PluginInformation> updateAndLoadEarlyPlugins(SplashScreen splash, SplashProgressMonitor monitor) {
+        Collection<PluginInformation> pluginsToLoad;
+        pluginsToLoad = PluginHandler.buildListOfPluginsToLoad(splash, monitor.createSubTaskMonitor(1, false));
+        if (!pluginsToLoad.isEmpty() && PluginHandler.checkAndConfirmPluginUpdate(splash)) {
+            monitor.subTask(tr("Updating plugins"));
+            pluginsToLoad = PluginHandler.updatePlugins(splash, null, monitor.createSubTaskMonitor(1, false), false);
+        }
+
+        monitor.indeterminateSubTask(tr("Installing updated plugins"));
+        PluginHandler.installDownloadedPlugins(true);
+
+        monitor.indeterminateSubTask(tr("Loading early plugins"));
+        PluginHandler.loadEarlyPlugins(splash, pluginsToLoad, monitor.createSubTaskMonitor(1, false));
+        return pluginsToLoad;
+    }
+
+    static void loadLatePlugins(SplashScreen splash, SplashProgressMonitor monitor, Collection<PluginInformation> pluginsToLoad) {
+        monitor.indeterminateSubTask(tr("Loading plugins"));
+        PluginHandler.loadLatePlugins(splash, pluginsToLoad, monitor.createSubTaskMonitor(1, false));
+        toolbar.refreshToolbarControl();
     }
 

trunk/src/org/openstreetmap/josm/gui/SplashScreen.java

@@ -197 +197 @@
         private SplashProgressMonitor latestSubtask;
 
+        /**
+         * Constructs a new {@code SplashProgressMonitor}.
+         * @param name name
+         * @param listener change listener
+         */
         public SplashProgressMonitor(String name, ChangeListener listener) {
             this.name = name;

trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java

@@ -8 +8 @@
 import java.awt.Component;
 import java.awt.Font;
+import java.awt.GraphicsEnvironment;
 import java.awt.GridBagConstraints;
 import java.awt.GridBagLayout;
@@ -276 +277 @@
      * @param plugins the collection of plugins
      */
-    private static void filterDeprecatedPlugins(Component parent, Collection<String> plugins) {
+    static void filterDeprecatedPlugins(Component parent, Collection<String> plugins) {
         Set<DeprecatedPlugin> removedPlugins = new TreeSet<>();
         for (DeprecatedPlugin depr : DEPRECATED_PLUGINS) {
@@ -305 +306 @@
         }
         sb.append("</ul></html>");
-        JOptionPane.showMessageDialog(
-                parent,
-                sb.toString(),
-                tr("Warning"),
-                JOptionPane.WARNING_MESSAGE
-        );
+        if (!GraphicsEnvironment.isHeadless()) {
+            JOptionPane.showMessageDialog(
+                    parent,
+                    sb.toString(),
+                    tr("Warning"),
+                    JOptionPane.WARNING_MESSAGE
+            );
+        }
     }
 
@@ -323 +326 @@
      * @param plugins the collection of plugins
      */
-    private static void filterUnmaintainedPlugins(Component parent, Collection<String> plugins) {
+    static void filterUnmaintainedPlugins(Component parent, Collection<String> plugins) {
         for (String unmaintained : UNMAINTAINED_PLUGINS) {
             if (!plugins.contains(unmaintained)) {