Changeset 10079 in josm

Timestamp:

2016-03-29T23:07:24+02:00 (8 years ago)

Author:

Don-vip

Message:

checkstyle, fix unit test

Location:

trunk

Files:

• src/org/openstreetmap/josm/gui/MapScaler.java (modified) (2 diffs)
• src/org/openstreetmap/josm/io/CertificateAmendment.java (modified) (1 diff)
• test/unit/org/openstreetmap/josm/gui/TableCellRendererTest.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/MapScaler.java

@@ -26 +26 @@
     private final NavigatableComponent mv;
 
-    private final static int PADDING_LEFT = 5;
-    private final static int PADDING_RIGHT = 50;
+    private static final int PADDING_LEFT = 5;
+    private static final int PADDING_RIGHT = 50;
 
     /**
@@ -121 +121 @@
          * @param width The width of the mark.
          */
-        public TickMarks(double dist100Pixel, int width) {
+        TickMarks(double dist100Pixel, int width) {
             this.dist100Pixel = dist100Pixel;
             lineDistance = dist100Pixel * width / 100;

trunk/src/org/openstreetmap/josm/io/CertificateAmendment.java

@@ -96 +96 @@
             byte[] sha = md.digest(certBytes);
             if (!SHA_HASHES[i].equals(Utils.toHexString(sha)))
-                throw new RuntimeException(tr("Error adding certificate {0} - hash mismatch. Expected {1}, was {2}", CERT_AMEND[i], SHA_HASHES[i], Utils.toHexString(sha)));
+                throw new RuntimeException(tr("Error adding certificate {0} - hash mismatch. Expected {1}, was {2}",
+                        CERT_AMEND[i], SHA_HASHES[i], Utils.toHexString(sha)));
 
             ByteArrayInputStream certIS = new ByteArrayInputStream(certBytes);

trunk/test/unit/org/openstreetmap/josm/gui/TableCellRendererTest.java

@@ -32 +32 @@
  * value to check if a NPE is thrown.
  *
- * @see #6301
+ * @see <a href="https://josm.openstreetmap.de/ticket/6301">#6301</a>
  */
 public class TableCellRendererTest {
 
-    // list of classes that cannot be easily tested and are verified manually
+    // list of classes that cannot be easily tested and are verified either manually or another unit tests
     private static final Collection<String> SKIP_TEST = Arrays.asList(
-        "org.openstreetmap.josm.gui.dialogs.FilterDialog$BooleanRenderer"
+        "org.openstreetmap.josm.gui.dialogs.FilterDialog$BooleanRenderer",
+        "org.openstreetmap.josm.gui.dialogs.relation.SelectionTableCellRenderer"
     );
 
@@ -49 +50 @@
     }
 
+    /**
+     * Unit test of all table cell renderers against null values.
+     */
     @Test
     public void tableCellRendererTest() {