Changeset 10045 in josm

Timestamp:

2016-03-26T15:10:06+01:00 (9 years ago)

Author:

Don-vip

Message:

sonar - squid:S2129 - Constructors should not be used to instantiate "String" and primitive-wrapper classes

Location:

trunk/src/org/openstreetmap/josm

Files:

• gui/mappaint/Cascade.java (modified) (2 diffs)
• gui/mappaint/mapcss/ExpressionFactory.java (modified) (1 diff)
• io/GpxReader.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/mappaint/Cascade.java

@@ -90 +90 @@
             o = toFloat(o);
             if (o != null) {
-                o = new Double((Float) o);
+                o = Double.valueOf((Float) o);
             }
             return (T) o;
@@ -113 +113 @@
                     return (T) String.format("#%06x%02x", ((Color) o).getRGB() & 0x00ffffff, alpha);
                 return (T) String.format("#%06x", ((Color) o).getRGB() & 0x00ffffff);
-
             }
 

trunk/src/org/openstreetmap/josm/gui/mappaint/mapcss/ExpressionFactory.java

@@ -517 +517 @@
                 return null;
             }
-            return new Float(env.index + 1);
+            return Float.valueOf(env.index + 1f);
         }
 

trunk/src/org/openstreetmap/josm/io/GpxReader.java

@@ -410 +410 @@
                         currentWayPoint.put(localName, Float.valueOf(accumulator.toString()));
                     } catch (Exception e) {
-                        currentWayPoint.put(localName, new Float(0));
+                        currentWayPoint.put(localName, 0f);
                     }
                     break;