Changeset 10032 in josm for trunk/src/org/openstreetmap

Timestamp:

2016-03-23T21:36:16+01:00 (9 years ago)

Author:

Don-vip

Message:

fix #12651 - do not create Notes layer when no notes were downloaded

File:

• trunk/src/org/openstreetmap/josm/actions/downloadtasks/DownloadNotesTask.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/actions/downloadtasks/DownloadNotesTask.java

@@ -106 +106 @@
         protected void finish() {
             rememberDownloadedData(new NoteData(notesData));
-            if (isCanceled() || isFailed()) {
-                return;
-            }
-
-            if (notesData == null) {
+            if (isCanceled() || isFailed() || notesData == null || notesData.isEmpty()) {
                 return;
             }
@@ -121 +117 @@
                 noteLayers = Main.map.mapView.getLayersOfType(NoteLayer.class);
             }
-            NoteLayer layer;
             if (noteLayers != null && !noteLayers.isEmpty()) {
-                layer = noteLayers.get(0);
-                layer.getNoteData().addNotes(notesData);
+                noteLayers.get(0).getNoteData().addNotes(notesData);
             } else {
-                layer = new NoteLayer(notesData, tr("Notes"));
-                Main.main.addLayer(layer);
+                Main.main.addLayer(new NoteLayer(notesData, tr("Notes")));
             }
         }