1 | // License: GPL. For details, see LICENSE file.
|
---|
2 | package relcontext.relationfix;
|
---|
3 |
|
---|
4 | import static org.openstreetmap.josm.tools.I18n.tr;
|
---|
5 |
|
---|
6 | import java.util.ArrayList;
|
---|
7 | import java.util.List;
|
---|
8 |
|
---|
9 | import org.openstreetmap.josm.command.ChangeMembersCommand;
|
---|
10 | import org.openstreetmap.josm.command.Command;
|
---|
11 | import org.openstreetmap.josm.data.osm.DataSet;
|
---|
12 | import org.openstreetmap.josm.data.osm.Node;
|
---|
13 | import org.openstreetmap.josm.data.osm.OsmPrimitiveType;
|
---|
14 | import org.openstreetmap.josm.data.osm.Relation;
|
---|
15 | import org.openstreetmap.josm.data.osm.RelationMember;
|
---|
16 | import org.openstreetmap.josm.gui.MainApplication;
|
---|
17 | import org.openstreetmap.josm.tools.Utils;
|
---|
18 |
|
---|
19 | /**
|
---|
20 | * Fix multipolygon boundaries
|
---|
21 | * @see <a href="https://wiki.openstreetmap.org/wiki/Relation:boundary">osmwiki:Relation:boundary</a>
|
---|
22 | */
|
---|
23 | public class BoundaryFixer extends MultipolygonFixer {
|
---|
24 |
|
---|
25 | public BoundaryFixer() {
|
---|
26 | super("boundary", "multipolygon");
|
---|
27 | }
|
---|
28 |
|
---|
29 | /**
|
---|
30 | * For boundary relations both "boundary" and "multipolygon" types are applicable, but
|
---|
31 | * it should also have key boundary=administrative to be fully boundary.
|
---|
32 | * @see <a href="https://wiki.openstreetmap.org/wiki/Relation:boundary">osmwiki:Relation:boundary</a>
|
---|
33 | */
|
---|
34 | @Override
|
---|
35 | public boolean isFixerApplicable(Relation rel) {
|
---|
36 | return super.isFixerApplicable(rel) && "administrative".equals(rel.get("boundary"));
|
---|
37 | }
|
---|
38 |
|
---|
39 | @Override
|
---|
40 | public boolean isRelationGood(Relation rel) {
|
---|
41 | for (RelationMember m : rel.getMembers()) {
|
---|
42 | if (m.getType() == OsmPrimitiveType.RELATION && !"subarea".equals(m.getRole())) {
|
---|
43 | setWarningMessage(tr("Relation without ''subarea'' role found"));
|
---|
44 | return false;
|
---|
45 | }
|
---|
46 | if (m.getType() == OsmPrimitiveType.NODE && !("label".equals(m.getRole()) || "admin_centre".equals(m.getRole()))) {
|
---|
47 | setWarningMessage(tr("Node without ''label'' or ''admin_centre'' role found"));
|
---|
48 | return false;
|
---|
49 | }
|
---|
50 | if (m.getType() == OsmPrimitiveType.WAY && !("outer".equals(m.getRole()) || "inner".equals(m.getRole()))) {
|
---|
51 | setWarningMessage(tr("Way without ''inner'' or ''outer'' role found"));
|
---|
52 | return false;
|
---|
53 | }
|
---|
54 | }
|
---|
55 | clearWarningMessage();
|
---|
56 | return true;
|
---|
57 | }
|
---|
58 |
|
---|
59 | @Override
|
---|
60 | public Command fixRelation(Relation rel) {
|
---|
61 | List<RelationMember> members = fixMultipolygonRoles(rel.getMembers());
|
---|
62 | if (members.isEmpty()) {
|
---|
63 | members = rel.getMembers();
|
---|
64 | }
|
---|
65 | members = fixBoundaryRoles(members);
|
---|
66 | if (!members.equals(rel.getMembers())) {
|
---|
67 | final DataSet ds = Utils.firstNonNull(rel.getDataSet(), MainApplication.getLayerManager().getEditDataSet());
|
---|
68 | return new ChangeMembersCommand(ds, rel, members);
|
---|
69 | }
|
---|
70 | return null;
|
---|
71 | }
|
---|
72 |
|
---|
73 | /**
|
---|
74 | * Possibly change roles of non-way members.
|
---|
75 | * @param origMembers original list of relation members
|
---|
76 | * @return either the original and unmodified list or a new one with at least one new item
|
---|
77 | */
|
---|
78 | private static List<RelationMember> fixBoundaryRoles(List<RelationMember> origMembers) {
|
---|
79 | List<RelationMember> members = origMembers;
|
---|
80 | for (int i = 0; i < members.size(); i++) {
|
---|
81 | RelationMember m = members.get(i);
|
---|
82 | String role = null;
|
---|
83 | if (m.isRelation()) {
|
---|
84 | role = "subarea";
|
---|
85 | } else if (m.isNode() && !m.getMember().isIncomplete()) {
|
---|
86 | Node n = (Node) m.getMember();
|
---|
87 | if (n.hasKey("place")) {
|
---|
88 | String place = n.get("place");
|
---|
89 | if ("state".equals(place) || "country".equals(place) ||
|
---|
90 | "county".equals(place) || "region".equals(place)) {
|
---|
91 | role = "label";
|
---|
92 | } else {
|
---|
93 | role = "admin_centre";
|
---|
94 | }
|
---|
95 | } else {
|
---|
96 | role = "label";
|
---|
97 | }
|
---|
98 | }
|
---|
99 | if (role != null && !role.equals(m.getRole())) {
|
---|
100 | if (members == origMembers) {
|
---|
101 | members = new ArrayList<>(origMembers); // don't modify original list
|
---|
102 | }
|
---|
103 | members.set(i, new RelationMember(role, m.getMember()));
|
---|
104 | }
|
---|
105 | }
|
---|
106 | return members;
|
---|
107 | }
|
---|
108 | }
|
---|