source: josm/trunk/src/org/openstreetmap/josm/io/remotecontrol/handler/AddWayHandler.java@ 18134

Last change on this file since 18134 was 18134, checked in by Don-vip, 3 years ago

fix #21231 - make sure remote control request handlers do not block thread with time-consuming operations

  • Property svn:eol-style set to native
File size: 6.6 KB
Line 
1// License: GPL. For details, see LICENSE file.
2package org.openstreetmap.josm.io.remotecontrol.handler;
3
4import static org.openstreetmap.josm.tools.I18n.tr;
5
6import java.util.ArrayList;
7import java.util.Arrays;
8import java.util.Collections;
9import java.util.HashMap;
10import java.util.LinkedList;
11import java.util.List;
12import java.util.Map;
13import java.util.Map.Entry;
14
15import org.openstreetmap.josm.actions.AutoScaleAction;
16import org.openstreetmap.josm.actions.AutoScaleAction.AutoScaleMode;
17import org.openstreetmap.josm.command.AddCommand;
18import org.openstreetmap.josm.command.Command;
19import org.openstreetmap.josm.command.SequenceCommand;
20import org.openstreetmap.josm.data.UndoRedoHandler;
21import org.openstreetmap.josm.data.coor.LatLon;
22import org.openstreetmap.josm.data.osm.DataSet;
23import org.openstreetmap.josm.data.osm.Node;
24import org.openstreetmap.josm.data.osm.OsmDataManager;
25import org.openstreetmap.josm.data.osm.OsmPrimitive;
26import org.openstreetmap.josm.data.osm.Way;
27import org.openstreetmap.josm.gui.MainApplication;
28import org.openstreetmap.josm.gui.MapView;
29import org.openstreetmap.josm.gui.util.GuiHelper;
30import org.openstreetmap.josm.io.remotecontrol.AddTagsDialog;
31import org.openstreetmap.josm.io.remotecontrol.PermissionPrefWithDefault;
32import org.openstreetmap.josm.spi.preferences.Config;
33
34/**
35 * Adds a way to the current dataset. For instance, {@code /add_way?way=lat1,lon2;lat2,lon2}.
36 */
37public class AddWayHandler extends RequestHandler {
38
39 /**
40 * The remote control command name used to add a way.
41 */
42 public static final String command = "add_way";
43
44 private final List<LatLon> allCoordinates = new ArrayList<>();
45
46 /**
47 * The place to remember already added nodes (they are reused if needed @since 5845
48 */
49 private Map<LatLon, Node> addedNodes;
50
51 @Override
52 public String[] getMandatoryParams() {
53 return new String[]{"way"};
54 }
55
56 @Override
57 public String[] getOptionalParams() {
58 return new String[] {"addtags"};
59 }
60
61 @Override
62 public String getUsage() {
63 return "adds a way (given by a semicolon separated sequence of lat,lon pairs) to the current dataset";
64 }
65
66 @Override
67 public String[] getUsageExamples() {
68 return new String[] {
69 // CHECKSTYLE.OFF: LineLength
70 "/add_way?way=53.2,13.3;53.3,13.3;53.3,13.2",
71 "/add_way?&addtags=building=yes&way=45.437213,-2.810792;45.437988,-2.455983;45.224080,-2.455036;45.223302,-2.809845;45.437213,-2.810792"
72 // CHECKSTYLE.ON: LineLength
73 };
74 }
75
76 @Override
77 protected void handleRequest() throws RequestHandlerErrorException, RequestHandlerBadRequestException {
78 GuiHelper.runInEDT(this::addWay);
79 }
80
81 @Override
82 public String getPermissionMessage() {
83 return tr("Remote Control has been asked to create a new way.");
84 }
85
86 @Override
87 public PermissionPrefWithDefault getPermissionPref() {
88 return PermissionPrefWithDefault.CREATE_OBJECTS;
89 }
90
91 @Override
92 protected void validateRequest() throws RequestHandlerBadRequestException {
93 allCoordinates.clear();
94 for (String coordinatesString : splitArg("way", SPLITTER_SEMIC)) {
95 String[] coordinates = coordinatesString.split(",\\s*", 2);
96 if (coordinates.length < 2) {
97 throw new RequestHandlerBadRequestException(
98 tr("Invalid coordinates: {0}", Arrays.toString(coordinates)));
99 }
100 try {
101 double lat = Double.parseDouble(coordinates[0]);
102 double lon = Double.parseDouble(coordinates[1]);
103 allCoordinates.add(new LatLon(lat, lon));
104 } catch (NumberFormatException e) {
105 throw new RequestHandlerBadRequestException("NumberFormatException ("+e.getMessage()+')', e);
106 }
107 }
108 if (allCoordinates.isEmpty()) {
109 throw new RequestHandlerBadRequestException(tr("Empty ways"));
110 } else if (allCoordinates.size() == 1) {
111 throw new RequestHandlerBadRequestException(tr("One node ways"));
112 }
113 if (MainApplication.getLayerManager().getEditLayer() == null) {
114 throw new RequestHandlerBadRequestException(tr("There is no layer opened to add way"));
115 }
116 }
117
118 /**
119 * Find the node with almost the same coords in dataset or in already added nodes
120 * @param ll coordinates
121 * @param commands list of commands that will be modified if needed
122 * @return node with almost the same coords
123 * @since 5845
124 */
125 Node findOrCreateNode(LatLon ll, List<Command> commands) {
126 Node nd = null;
127
128 if (MainApplication.isDisplayingMapView()) {
129 MapView mapView = MainApplication.getMap().mapView;
130 nd = mapView.getNearestNode(mapView.getPoint(ll), OsmPrimitive::isUsable);
131 if (nd != null && nd.getCoor().greatCircleDistance(ll) > Config.getPref().getDouble("remote.tolerance", 0.1)) {
132 nd = null; // node is too far
133 }
134 }
135
136 Node prev = null;
137 for (Entry<LatLon, Node> entry : addedNodes.entrySet()) {
138 LatLon lOld = entry.getKey();
139 if (lOld.greatCircleDistance(ll) < Config.getPref().getDouble("remotecontrol.tolerance", 0.1)) {
140 prev = entry.getValue();
141 break;
142 }
143 }
144
145 if (prev != null) {
146 nd = prev;
147 } else if (nd == null) {
148 nd = new Node(ll);
149 // Now execute the commands to add this node.
150 commands.add(new AddCommand(OsmDataManager.getInstance().getEditDataSet(), nd));
151 addedNodes.put(ll, nd);
152 }
153 return nd;
154 }
155
156 /**
157 * This function creates the way with given coordinates of nodes
158 */
159 private void addWay() {
160 addedNodes = new HashMap<>();
161 Way way = new Way();
162 List<Command> commands = new LinkedList<>();
163 for (LatLon ll : allCoordinates) {
164 Node node = findOrCreateNode(ll, commands);
165 way.addNode(node);
166 }
167 allCoordinates.clear();
168 DataSet ds = MainApplication.getLayerManager().getEditDataSet();
169 commands.add(new AddCommand(ds, way));
170 UndoRedoHandler.getInstance().add(new SequenceCommand(tr("Add way"), commands));
171 ds.setSelected(way);
172 if (PermissionPrefWithDefault.CHANGE_VIEWPORT.isAllowed()) {
173 AutoScaleAction.autoScale(AutoScaleMode.SELECTION);
174 } else {
175 MainApplication.getMap().mapView.repaint();
176 }
177 // parse parameter addtags=tag1=value1|tag2=value2
178 AddTagsDialog.addTags(args, sender, Collections.singleton(way));
179 }
180}
Note: See TracBrowser for help on using the repository browser.