source: josm/trunk/resources/data/validator/geometry.mapcss@ 18289

Last change on this file since 18289 was 18229, checked in by Don-vip, 3 years ago

fix #20465 - skip "shop node connected to a highway" for highway=corridor (patch by reichg)

  • Property svn:eol-style set to native
File size: 15.5 KB
Line 
1/* {0} on a node, should be a way */
2node[area=no],
3node[oneway],
4node[bridge],
5node[sidewalk],
6node[footway][footway!=crossing], /* footway=crossing has own warning in highway.mapcss */
7node[man_made=embankment],
8node[man_made=groyne],
9node[man_made=cutline],
10node[power=line],
11node[cutline],
12node[aerialway=cable_car],
13node[aerialway=gondola],
14node[aerialway=chair_lift],
15node[aerialway=mixed_lift],
16node[aerialway=drag_lift],
17node[aerialway=t-bar],
18node[aerialway=j-bar],
19node[aerialway=platter],
20node[aerialway=magic_carpet],
21node[aerialway=rope_tow],
22node[aerialway=goods],
23node[aeroway=taxiway],
24node[aeroway=runway],
25node[railway=rail],
26node[railway=narrow_gauge],
27node[railway=monorail],
28node[railway=preserved],
29node[railway=light_rail],
30node[railway=subway],
31node[railway=tram],
32node[railway=disused],
33node[railway=abandoned],
34node[waterway=river],
35node[waterway=canal],
36node[waterway=stream],
37node[waterway=ditch],
38node[waterway=drain],
39node[natural=coastline],
40node[natural=ridge],
41node[natural=valley],
42node[natural=tree_row] {
43 throwWarning: tr("{0} on a node. Should be used on a way.", "{0.tag}");
44 assertMatch: "node oneway=-1";
45 assertNoMatch: "way oneway=-1";
46 assertMatch: "node bridge=yes";
47 assertMatch: "node bridge=viaduct";
48}
49
50/* {0} on a node, should be a way or relation */
51node[boundary=administrative] {
52 throwWarning: tr("{0} on a node. Should be used on a way or relation.", "{0.tag}");
53}
54
55/* {0} on a node, should be an area; #10679 #16528 #16792 #12502 #17402*/
56node[golf=green],
57node[golf=bunker],
58node[golf=fairway],
59node[area=yes],
60node[area:highway],
61node[landuse],
62node[natural=scree],
63node[natural=scrub],
64node[natural=fell],
65node[natural=heath],
66node[natural=wood],
67node[natural=grassland],
68node[natural=wetland],
69node[natural=water],
70node[natural=mud],
71node[natural=beach],
72node[natural=sand],
73node[natural=wood],
74node[natural=bare_rock],
75node[natural=glacier],
76node[leisure=park][natural!=tree], /* For nodes with both tags another warning is created in combinations.mapcss */
77node[leisure=nature_reserve],
78node[waterway=riverbank],
79node[man_made=bridge],
80node[man_made=breakwater],
81node[aeroway=apron],
82node[power=plant],
83node[power=switchgear],
84node[building:part],
85node[source:outline] {
86 throwWarning: tr("{0} on a node. Should be drawn as an area.", "{0.tag}");
87}
88
89/* {0} on a node, should be a relation; Error level; #10252, #10769, #14288 */
90node[type=multipolygon],
91node[interval],
92node[route],
93node[restriction] {
94 throwError: tr("{0} on a node. Should be used in a relation", "{0.tag}");
95}
96
97/* {0} on a way, should be a node */
98way[line_attachment],
99way[line_management],
100way[emergency=fire_hydrant],
101way[emergency=defibrillator],
102way[entrance],
103way[door],
104way[railway=subway_entrance],
105way[man_made=survey_point],
106way[power=transformer],
107way[transformer],
108way[power=pole],
109way[power=catenary_mast],
110way[power=terminal],
111way[power=tower]!:closed,
112way[amenity=vending_machine],
113way[natural=peak],
114way[natural=saddle],
115way[natural=volcano],
116way[natural=tree],
117way[highway=give_way],
118way[highway=milestone],
119way[highway=mini_roundabout],
120way[highway=stop],
121way[highway=street_lamp],
122way[highway=traffic_signals],
123way[highway=turning_loop],
124way[highway=turning_circle],
125way[highway=motorway_junction] {
126 throwWarning: tr("{0} on a way. Should be used on a node.", "{0.tag}");
127}
128
129/* {0} on a way, should be a relation; #15642, #10252, #14288 */
130way[restriction][restriction =~ /^(no_right_turn|no_left_turn|no_u_turn|no_straight_on|only_right_turn|only_left_turn|only_straight_on|no_entry|no_exit)$/],
131way[type=multipolygon],
132way[interval][route!=ferry],
133way[route=bus] {
134 throwError: tr("{0} on a way. Should be used in a relation", "{0.tag}");
135}
136
137/* {0} on a closed way, should be a unclosed way; #19981 */
138way:closed[power=line] {
139 throwWarning: tr("{0} on a closed way. Should be used on an unclosed way.", "{1.tag}");
140}
141
142/* #20902 */
143relation[area?] {
144 throwWarning: tr("{0} on a relation", "{0.key}");
145 fixRemove: "{0.key}";
146}
147
148/* #14395, #17025, #19506 */
149way[highway][area!=yes][!tunnel][!covered] > node {
150 set node_in_highway;
151}
152way[highway][area!=yes][!tunnel][!covered]:closed > node {
153 set node_in_closed_highway;
154}
155way[highway][area!=yes][!tunnel][!covered] >[index=1] node,
156way[highway][area!=yes][!tunnel][!covered] >[index=-1] node {
157 set first_last_highway_node;
158}
159way[building][building!=no] > node[!entrance].node_in_closed_highway {
160 set node_connects_highway_and_building; /* avoids duplicate warnings with following rule */
161 throwWarning: tr("node connects highway and building");
162}
163way[building][building!=no] > node[!entrance].node_in_highway!.first_last_highway_node!.node_connects_highway_and_building {
164 throwWarning: tr("node connects highway and building");
165}
166
167/* #15035, must not warn for node 3815077900*/
168node[man_made!=monitoring_station][at(0.0,0.0)] {
169 throwError: tr("Object at Position 0.00E 0.00N. There is nothing at this position except an already mapped weather buoy.");
170 fixDeleteObject: this;
171}
172
173/* #10125 */
174node[source:geometry] {
175 throwWarning: tr("{0} on a node", "{0.key}");
176 fixChangeKey: "source:geometry => source:position";
177}
178
179/* Building inside building (spatial test) */
180*[building][building!~/no|entrance/][any(tag("layer"),"0") = any(parent_tag("layer"),"0")]
181area[building][building!~/no|entrance/] {
182 throwWarning: tr("Building inside building");
183}
184
185/* Building overlapping building or building:part (spatial test) */
186area[building][building!~/no|entrance/] area[building:part][building:part!~/no|entrance/],
187area[building][building!~/no|entrance/] area[building][building!~/no|entrance/] {
188 throwWarning: tr("Overlapping buildings");
189}
190
191/* Overlapping areas (spatial test) */
192area[natural =~ /^(water|wetland|coastline)$/], area[waterway=riverbank], area[landuse=reservoir] {
193 set water_area;
194}
195
196/* area:closed.water_area ⧉ area:closed.water_area -- does not work for now -- see ticket#10215 */
197area:closed[natural =~ /^(water|wetland|coastline)$/] area:closed.water_area,
198area:closed[waterway=riverbank] area:closed.water_area,
199area:closed[landuse=reservoir] area:closed.water_area {
200 throwWarning: tr("Overlapping Water Areas");
201}
202
203/* Water area inside water area (spatial test) */
204area:closed[natural =~ /^(water|wetland|coastline)$/] area:closed.water_area,
205area:closed[waterway=riverbank] area:closed.water_area,
206area:closed[landuse=reservoir] area:closed.water_area,
207area:closed[natural =~ /^(water|wetland|coastline)$/] area:closed.water_area,
208area:closed[waterway=riverbank] area:closed.water_area,
209area:closed[landuse=reservoir] area:closed.water_area {
210 throwWarning: tr("Water area inside water area");
211}
212
213area:completely_downloaded:closed:areaStyle area:completely_downloaded:closed:areaStyle {
214 throwOther: tr("Overlapping Areas");
215}
216
217/* #9311 */
218node[amenity=parking]["capacity:disabled" !~ /^(yes|[0-9]+)$/] area[amenity=parking] {
219 throwWarning: tr("{0} inside {1}", "amenity=parking", "amenity=parking");
220 group: tr("{0} inside {1}", "amenity", "amenity");
221}
222
223/* #9556, #20570 */
224area:closed:areaStyle[tag("natural") = parent_tag("natural")] area:closed:areaStyle[natural][natural !~ /^(water|wetland|coastline)$/] {
225 throwWarning: tr("Overlapping Identical Natural Areas");
226}
227
228area:closed[tag("landuse") = parent_tag("landuse")] area:closed[landuse] {
229 throwWarning: tr("Overlapping Identical Landuses");
230}
231
232/* #9522 */
233node[tag("amenity") = parent_tag("amenity")] area[amenity][amenity != parking] {
234 throwWarning: tr("{0} inside {1}", concat("amenity=", tag("amenity")), concat("amenity=", tag("amenity")));
235 group: tr("{0} inside {1}", "amenity", "amenity");
236}
237node[tag("leisure") = parent_tag("leisure")] area[leisure] {
238 throwWarning: tr("{0} inside {1}", concat("leisure=", tag("leisure")), concat("leisure=", tag("leisure")));
239 group: tr("{0} inside {1}", "leisure", "leisure");
240}
241node[tag("tourism") = parent_tag("tourism")] area[tourism] {
242 throwWarning: tr("{0} inside {1}", concat("tourism=", tag("tourism")), concat("tourism=", tag("tourism")));
243 group: tr("{0} inside {1}", "tourism", "tourism");
244}
245node[tag("shop") = parent_tag("shop")] area[shop] {
246 throwWarning: tr("{0} inside {1}", concat("shop=", tag("shop")), concat("shop=", tag("shop")));
247 group: tr("{0} inside {1}", "shop", "shop");
248}
249node[tag("power") = parent_tag("power")] area[power] {
250 throwWarning: tr("{0} inside {1}", concat("power=", tag("power")), concat("power=", tag("power")));
251 group: tr("{0} inside {1}", "power", "power");
252}
253
254/* isolated nodes which should be part of a way; #10825, #15478 */
255node:unconnected:in-downloaded-area[entrance],
256node:unconnected:in-downloaded-area[traffic_calming],
257node:unconnected:in-downloaded-area[highway=passing_place],
258node:unconnected:in-downloaded-area[highway=mini_roundabout],
259node:unconnected:in-downloaded-area[highway=motorway_junction],
260node:unconnected:in-downloaded-area[highway=turning_loop],
261node:unconnected:in-downloaded-area[highway=turning_circle],
262node:unconnected:in-downloaded-area[highway=stop],
263node:unconnected:in-downloaded-area[highway=give_way],
264node:unconnected:in-downloaded-area[highway=traffic_signals],
265node:unconnected:in-downloaded-area[highway=crossing],
266node:unconnected:in-downloaded-area[crossing],
267node:unconnected:in-downloaded-area[highway=milestone],
268node:unconnected:in-downloaded-area[railway=milestone],
269node:unconnected:in-downloaded-area[railway=crossing],
270node:unconnected:in-downloaded-area[railway=level_crossing],
271node:unconnected:in-downloaded-area[railway=buffer_stop],
272node:unconnected:in-downloaded-area[public_transport=stop_position],
273node:unconnected:in-downloaded-area[aeroway=holding_position],
274node:unconnected:in-downloaded-area[noexit],
275node:unconnected:in-downloaded-area[waterway=dam],
276node:unconnected:in-downloaded-area[waterway=weir],
277node:unconnected:in-downloaded-area[waterway=waterfall],
278node:unconnected:in-downloaded-area[amenity=ferry_terminal],
279node:unconnected:in-downloaded-area[leisure=slipway],
280node:unconnected:in-downloaded-area[mountain_pass=yes],
281node:unconnected:in-downloaded-area[barrier=gate],
282node:unconnected:in-downloaded-area[barrier=lift_gate],
283node:unconnected:in-downloaded-area[barrier=swing_gate],
284node:unconnected:in-downloaded-area[barrier=toll_booth],
285node:unconnected:in-downloaded-area[barrier=turnstile],
286node:unconnected:in-downloaded-area[barrier=full-height_turnstile],
287node:unconnected:in-downloaded-area[barrier=motorcycle_barrier],
288node:unconnected:in-downloaded-area[barrier=rope],
289node:unconnected:in-downloaded-area[barrier=sally_port],
290node:unconnected:in-downloaded-area[barrier=spikes],
291node:unconnected:in-downloaded-area[barrier=stile],
292node:unconnected:in-downloaded-area[barrier=sump_buster],
293node:unconnected:in-downloaded-area[barrier=kerb],
294node:unconnected:in-downloaded-area[barrier=border_control],
295node:unconnected:in-downloaded-area[barrier=bump_gate],
296node:unconnected:in-downloaded-area[barrier=bus_trap],
297node:unconnected:in-downloaded-area[barrier=cattle_grid],
298node:unconnected:in-downloaded-area[barrier=chain],
299node:unconnected:in-downloaded-area[barrier=cycle_barrier],
300node:unconnected:in-downloaded-area[barrier=hampshire_gate],
301node:unconnected:in-downloaded-area[barrier=height_restrictor],
302node:unconnected:in-downloaded-area[barrier=debris] {
303 throwWarning: tr("{0}", "{2.tag}");
304 group: tr("isolated node which must be connected to a way");
305}
306
307/* #11127 */
308way[railway][bridge] > node,
309way[highway][bridge] > node {
310 set node_in_bridge;
311}
312way[waterway] > node.node_in_bridge {
313 throwWarning: tr("node connects waterway and bridge");
314}
315
316/* #11128, #14812, #15032 */
317way[highway] > node[tourism=information][information=guidepost] {
318 set guidepost;
319 throwOther: tr("{0} node connected to a highway", "{1.tag}");
320}
321way >[index=1] node,
322way >[index=-1] node {
323 set first_last_node;
324}
325way[highway] > node[amenity][!entrance][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking|bicycle_parking|bus_station|car_wash|ferry_terminal|weighbridge|taxi|toilets)$/],
326way[highway] > node[building][!entrance],
327way[highway] > node[leisure][!entrance][leisure!=slipway][leisure!=fitness_station],
328way[highway] > node[office][!entrance],
329way[highway][highway!=corridor] > node[shop][!entrance],
330way[highway] > node[tourism][!entrance][tourism!=viewpoint]!.guidepost.first_last_node:connection,
331way[highway] > node[tourism][!entrance][tourism!=viewpoint]!.guidepost!.first_last_node {
332 throwWarning: tr("{0} node connected to a highway", "{0.key}");
333}
334
335/* #18817 */
336way[man_made=pipeline][location=underground] > node[marker],
337way[power=cable ][location=underground] > node[marker] {
338 throwWarning: tr("{0} node connected to an underground object", "{0.key}");
339}
340
341way[junction=roundabout]:righthandtraffic:clockwise,
342way[junction=roundabout]!:righthandtraffic:anticlockwise {
343 throwWarning: tr("suspicious roundabout direction");
344}
345
346/* #12496 */
347area:closed[place=islet][eval(areasize()) > 1500000] {
348 throwWarning: tr("{0} on a large area", "{1.tag}");
349 suggestAlternative: "place=island";
350 fixAdd: "place=island";
351}
352
353area:closed[place=island][eval(areasize()) < 500000] {
354 throwWarning: tr("{0} on a small area", "{1.tag}");
355 suggestAlternative: "place=islet";
356 fixAdd: "place=islet";
357}
358
359/* #12561 - building larger than Aalsmeer Flower Auction (518000) and Tesla factory (510000) */
360area:closed[building][building!=no][eval(areasize()) > 520000] {
361 throwError: tr("Too large building");
362}
363
364/* #12646, #12992, #16334 */
365way[waterway=~/^(stream|river|drain)$/]!:closed >[index=-1] node[natural!=sinkhole][natural!=cave_entrance][waterway!=stream_end]!:connection:in-downloaded-area {
366 throwWarning: tr("Waterway ends without a connection to another waterway or the direction of the waterway is wrong.");
367}
368
369/* #10717, #14535 */
370way:closed[natural=coastline] area[natural=water],
371way:closed[natural=coastline] area[waterway=riverbank] {
372 throwError: tr("Coastline inside {1}", "{0.tag}");
373}
374
375/* #10471 */
376way[waterway] > node[ford?] { set ford_on_waterway; }
377way[highway] > node[ford?] { set ford_on_highway; }
378node[ford?]:in-downloaded-area!.ford_on_waterway, node[ford?]:in-downloaded-area!.ford_on_highway {
379 throwWarning: tr("{0} should be on the node where {1} and {2} intersect", "ford", "highway", "waterway");
380}
381
382/* #13877 */
383area:closed[waterway = canal][area!=no],
384area:closed[waterway = drain][area!=no],
385area:closed[waterway = ditch][area!=no],
386area:closed[waterway = stream][area!=no],
387area:closed[waterway = river][area!=no] {
388 throwWarning: tr("{0} is the tag for the linear waterway. To tag the water area use {1} + {2} instead.", "{1.tag}", "natural=water", "water=*");
389}
390
391/* #15097 */
392way[highway][area!=yes] > node,
393way[man_made=pier] > node {
394 set node_in_highway_pier;
395}
396way[route=ferry][tunnel=yes] > node,
397way[route=ferry][bridge=yes] > node {
398 set node_in_ferry_bridge_tunnel;
399}
400way[route=ferry]!:closed >[index= 1] node!.node_in_highway_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
401way[route=ferry]!:closed >[index=-1] node!.node_in_highway_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area {
402 throwWarning: tr("Ferry route is not connected to the road network or branches.");
403}
404way[amenity=ferry_terminal] > node,
405way[man_made=pier] > node {
406 set node_in_terminal_pier;
407}
408way[route=ferry]!:closed >[index= 1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
409way[route=ferry]!:closed >[index=-1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area {
410 throwWarning: tr("Ferry route is not connected to a ferry terminal or branches.");
411}
Note: See TracBrowser for help on using the repository browser.