source: josm/trunk/resources/data/validator/combinations.mapcss@ 16710

Last change on this file since 16710 was 16705, checked in by Klumbumbus, 4 years ago

fix #16898 - Warn about man_made=tower without tower:type and man_made=communications_tower with height<75m (patch by skyper, modified)

  • Property svn:eol-style set to native
File size: 35.8 KB
Line 
1/* Rules partially derived from Taginfo statistics - see ticket #5017
2 * Taginfo query: select keypairs.key1, keypairs.key2, keypairs.count_all, keys.count_all, cast(keypairs.count_all as real)/keys.count_all as from_fraction_all from keys, keypairs where key1='waterway' and keys.key=keypairs.key2 and (key1<>'highway' or keypairs.count_all>12000) and (key1<>'railway' or keypairs.count_all>3000) and (key1<>'waterway' or keypairs.count_all>800) and key2 not like '%:%' and from_fraction_all>0.97 and 1 union select keypairs.key2, keypairs.key1, keypairs.count_all, keys.count_all, cast(keypairs.count_all as real)/keys.count_all as from_fraction_all from keys, keypairs where key2='waterway' and keys.key=keypairs.key1 and (key2<>'highway' or keypairs.count_all>12000) and (key2<>'railway' or keypairs.count_all>3000) and (key2<>'waterway' or keypairs.count_all>800) and key1 not like '%:%' and from_fraction_all>0.97 and 1 order by keypairs.count_all desc limit 1000;
3 */
4
5way[surface=~/^(unpaved|compacted|gravel|fine_gravel|pebblestone|ground|earth|dirt|grass|sand|mud|ice|salt|snow|woodchips)$/] { /* without grass_paver as it is controversial */
6 set unpaved_surface;
7}
8
9/* {0.key} without {1.key} (warning level) */
10way[junction ][!highway][junction!=yes][!area:highway],
11way[lanes ][!highway][leisure!=track][leisure!=swimming_pool],
12way[living_street ][!highway],
13way[maintenance ][!highway],
14way[median ][!highway],
15way[motorroad ][!highway],
16node[ntd_id ][!highway],
17way[sac_scale ][!highway],
18way[sidewalk ][!highway],
19way[step_count ][!highway][man_made!=tower],
20way[tracktype ][!highway],
21way[trail_visibility ][!highway], /* #15029 */
22way[trolley_wire ][!highway],
23way[zip_left ][!highway],
24way[zip_right ][!highway],
25way[detail ][!railway][route!=railway],
26way[eddy_current_brake ][!railway][route!=railway],
27way[electrified ][!railway][route!=railway][!highway], /* #16007 */
28way[etcs ][!railway][route!=railway],
29way[gauge ][!railway][route!=railway],
30way[grade_of_track ][!railway][route!=railway],
31way[kursbuchstrecke ][!railway][route!=railway],
32way[lzb ][!railway][route!=railway],
33way[old_railway_operator ][!railway][route!=railway],
34way[operating_procedure ][!railway][route!=railway],
35way[pzb ][!railway][route!=railway],
36way[structure_gauge ][!railway][route!=railway],
37way[tilting_technology ][!railway][route!=railway],
38way[track_class ][!railway][route!=railway],
39way[tracks ][!railway][route!=railway],
40way[traffic_mode ][!railway][route!=railway],
41way[workrules ][!railway][route!=railway],
42way[length_unit ][!waterway],
43way[canal ][!waterway],
44way[have_riverbank ][!waterway],
45*[border_type ][!boundary],
46*[piste:difficulty ][!piste:type],
47*[place ][!name][place!=islet],
48*[transformer ][!power],
49*[source:date ][!source],
50*[source:name ][!name][noname!=yes],
51*[source:maxspeed:forward ][!maxspeed:forward][!maxspeed],
52*[source:maxspeed:backward ][!maxspeed:backward][!maxspeed],
53*[source:building ][!building],
54*[source:ref ][!ref][noref!=yes],
55*[source:population ][!population],
56*[source:postal_code ][!postal_code],
57*[source:ele ][!ele],
58*[source:ref:INSEE ][!ref:INSEE],
59*[source:lit ][!lit],
60*[source:hgv ][!hgv],
61*[source:highway ][!highway],
62*[source:maxaxleload ][!maxaxleload],
63*[source:surface ][!surface],
64*[source:bridge ][!bridge],
65*[source:old_name ][!old_name],
66*[source:bicycle ][!bicycle],
67*[source:designation ][!designation],
68*[source:height ][!height],
69*[source:lanes ][!lanes],
70*[source:postcode ][!addr:postcode],
71*[source:housenumber ][!addr:housenumber],
72*[source:addr:postcode ][!addr:postcode],
73*[source:addr:housenumber ][!addr:housenumber] {
74 throwWarning: tr("{0} without {1}", "{0.key}", "{1.key}");
75 group: tr("missing tag");
76 assertMatch: "way lanes=42";
77 assertNoMatch: "way lanes=42 highway=unclassified";
78 assertMatch: "node source:addr:postcode=postman";
79}
80
81/* {0.key} without {1.key} (info level) */
82way[lanes:forward][!lanes:backward][oneway!=yes][oneway!=-1],
83way[lanes:backward][!lanes:forward][oneway!=yes][oneway!=-1],
84*[leaf_type ][!leaf_cycle],
85*[leaf_cycle][!leaf_type] {
86 throwOther: tr("{0} without {1}", "{0.key}", "{1.key}");
87 group: tr("missing tag");
88}
89
90/* {0.key} without {1.tag}, #17997 */
91node[railway:switch ][railway!=switch],
92*[generator:source ][power!=generator],
93*[generator:method ][power!=generator],
94*[generator:type ][power!=generator],
95node[fire_hydrant:type ][emergency!=fire_hydrant][disused:emergency!=fire_hydrant],
96node[manhole ][man_made!=manhole],
97way[fence_type ][barrier!=fence],
98*[recycling_type ][amenity!=recycling],
99*[information ][tourism!=information],
100node[board_type ][information!=board],
101*[shelter_type ][amenity!=shelter],
102node[lamp_type ][highway!=street_lamp],
103node[map_type ][information!=map],
104*[site_type ][historic!=archaeological_site],
105*[artwork_type ][tourism!=artwork][exhibit!=artwork],
106*[castle_type ][historic!=castle],
107*[parking ][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking)$/][parking!=yes][parking!=no],
108way[cutline ][man_made!=cutline],
109*[bunker_type ][military!=bunker] {
110 throwWarning: tr("{0} without {1}", "{0.key}", "{1.tag}");
111 group: tr("missing tag");
112}
113
114/* {0.key} without {1.tag} or {2.tag}, #15107 */
115*[iata ][aeroway!=aerodrome][aeroway!=helipad],
116*[icao ][aeroway!=aerodrome][aeroway!=helipad],
117*[bridge:movable ][bridge!=movable][man_made!=bridge],
118*[substation ][power!=substation][pipeline!=substation],
119*[reservoir_type ][landuse!=reservoir][water!=reservoir],
120way[waterway=pressurised ][tunnel!=flooded][man_made!=pipeline] {
121 throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.tag}", "{2.tag}");
122 group: tr("missing tag");
123}
124
125/* {0.tag} without {1.key} (warning level), #18411, #18246 */
126way[railway=construction][!construction],
127way[highway=construction][!construction],
128node[traffic_sign=maxspeed][!maxspeed],
129node[actuator=manual][!handle],
130node[emergency=fire_hydrant][!fire_hydrant:type],
131way[ boundary=administrative][!admin_level],
132relation[boundary=administrative][!admin_level],
133relation[route=bicycle ][!network][type=route],
134relation[route=hiking ][!network][type=route],
135relation[route=foot ][!network][type=route],
136relation[route=horse ][!network][type=route],
137relation[route=piste][!piste:type][type=route],
138relation[route=ski ][!piste:type][type=route],
139*[tourism=information][!information],
140*[leisure=pitch][!sport],
141*[aeroway=terminal][!building],
142*[office=government][!government],
143*[power=generator][!generator:source],
144*[amenity=social_facility][!social_facility],
145*[amenity=place_of_worship][!religion],
146*[man_made=tower][!tower:type] {
147 throwWarning: tr("{0} without {1}", "{0.tag}", "{1.key}");
148 group: tr("missing tag");
149}
150
151/* {0.tag} without {1.key} (info level), #15107 */
152*[aeroway=runway ][!ref],
153*[aeroway=runway ][!surface],
154node[highway=crossing ][!crossing],
155way[highway=track ][!tracktype],
156way[power=cable ][!location],
157node[power=transformer ][!voltage:primary],
158node[power=transformer ][!voltage:secondary],
159node[transformer=distribution ][!voltage:primary][power=pole],
160node[transformer=distribution ][!voltage:secondary][power=pole],
161way[power=line ][!voltage],
162way[power=minor_line ][!voltage],
163way[power=cable ][!voltage],
164*[power=generator ][!voltage][generator:output:electricity],
165*[power=plant ][!voltage][plant:output:electricity],
166*[power=substation ][!substation],
167*[power=switch ][!switch],
168*[power=transformer ][!transformer],
169*[amenity=bank ][!operator],
170*[amenity=cinema ][!operator],
171*[amenity=fast_food ][!operator],
172*[amenity=fuel ][!operator],
173*[mountain_pass=yes ][!ele],
174*[natural=peak ][!ele],
175*[natural=water ][!water],
176*[amenity=place_of_worship ][!denomination],
177*[amenity=parking ][!parking],
178*[amenity=parking_entrance ][!parking] {
179 throwOther: tr("{0} without {1}", "{0.tag}", "{1.key}");
180 group: tr("missing tag");
181 assertMatch: "way power=line";
182 assertNoMatch: "way power=line voltage=1";
183 assertMatch: "way power=switch";
184 assertMatch: "way power=substation";
185 assertMatch: "way power=substation transformer=foobar";
186 assertNoMatch: "way power=substation substation=foobar";
187 assertMatch: "way power=generator generator:output:electricity=yes";
188 assertNoMatch: "way power=generator";
189 assertNoMatch: "way power=generator generator:output:electricity=yes voltage=1";
190}
191
192/* {0.key} without {1.key} or {2.tag} */
193way[bridge:structure ][!bridge][man_made!=bridge],
194*[smoothness ][!highway][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking|bicycle_parking)$/],
195*[segregated ][!highway][railway!=crossing] {
196 throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.tag}");
197 group: tr("missing tag");
198}
199
200/* {0.tag} without {1.tag} (info level) see #11600 #11393 #11850 */
201way[highway=motorway][!oneway][junction!=roundabout],
202way[highway=motorway_link][!oneway][junction!=roundabout] {
203 throwOther: tr("{0} without {1}", "{0.tag}", "{1.tag}");
204 group: tr("missing tag");
205}
206
207/* {0.tag} without {1.tag} */
208way[usage=penstock][man_made!=pipeline],
209way[usage=penstock][waterway!=pressurised] {
210 throwWarning: tr("{0} without {1}", "{0.tag}", "{1.tag}");
211 group: tr("missing tag");
212}
213
214/* {0.tag} without {1.tag} or {2.tag} */
215*[amenity=recycling][recycling_type!=container][recycling_type!=centre] {
216 throwWarning: tr("{0} without {1} or {2}", "{0.tag}", "{1.tag}", "{2.tag}");
217 group: tr("missing tag");
218}
219
220/* {0.key} without {1.key}, {2.tag} or {3.tag} */
221*[intermittent ][!waterway][natural!~/^(water|spring)$/][landuse!~/^(basin|reservoir)$/][ford!=yes],
222*[boat ][!waterway][natural!=water ][landuse!~/^(basin|reservoir)$/][ford!=yes] {
223 throwWarning: tr("{0} without {1}, {2}, {3} or {4}", "{0.key}", "{1.key}", "{2.tag}", "{3.tag}", "{4.tag}");
224 group: tr("missing tag");
225}
226
227/* {0.key} without {1.key}, {2.key} or {3.key}, #17253 */
228way[oneway ][!highway][!railway][!aerialway][attraction!=summer_toboggan][aeroway!~/^(runway|taxiway)$/],
229*[snowplowing][!highway][!amenity][!leisure] {
230 throwWarning: tr("{0} without {1}, {2} or {3}", "{0.key}", "{1.key}", "{2.key}", "{3.key}");
231 group: tr("missing tag");
232}
233
234/* {0.key} without {1.key}, {2.key} or {3.tag}, #17255 */
235way[incline ][!highway][!railway][aeroway!~/^(runway|taxiway)$/][attraction!=summer_toboggan],
236*[toll ][!highway][!barrier][route!~/^(ferry|road)$/] {
237 throwWarning: tr("{0} without {1}, {2} or {3}", "{0.key}", "{1.key}", "{2.key}", "{3.tag}");
238 group: tr("missing tag");
239}
240
241/* {0.tag} together with {1.key}, see #17664, #17707, #16464, #10837, #14034, #9389, #11977, #13156, #16888 */
242*[power=plant][/^generator:/],
243*[power=generator][/^plant:/],
244*[power=plant][voltage],
245*[power=plant][frequency],
246*[internet_access=no][internet_access:fee],
247node[power=transformer][voltage],
248node[transformer=distribution][voltage][power=pole],
249*[amenity=vending_machine][shop],
250*[noname?][name],
251way[oneway=yes][/:backward/][!traffic_sign:backward][bicycle:backward!=use_sidepath][oneway:bicycle!=no][oneway:psv!=no],
252way[oneway=yes][/:forward/ ][!traffic_sign:forward ][bicycle:forward!=use_sidepath ][oneway:bicycle!=no][oneway:psv!=no],
253way[oneway=-1 ][/:backward/][!traffic_sign:backward][bicycle:backward!=use_sidepath][oneway:bicycle!=no][oneway:psv!=no],
254way[oneway=-1 ][/:forward/ ][!traffic_sign:forward ][bicycle:forward!=use_sidepath ][oneway:bicycle!=no][oneway:psv!=no] {
255 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.key}");
256 group: tr("suspicious tag combination");
257 assertMatch: "way power=plant generator:source=wind";
258 assertMatch: "way power=generator plant:source=combustion";
259}
260
261/* {0.tag} together with {1.tag} (info level), see #9696 */
262way[highway=footway][oneway=no] {
263 throwOther: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
264 group: tr("suspicious tag combination");
265}
266
267/* {0.tag} together with {1.tag}, see #18411, #17950, #17330, #17623, #17592, #17594, #17542, #16861, #16147, #10186 */
268*[barrier=kerb][kerb=no],
269way[highway=construction][construction=yes],
270way[railway=construction][construction=yes],
271*[man_made=bridge][bridge=yes],
272*[man_made=tunnel][tunnel=yes],
273*[amenity=police][police],
274node[highway=crossing][crossing=no],
275node[railway=crossing][crossing=no],
276way[junction=yes][highway],
277way[tracktype=grade1][surface].unpaved_surface,
278way[tracktype=grade2][surface][surface=~/^(sand|mud)$/],
279way[segregated][bicycle=no],
280way[segregated][foot=no],
281way[man_made=pipeline][tunnel=flooded],
282way[waterway=canal][tunnel=yes] {
283 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
284 group: tr("suspicious tag combination");
285}
286
287/* {0.tag} together with {1.tag} (error level) */
288relation[type=multipolygon][area=no] {
289 throwError: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
290 group: tr("suspicious tag combination");
291}
292
293/* {0.key} together with {1.key}, #18267, #17630, #17604 */
294node[marker][cover],
295node[marker][voltage],
296node[marker][pressure],
297node[marker][diameter],
298node[marker][substance],
299*[building:part][building],
300*[addr:street][addr:place][outside("CZ,DK")] {
301 throwWarning: tr("{0} together with {1}", "{0.key}", "{1.key}");
302 group: tr("suspicious tag combination");
303}
304
305/* {0.tag} together with {1.tag} and {2.key}, #18471 */
306way[highway=~/^(cycleway|footway|path)$/][segregated=no][sidewalk =~/^(left|right|both)$/] {
307 throwWarning: tr("{0} together with {1} and {2}", "{0.tag}", "{1.tag}", "{2.key}");
308 group: tr("suspicious tag combination");
309}
310
311/* #11127, #13727 */
312way[waterway][bridge=yes][waterway!=weir] {
313 throwWarning: tr("{0} together with {1}", "{0.key}", "{1.tag}");
314 suggestAlternative: "bridge=aqueduct";
315 group: tr("suspicious tag combination");
316 fixAdd: "bridge=aqueduct";
317}
318way[waterway=weir][bridge=yes][highway] {
319 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
320 suggestAlternative: "waterway=weir + ford=yes";
321 suggestAlternative: "waterway=dam";
322 suggestAlternative: tr("two objects, one with {0} and one with {1} + {2} + {3}", "{0.tag}", "{2.key}", "{1.tag}", "layer");
323 group: tr("suspicious tag combination");
324}
325
326/* #16214 */
327relation[type=multipolygon] >[role="inner"] way[area][eval(number_of_tags()) = 1] {
328 throwWarning: tr("{0} on an inner multipolygon ring without further tags", "{0.tag}");
329 fixRemove: "area";
330 set area_yes_autofix;
331 group: tr("suspicious tag combination");
332}
333
334/* only {0.key}, see #11104 #12422 #14950 */
335*[access][eval(number_of_tags()) = 1],
336*[area][eval(number_of_tags()) = 1]!.area_yes_autofix,
337*[name][eval(number_of_tags()) = 1],
338*[ref][eval(number_of_tags()) = 1],
339*[lit][eval(number_of_tags()) = 1] {
340 throwWarning: tr("incomplete object: only {0}", "{0.key}");
341 group: tr("missing tag");
342}
343/* only {0.key} and {1.key} */
344*[name][area][eval(number_of_tags()) = 2],
345*[name][ref][eval(number_of_tags()) = 2] {
346 throwWarning: tr("incomplete object: only {0} and {1}", "{0.key}", "{1.key}");
347 group: tr("missing tag");
348}
349/* only {0.tag}, #15269 */
350*[tourism=attraction][eval(number_of_tags()) = 1] {
351 throwWarning: tr("incomplete object: only {0}", "{0.tag}");
352 group: tr("missing tag");
353}
354/* only {0.key} and {1.tag} */
355*[name][tourism=attraction][eval(number_of_tags()) = 2] {
356 throwWarning: tr("incomplete object: only {0} and {1}", "{0.key}", "{1.tag}");
357 group: tr("missing tag");
358}
359
360/* #9811, #11491, #12865, #14310 */
361*[place][place!=farm][/^(addr:housenumber|addr:housename|addr:flats|addr:conscriptionnumber|addr:street|addr:place|addr:city|addr:country|addr:full|addr:hamlet|addr:suburb|addr:subdistrict|addr:district|addr:province|addr:state|addr:interpolation|addr:interpolation|addr:inclusion)$/],
362/* addr:postcode is used together with place in some countries */
363*[boundary][/^addr:/],
364*[highway][/^addr:/][highway!=services][highway!=rest_area][!"addr:postcode"] {
365 throwWarning: tr("{0} together with {1}", "{0.key}", "addr:*");
366 group: tr("suspicious tag combination");
367 assertMatch: "node place=foo addr:housenumber=5";
368 assertMatch: "node place=foo addr:housenumber=5 addr:postcode=12345";
369 assertNoMatch: "node place=foo addr:postcode=12345";
370}
371*[!highway][postal_code]["addr:postcode"][postal_code=*"addr:postcode"] {
372 throwWarning: tr("{0} together with {1}", "{1.key}", "{2.key}");
373 group: tr("suspicious tag combination");
374}
375*[!highway][postal_code]["addr:postcode"][postal_code!=*"addr:postcode"] {
376 throwWarning: tr("{0} together with {1} and conflicting values", "{1.key}", "{2.key}");
377 group: tr("suspicious tag combination");
378}
379way[highway][postal_code]["addr:postcode"][postal_code=*"addr:postcode"] {
380 throwWarning: tr("{0} together with {1}", "{1.key}", "{2.key}");
381 group: tr("suspicious tag combination");
382 fixRemove: "addr:postcode";
383}
384way[highway][postal_code]["addr:postcode"][postal_code!=*"addr:postcode"] {
385 throwWarning: tr("{0} together with {1} and conflicting values", "{1.key}", "{2.key}");
386 group: tr("suspicious tag combination");
387}
388way[highway][highway!=services][highway!=rest_area][!postal_code]["addr:postcode"] {
389 throwWarning: tr("{0} together with {1}", "{0.key}", "{4.key}");
390 suggestAlternative: "postal_code";
391 group: tr("suspicious tag combination");
392 fixChangeKey: "addr:postcode=>postal_code";
393}
394
395/* #9195 */
396way[highway=footway][cycleway=lane] {
397 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
398 suggestAlternative: "highway=path + foot=designated + bicycle=designated + segregated=yes";
399 group: tr("suspicious tag combination");
400}
401
402/* {0} on suspicious object */
403*[tunnel ][!highway][!railway][!waterway][!piste:type][public_transport!=platform][route!=ferry][man_made!=pipeline][man_made!=goods_conveyor][man_made!=wildlife_crossing][man_made!=tunnel],
404*[bridge ][!highway][!railway][!waterway][!piste:type][public_transport!=platform][route!=ferry][man_made!=pipeline][man_made!=goods_conveyor][man_made!=wildlife_crossing][man_made!=bridge][building!=bridge],
405*[psv ][!highway][!railway][!waterway][barrier!=bollard][amenity !~ /^parking.*/],
406*[width ][!highway][!railway][!waterway][!aeroway][!cycleway][!footway][!barrier][!man_made][!entrance][natural!=stone][leisure!=track],
407*[maxspeed][!highway][!railway][traffic_sign !~ /^((.*;)?maxspeed(;.*)?|[A-Z][A-Z]:.+)$/][traffic_sign:forward !~ /^((.*;)?maxspeed(;.*)?|[A-Z][A-Z]:.+)$/][traffic_sign:backward !~ /^((.*;)?maxspeed(;.*)?|[A-Z][A-Z]:.+)$/][type != enforcement][waterway !~ /^(river|canal|lock)$/][!traffic_calming][aerialway!=zip_line] {
408 throwWarning: tr("{0} on suspicious object", "{0.key}");
409 group: tr("suspicious tag combination");
410}
411
412*[amenity][amenity =~ /^(restaurant|cafe|fast_food|pub|place_of_worship|school|university|hospital|library|theatre|courthouse|bank|cinema|pharmacy|fuel)$/][!name][noname!=yes] {
413 throwOther: tr("{0} without {1}", "{0.tag}", "{2.key}");
414 group: tr("missing tag");
415 assertMatch: "node amenity=restaurant";
416 assertNoMatch: "node amenity=restaurant noname=yes";
417 assertNoMatch: "node amenity=restaurant name=Foobar";
418}
419
420/* #10193, #16157 */
421way[highway][barrier],
422*[highway][waterway][waterway!=dam][waterway!=weir],
423way[highway][natural][natural!=ridge],
424*[landuse][building][landuse!=retail] {
425 throwWarning: tr("{0} together with {1}", "{0.key}", "{1.key}");
426 group: tr("suspicious tag combination");
427 assertNoMatch: "node highway=street_lamp natural=birds_nest";
428}
429
430/* #6932 */
431*[natural=water][leisure=swimming_pool] {
432 throwWarning: tr("natural water used for swimming pool");
433 group: tr("suspicious tag combination");
434 fixRemove: "natural";
435}
436
437/* #9593, #11183, #12418, #12761, #17254, #19311 */
438*[sport][sport!=skiing][!building][!club][tourism != hotel][highway != raceway][!leisure][natural !~ /^(beach|bare_rock|cliff|peak|water)$/][amenity !~ /^(dojo|pub|restaurant|swimming_pool)$/][landuse !~ /^(recreation_ground|piste|farm|farmland)$/][barrier !~ /^(wall|retaining_wall)$/][!"piste:type"][shop!=sports][attraction!=summer_toboggan] {
439 throwWarning: tr("sport without physical feature");
440 group: tr("missing tag");
441 assertMatch: "node sport=tennis";
442 assertNoMatch: "node sport=tennis leisure=pitch";
443 assertNoMatch: "node sport=beachvolleyball natural=beach";
444 assertNoMatch: "node sport=skiing"; /* skiing has deprecated warning */
445 assertNoMatch: "node sport=swimming tourism=hotel";
446 assertNoMatch: "node sport=10pin amenity=restaurant";
447}
448
449/* {0.key} without {1.key} or {2.key} see #10140 */
450*[building:levels][!building][!building:part],
451way[usage][!railway][!waterway][route!=railway][man_made!=pipeline] {
452 throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.key}");
453 group: tr("missing tag");
454}
455
456/* any other *_name tag (with some exceptions) but not a name , see #10837 #11297 #11539 #16437 */
457*[/_name$/][!name][!old_name][!loc_name][!uic_name][!artist_name][!lock_name][!"osak:municipality_name"][!"osak:street_name"][noname!=yes] {
458 throwWarning: tr("alternative name without {0}", "{1.key}");
459 group: tr("missing tag");
460}
461
462/* #10837 */
463way[destination][!oneway?][junction!=roundabout][highway] {
464 throwWarning: tr("incomplete usage of {0} on a way without {1}", "{0.key}", "{1.key}");
465 suggestAlternative: "destination:forward";
466 suggestAlternative: "destination:backward";
467}
468
469/* #11389, #19010 */
470way["maxspeed:forward"=*"maxspeed:backward"][!maxspeed] {
471 throwWarning: tr("Same value of {0} and {1}", "{0.key}", "{1.key}");
472 suggestAlternative: "maxspeed";
473 group: tr("suspicious tag combination");
474 fixChangeKey: "maxspeed:forward=>maxspeed";
475 fixRemove: "maxspeed:backward";
476}
477way["maxspeed:forward"=*maxspeed]["maxspeed:backward"=*maxspeed][maxspeed] {
478 throwWarning: tr("Same value of {0}, {1} and {2}", "{0.key}", "{1.key}", "{2.key}");
479 set AllSameMaxspeed;
480 suggestAlternative: "maxspeed";
481 group: tr("suspicious tag combination");
482 fixRemove: "maxspeed:forward";
483 fixRemove: "maxspeed:backward";
484}
485way["cycleway:left"=*"cycleway:right"][!cycleway] {
486 throwWarning: tr("Same value of {0} and {1}", "{0.key}", "{1.key}");
487 suggestAlternative: "cycleway";
488 group: tr("suspicious tag combination");
489 fixChangeKey: "cycleway:left=>cycleway";
490 fixRemove: "cycleway:right";
491}
492way["cycleway:left"=*cycleway]["cycleway:right"=*cycleway][cycleway] {
493 throwWarning: tr("Same value of {0}, {1} and {2}", "{0.key}", "{1.key}", "{2.key}");
494 set AllSameCycleway;
495 suggestAlternative: "cycleway";
496 group: tr("suspicious tag combination");
497 fixRemove: "cycleway:left";
498 fixRemove: "cycleway:right";
499}
500way["sidewalk:left"=*"sidewalk:right"][!sidewalk] {
501 throwWarning: tr("Same value of {0} and {1}", "{0.key}", "{1.key}");
502 suggestAlternative: "sidewalk";
503 group: tr("suspicious tag combination");
504 fixChangeKey: "sidewalk:left=>sidewalk";
505 fixRemove: "sidewalk:right";
506}
507way["sidewalk:left"=*sidewalk]["sidewalk:right"=*sidewalk][sidewalk] {
508 throwWarning: tr("Same value of {0}, {1} and {2}", "{0.key}", "{1.key}", "{2.key}");
509 set AllSameSidewalk;
510 suggestAlternative: "sidewalk";
511 group: tr("suspicious tag combination");
512 fixRemove: "sidewalk:left";
513 fixRemove: "sidewalk:right";
514}
515way["maxspeed:forward"]["maxspeed:backward"][maxspeed]!.AllSameMaxspeed,
516way["cycleway:left"]["cycleway:right"][cycleway]!.AllSameCycleway,
517way["sidewalk:left"]["sidewalk:right"][sidewalk]!.AllSameSidewalk {
518 throwWarning: tr("{0} and {1} together with {2} and conflicting values", "{0.key}", "{1.key}", "{2.key}");
519 group: tr("suspicious tag combination");
520}
521way["maxspeed:forward"][maxspeed][!"maxspeed:backward"],
522way["maxspeed:backward"][maxspeed][!"maxspeed:forward"],
523way["cycleway:left"][cycleway][!"cycleway:right"],
524way["cycleway:right"][cycleway][!"cycleway:left"],
525way["sidewalk:left"][sidewalk][!"sidewalk:right"],
526way["sidewalk:right"][sidewalk][!"sidewalk:left"] {
527 throwWarning: tr("{0} together with {1}", "{0.key}", "{1.key}");
528 group: tr("suspicious tag combination");
529}
530
531/* #11837 */
532way[layer][layer<0][bridge][bridge!=no][location!=underground][indoor!=yes][!tunnel],
533way[layer][layer>0][tunnel][tunnel!=no][location!=overground][indoor!=yes][!bridge] {
534 throwWarning: tr("{0} together with {1}", "{2.tag}", "{0.tag}");
535 group: tr("suspicious tag combination");
536}
537
538/* #12942 */
539relation[oneway][type!=route] {
540 throwWarning: tr("{0} on a relation without {1}", "{0.key}", "{1.tag}");
541}
542
543/* #9182 */
544way[waterway][layer][layer=~/^(-1|-2|-3|-4|-5)$/][!tunnel][culvert!=yes][covered!=yes][pipeline!=yes][location!=underground][eval(waylength()) > 400] {
545 throwWarning: tr("Long waterway with {0} but without a tag which defines it as tunnel or underground. Remove {1} or add a tunnel tag if applicable. Also check crossing bridges and their {1} tags.", "{1.tag}", "{1.key}");
546 group: tr("suspicious tag combination");
547}
548way[waterway][layer][layer=~/^(-1|-2|-3|-4|-5)$/][!tunnel][culvert!=yes][covered!=yes][pipeline!=yes][location!=underground][eval(waylength()) <= 400] {
549 throwOther: tr("Short waterway with {0} but without a tag which defines it as tunnel or underground. Remove {1} or add a tunnel tag if applicable. Also check crossing bridges and their {1} tags.", "{1.tag}", "{1.key}");
550 group: tr("suspicious tag combination");
551}
552
553/* #13144, #15536 */
554*[unisex=yes][female=yes][male!=yes][shop=hairdresser],
555*[unisex=yes][male=yes][female!=yes][shop=hairdresser] {
556 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
557 group: tr("suspicious tag combination");
558}
559*[unisex=yes][female=yes][male=yes][shop=hairdresser] {
560 throwWarning: tr("{0} together with {1} and {2}. Remove {1} and {2}", "{0.tag}", "{1.tag}", "{2.tag}");
561 group: tr("suspicious tag combination");
562 fixRemove: "female";
563 fixRemove: "male";
564}
565*[female=yes][male=yes][!unisex][shop=hairdresser] {
566 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
567 suggestAlternative: "unisex=yes";
568 group: tr("suspicious tag combination");
569 fixRemove: "female";
570 fixRemove: "male";
571 fixAdd: "unisex=yes";
572}
573
574/* {1.key} without {2.tag} see #13138, #14468 */
575way!:closed[water][natural!~/water|bay|strait/][water!=intermittent][amenity!=lavoir], /* water=intermittent is deprecated and has an own warning */
576area:closed[water][natural!~/water|bay|strait/][water!=intermittent][amenity!=lavoir] {
577 throwWarning: tr("{0} without {1}", "{1.key}", "{2.tag}");
578 group: tr("missing tag");
579}
580
581/* see #8519, #11529, limited to motorways and trunks to avoid false positives for streets with lanes for non motorized traffic */
582way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][turn:lanes ][tag(lanes)!=eval(count(split("|", tag("turn:lanes"))))],
583way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][change:lanes ][tag(lanes)!=eval(count(split("|", tag("change:lanes"))))],
584way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][maxspeed:lanes ][tag(lanes)!=eval(count(split("|", tag("maxspeed:lanes"))))],
585way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][minspeed:lanes ][tag(lanes)!=eval(count(split("|", tag("minspeed:lanes"))))],
586way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][destination:lanes ][tag(lanes)!=eval(count(split("|", tag("destination:lanes"))))],
587way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][destination:ref:lanes ][tag(lanes)!=eval(count(split("|", tag("destination:ref:lanes"))))],
588way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][destination:symbol:lanes][tag(lanes)!=eval(count(split("|", tag("destination:symbol:lanes"))))] {
589 throwWarning: tr("Different number of lanes in the keys {0} and {1}", "{1.key}", "{2.key}");
590 group: tr("suspicious tag combination");
591}
592
593/* #13680 */
594area[golf=bunker][natural=beach] {
595 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
596 suggestAlternative: "natural=sand";
597 suggestAlternative: "surface=sand";
598 group: tr("suspicious tag combination");
599}
600
601/* #13705 */
602relation[type=multipolygon][building] > way {
603 set part_of_building_MP;
604}
605way["addr:housenumber"][!building][!"building:part"][!"demolished:building"][!note][!amenity][!leisure][!landuse][!man_made][!tourism][!barrier]!.part_of_building_MP {
606 /* don't exclude shop because a lot of real missing bulding tag cases have a shop tag. */
607 throwOther: tr("possibly missing {0} tag", "{1.key}");
608 group: tr("missing tag");
609}
610
611/* #14125, #14323, #18185 */
612way[highway][lanes][!lanes:forward][!lanes:backward][oneway!=yes][oneway!=-1][oneway!=reversible][junction!=roundabout][lanes>2][get(split(".", tag(lanes)/2), 1)=5] {
613 throwWarning: tr("street with odd number of {0}, but without {1} and {2} or {3}", "{1.key}", "{2.key}", "{3.key}", "{4.key}");
614 group: tr("missing tag");
615 assertNoMatch: "way highway=primary lanes=2";
616 assertNoMatch: "way highway=primary lanes=3 lanes:backward=2";
617 assertNoMatch: "way highway=primary lanes=3 oneway=-1";
618 assertNoMatch: "way highway=primary lanes=4";
619 assertMatch: "way highway=primary lanes=3";
620}
621
622/* #15774 */
623node[emergency=fire_hydrant][fire_hydrant:count][fire_hydrant:count!=1] {
624 throwOther: tr("{0} together with {1}. Tag each hydrant separately.", "{0.tag}", "{1.tag}");
625}
626
627/* #12502 */
628node[leisure=park][natural=tree] {
629 throwWarning: tr("{0} together with {1} on a node. Remove {0}.", "{0.tag}", "{1.tag}");
630 group: tr("suspicious tag combination");
631 fixRemove: "leisure";
632}
633
634/* #17305 */
635area[boundary=administrative][landuse=residential] {
636 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
637 group: tr("suspicious tag combination");
638}
639
640/* #17391 */
641way[highway=pedestrian][width][width<3] {
642 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
643 suggestAlternative: "highway=footway";
644 group: tr("suspicious tag combination");
645 fixAdd: "highway=footway";
646 assertMatch: "way highway=pedestrian width=0.8";
647 assertMatch: "way highway=pedestrian width=1";
648 assertNoMatch: "way highway=pedestrian width=3";
649 assertNoMatch: "way highway=pedestrian width=5.5";
650}
651
652/* see #17623 */
653way:areaStyle[highway][highway =~ /motorway|trunk|primary|secondary|tertiary|unclassified|residential|service$|living_street|pedestrian|track|path|footway|cycleway|bus_guideway|bridleway/][area!=yes] {
654 throwOther: tr("A linear object {0} without {1} has a tag indicating that it is an area.", "{1.tag}", "{3.tag}");
655 group: tr("suspicious tag combination");
656}
657
658/* #17804 */
659area[cemetery=sector][landuse=cemetery] {
660 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
661 group: tr("suspicious tag combination");
662}
663
664/* #17967 */
665*[highway=cycleway][cycleway=track] {
666 throwWarning: tr("{0} together with {1}. Remove {1}.", "{0.tag}", "{1.tag}");
667 group: tr("suspicious tag combination");
668 fixRemove: "cycleway";
669}
670
671/* #17973, #18183, #18331 */
672way[highway=path ][foot][foot!=no ][foot!=use_sidepath ][!segregated][bicycle][bicycle!=no][bicycle!=use_sidepath][bicycle!=dismount]!.unpaved_surface,
673way[highway=footway ][bicycle][bicycle!=no][bicycle!=use_sidepath][!segregated][bicycle!=dismount]!.unpaved_surface,
674way[highway=cycleway][foot][foot!=no ][foot!=use_sidepath ][!segregated]!.unpaved_surface {
675 throwWarning: tr("Combined foot- and cycleway without {0}.", "{4.key}");
676 group: tr("missing tag");
677}
678
679/* #17989 */
680node[emergency_ward_entrance][emergency!=emergency_ward_entrance] {
681 throwWarning: tr("{0} without {1}", "{0.tag}", "{1.tag}");
682 group: tr("missing tag");
683 fixAdd: "emergency=emergency_ward_entrance";
684}
685
686/* #18203 */
687way[construction][construction!=yes][construction!=minor][highway][highway!=construction] {
688 throwWarning: tr("{0} together with {1}", "{3.tag}", "{0.tag}");
689 group: tr("suspicious tag combination");
690}
691
692/* #18374 */
693*[amenity=recycling][collection_times="24/7"][!opening_hours],
694*[amenity=recycling][collection_times ][!opening_hours][collection_times=~/[a-z]-[A-Z].*[0-9]-[0-9]/] {
695 throwWarning: tr("{0} together with {1}. Probably {2} is meant.", "{1.key}", "{0.tag}", "{2.key}");
696 group: tr("suspicious tag combination");
697 fixChangeKey: "collection_times => opening_hours";
698 assertMatch: "node amenity=recycling collection_times=\"Mo-Fr 06:00-20:00\"";
699 assertNoMatch: "node amenity=recycling collection_times=\"Mo-Fr 15:00\"";
700 assertNoMatch: "node amenity=recycling collection_times=\"Mo 08:00-11:00\"";
701 assertNoMatch: "node amenity=recycling collection_times=\"Sa[2,4] 8:00-11:00\"";
702}
703*[amenity=recycling][collection_times="24/7"][opening_hours],
704*[amenity=recycling][collection_times ][opening_hours][collection_times=~/[a-z]-[A-Z].*[0-9]-[0-9]/] {
705 throwWarning: tr("{0} together with {1}. Probably {2} is meant.", "{1.key}", "{0.tag}", "{2.key}");
706 group: tr("suspicious tag combination");
707}
708
709/* #19018 */
710way[highway][crossing][highway =~ /^(motorway|motorway_link|trunk|trunk_link|primary|primary_link|secondary|secondary_link|tertiary|tertiary_link|unclassified|residential|service|living_street)$/] {
711 throwWarning: tr("{0} together with {1}. Should be used on a minor highway type or a node", "{1.key}", "{0.tag}");
712 group: tr("suspicious tag combination");
713 fixRemove: "crossing";
714 assertMatch: "way highway=trunk crossing=unmarked";
715 assertNoMatch: "way highway=construction construction=footway crossing=unmarked";
716}
717
718/* #19066 */
719*[amenity=recycling][!/^recycling:/][recycling_type!=centre] {
720 throwWarning: tr("{0} without {1}", "{0.tag}", "recycling:*");
721 group: tr("missing tag");
722}
723*[source:addr][!/^addr:/] {
724 throwWarning: tr("{0} without {1}", "{0.key}", "addr:*");
725 group: tr("missing tag");
726 assertMatch: "node source:addr=postman";
727 assertNoMatch: "node source:addr=postman addr:housenumber=42";
728}
729*[source:maxspeed][!/^maxspeed:?/] {
730 throwWarning: tr("{0} without {1} or {2}", "{0.key}", "maxspeed", "maxspeed:*");
731 group: tr("missing tag");
732}
733
734/* #16898, tower vs. communications_tower, wiki suggests 100m as rough guideline, so we warn for < 75m */
735*[man_made=communications_tower][height][height =~ /^((7[0-4]|[1-6]?[0-9])(\.[0-9]*)?( m)?|(2(4[0-5]|[0-3][0-9])|1?[0-9]?[0-9])((\.[0-9]*)?( ft|\')|\'(11|10|[0-9])(\.[0-9]*)?\"))$/] { /* 75m ~ 246ft ~ 246' */
736 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
737 suggestAlternative: "man_made=tower + tower:type=communication + height";
738 group: tr("suspicious tag combination");
739 assertMatch: "node man_made=communications_tower height=58";
740 assertMatch: "node man_made=communications_tower height=\"74 m\"";
741 assertMatch: "node man_made=communications_tower height=0.8";
742 assertMatch: "node man_made=communications_tower height=245'";
743 assertMatch: "node man_made=communications_tower height=\"224.22 ft\"";
744 assertMatch: "node man_made=communications_tower height=231'10.22\"";
745 assertNoMatch: "node man_made=communications_tower height=\"75 m\"";
746 assertNoMatch: "node man_made=communications_tower height=75.72";
747 assertNoMatch: "node man_made=communications_tower height=\"328.22 ft\"";
748 assertNoMatch: "node man_made=communications_tower height=4358'8\"";
749 assertNoMatch: "node height=4358'";
750}
Note: See TracBrowser for help on using the repository browser.