source: josm/trunk/data/validator/combinations.mapcss@ 8701

Last change on this file since 8701 was 8700, checked in by Klumbumbus, 9 years ago

fix #11389 - Add validator tests for combinations of maxspeed, maxspeed:forward and maxspeed:backward; enhance numerical test to forward and backward versions and remove "*=unknown" from whitelist of this numerical test
  • Property svn:eol-style set to native
File size: 13.9 KB
Line 
1/* Rules partially derived from Taginfo statistics - see ticket #5017
2 * Taginfo query: select keypairs.key1, keypairs.key2, keypairs.count_all, keys.count_all, cast(keypairs.count_all as real)/keys.count_all as from_fraction_all from keys, keypairs where key1='waterway' and keys.key=keypairs.key2 and (key1<>'highway' or keypairs.count_all>12000) and (key1<>'railway' or keypairs.count_all>3000) and (key1<>'waterway' or keypairs.count_all>800) and key2 not like '%:%' and from_fraction_all>0.97 and 1 union select keypairs.key2, keypairs.key1, keypairs.count_all, keys.count_all, cast(keypairs.count_all as real)/keys.count_all as from_fraction_all from keys, keypairs where key2='waterway' and keys.key=keypairs.key1 and (key2<>'highway' or keypairs.count_all>12000) and (key2<>'railway' or keypairs.count_all>3000) and (key2<>'waterway' or keypairs.count_all>800) and key1 not like '%:%' and from_fraction_all>0.97 and 1 order by keypairs.count_all desc limit 1000;
3 */
4
5/* {0.key} without {1.key} (warning level) */
6way[junction ][!highway][junction!=yes],
7*[lanes ][!highway],
8*[lcn ][!highway],
9*[living_street ][!highway],
10*[maintenance ][!highway],
11*[median ][!highway],
12*[motorroad ][!highway],
13*[ntd_id ][!highway],
14*[sac_scale ][!highway],
15*[sidewalk ][!highway],
16*[step_count ][!highway],
17*[tracktype ][!highway],
18*[trail_visibility ][!highway],
19*[trolley_wire ][!highway],
20*[zip_left ][!highway],
21*[zip_right ][!highway],
22*[detail ][!railway][route!=railway],
23*[eddy_current_brake ][!railway][route!=railway],
24*[electrified ][!railway][route!=railway],
25*[etcs ][!railway][route!=railway],
26*[gauge ][!railway][route!=railway],
27*[grade_of_track ][!railway][route!=railway],
28*[kursbuchstrecke ][!railway][route!=railway],
29*[lzb ][!railway][route!=railway],
30*[old_railway_operator ][!railway][route!=railway],
31*[operating_procedure ][!railway][route!=railway],
32*[pzb ][!railway][route!=railway],
33*[radio ][!railway][route!=railway],
34*[structure_gauge ][!railway][route!=railway],
35*[tilting_technology ][!railway][route!=railway],
36*[track_class ][!railway][route!=railway],
37*[tracks ][!railway][route!=railway],
38*[traffic_mode ][!railway][route!=railway],
39*[usage ][!railway][route!=railway],
40*[workrules ][!railway][route!=railway],
41*[stream ][!waterway],
42*[length_unit ][!waterway],
43*[llid ][!waterway],
44*[canal ][!waterway],
45*[have_riverbank ][!waterway],
46*[border_type ][!boundary],
47*[bridge:structure ][!bridge],
48*[piste:difficulty ][!piste:type],
49*[source:date ][!source],
50*[source:name ][!name],
51*[source:maxspeed:forward ][!maxspeed:forward],
52*[source:maxspeed:backward ][!maxspeed:backward],
53*[source:maxspeed:forward ][!source:maxspeed:backward],
54*[source:maxspeed:backward ][!source:maxspeed:forward],
55*[source:building ][!building],
56*[source:ref ][!ref],
57*[source:population ][!population],
58*[source:postal_code ][!postal_code],
59*[source:ele ][!ele],
60*[source:ref:INSEE ][!ref:INSEE],
61*[source:lit ][!lit],
62*[source:hgv ][!hgv],
63*[source:highway ][!highway],
64*[source:maxaxleload ][!maxaxleload],
65*[source:surface ][!surface],
66*[source:bridge ][!bridge],
67*[source:old_name ][!old_name],
68*[source:bicycle ][!bicycle],
69*[source:designation ][!designation],
70*[source:height ][!height],
71*[source:lanes ][!lanes],
72*[source:postcode ][!addr:postcode],
73*[source:housenumber ][!addr:housenumber],
74*[source:addr:postcode ][!addr:postcode],
75*[source:addr:housenumber ][!addr:housenumber],
76*[source:addr ][!/^addr:/],
77*[source:maxspeed ][!/^maxspeed:?/] {
78 throwWarning: tr("{0} without {1}", "{0.key}", "{1.key}");
79 assertMatch: "way lanes=42";
80 assertNoMatch: "way lanes=42 highway=unclassified";
81 assertMatch: "node source:addr:postcode=postman";
82 assertMatch: "node source:addr=postman";
83 assertNoMatch: "node source:addr=postman addr:housenumber=42";
84}
85
86/* {0.key} without {1.key} (info level) */
87*[lanes:forward][!lanes:backward][oneway!=yes][oneway!=-1],
88*[lanes:backward][!lanes:forward][oneway!=yes][oneway!=-1],
89*[leaf_type ][!leaf_cycle],
90*[leaf_cycle][!leaf_type] {
91 throwOther: tr("{0} without {1}", "{0.key}", "{1.key}");
92}
93
94/* {0.key} without {1.tag} */
95*[fence_type ][barrier!=fence],
96*[recycling_type ][amenity!=recycling],
97*[information ][tourism!=information],
98*[board_type ][information!=board],
99*[shelter_type ][amenity!=shelter],
100*[lamp_type ][highway!=street_lamp],
101*[map_type ][information!=map],
102*[site_type ][historic!=archaeological_site],
103*[artwork_type ][tourism!=artwork],
104*[castle_type ][historic!=castle],
105*[reservoir_type ][landuse!=reservoir][water!=reservoir],
106*[bridge:movable ][bridge!=movable],
107*[parking ][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking)$/],
108*[cutline ][man_made!=cutline],
109*[bunker_type ][military!=bunker] {
110 throwWarning: tr("{0} without {1}", "{0.key}", "{1.tag}");
111}
112
113/* {0.tag} without {1.key} (warning level) */
114*[tourism=information][!information],
115*[aeroway=terminal][!building],
116*[power=generator][!generator:source],
117*[amenity=place_of_worship][!religion] {
118 throwWarning: tr("{0} without {1}", "{0.tag}", "{1.key}");
119}
120
121/* {0.tag} without {1.key} (info level) */
122*[amenity=parking ][!parking],
123*[amenity=parking_entrance ][!parking] {
124 throwOther: tr("{0} without {1}", "{0.tag}", "{1.key}");
125}
126
127/* {0.key} without {1.key} or {2.key} */
128*[incline ][!highway][!railway],
129*[oneway ][!highway][!railway] {
130 throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.key}");
131}
132
133/* {0.key} without {1.key} or {2.tag} */
134*[smoothness ][!highway][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking)$/],
135*[segregated ][!highway][railway!=crossing],
136*[boat ][!waterway][natural!=water] {
137 throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.tag}");
138}
139
140/* {0.tag} without {1.tag} (info level) see #11600 #11393*/
141*[highway=motorway][!oneway],
142*[highway=motorway_link][!oneway] {
143 throwOther: tr("{0} without {1}", "{0.tag}", "{1.tag}");
144}
145
146/* {0.tag} without {1.tag} or {2.tag} */
147*[amenity=recycling][recycling_type!=container][recycling_type!=centre] {
148 throwWarning: tr("{0} without {1} or {2}", "{0.tag}", "{1.tag}", "{2.tag}");
149}
150
151/* {0.key} without {1.key}, {2.tag} or {3.tag} */
152*[intermittent ][!waterway][natural!~/^(water|spring)$/][ford!=yes] {
153 throwWarning: tr("{0} without {1}, {2} or {3}", "{0.key}", "{1.key}", "{2.tag}", "{3.tag}");
154}
155
156/* {0.key} without {1.key}, {2.key} or {3.key} */
157*[snowplowing ][!highway][!amenity][!leisure] {
158 throwWarning: tr("{0} without {1}, {2} or {3}", "{0.key}", "{1.key}", "{2.key}", "{3.key}");
159}
160
161/* {0.key} without {1.key}, {2.key} or {3.tag} */
162*[toll ][!highway][!barrier][route!~/^(ferry|road)$/] {
163 throwWarning: tr("{0} without {1}, {2} or {3}", "{0.key}", "{1.key}", "{2.key}", "{3.tag}");
164}
165
166/* {0.tag} together with {1.key}, see #10837 */
167*[noname?][name] {
168 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.key}");
169}
170
171/* {0.tag} together with {1.key}, see #9389 */
172*[oneway=yes][/:backward/],
173*[oneway=yes][/:forward/],
174*[oneway=-1 ][/:backward/],
175*[oneway=-1 ][/:forward/] {
176 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.key}");
177}
178
179/* {0.tag} together with {1.tag} (info level), see #9696 */
180*[highway=footway][oneway=no] {
181 throwOther: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
182}
183
184/* {0.tag} together with {1.tag}, see #10186 */
185*[highway=footway][bicycle=designated] {
186 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
187}
188
189/*see #11127*/
190way[waterway][bridge=yes] {
191 throwWarning: tr("{0} together with {1}", "{0.key}", "{1.tag}");
192 suggestAlternative: "bridge=aqueduct";
193 fixAdd: "bridge=aqueduct";
194}
195
196/* only {0.key}, see #11104 */
197*[area][eval(number_of_tags()) = 1],
198*[name][eval(number_of_tags()) = 1],
199*[ref][eval(number_of_tags()) = 1] {
200 throwWarning: tr("incomplete object: only {0}", "{0.key}");
201}
202/* only {0.key} and {1.key}, see #11104 */
203*[name][area][eval(number_of_tags()) = 2],
204*[name][ref][eval(number_of_tags()) = 2] {
205 throwWarning: tr("incomplete object: only {0} and {1}", "{0.key}", "{1.key}");
206}
207
208/* see #9811 */
209*[place][place!=farm][/^addr:/],
210*[boundary][/^addr:/],
211*[highway][/^addr:/][highway!=services][highway!=rest_area] {
212 throwWarning: tr("{0} together with addr:*", "{0.key}");
213}
214
215/* see #9195 */
216*[highway=footway][cycleway=lane] {
217 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
218 suggestAlternative: "highway=path + foot=designated + bicycle=designated + segregated=yes";
219}
220
221/* {0} on suspicious object */
222*[tunnel ][!highway][!railway][!waterway][public_transport != platform][man_made != pipeline],
223*[bridge ][!highway][!railway][!waterway][!piste:type][public_transport != platform][man_made !~ /^(bridge|pipeline)$/][building != bridge],
224*[psv ][!highway][!railway][!waterway][amenity !~ /^parking.*/],
225*[width ][!highway][!railway][!waterway][!aeroway][!cycleway][!footway][!barrier][!man_made][!entrance],
226*[maxspeed][!highway][!railway][traffic_sign !~ /^(.*;)?maxspeed(;.*)?$/][type != enforcement][waterway !~ /^(river|canal|lock)$/][!traffic_calming],
227*[lit ][!highway][!railway][!piste:type][!amenity][public_transport!=platform][advertising!=billboard][!leisure][!tourism] {
228 throwWarning: tr("{0} on suspicious object", "{0.key}");
229}
230
231node[amenity =~ /^(restaurant|cafe|fast_food)$/][!name][noname!=yes] {
232 throwOther: tr("restaurant without name");
233 assertMatch: "node amenity=restaurant";
234 assertNoMatch: "node amenity=restaurant noname=yes";
235 assertNoMatch: "node amenity=restaurant name=Foobar";
236}
237
238way[highway][barrier],
239*[highway][waterway][waterway!=dam][waterway!=weir],
240way[highway][natural],
241*[landuse][building] {
242 throwWarning: tr("{0} used with {1}", "{0.key}", "{1.key}");
243 assertNoMatch: "node highway=street_lamp natural=birds_nest note=josm#10193";
244}
245
246*[natural=water][leisure=swimming_pool],
247*[natural=water][amenity=swimming_pool] {
248 /* see #6932 */
249 throwWarning: tr("natural water used for swimming pool");
250 fixRemove: "natural";
251}
252
253/* see #9593, #11183 */
254*[sport][!building][!club][tourism != hotel][highway != raceway][leisure !~ /^(sports_centre|stadium|track|pitch|golf_course|water_park|swimming_pool|recreation_ground|ice_rink)$/][natural !~ /^(beach|bare_rock|peak|water)$/][amenity !~ /^(pub|restaurant|swimming_pool)$/][landuse !~ /^(recreation_ground|piste|farm|farmland)$/][barrier !~ /^(wall|retaining_wall)$/][!"piste:type"] {
255 throwWarning: tr("sport without physical feature");
256 assertMatch: "node sport=tennis";
257 assertNoMatch: "node sport=tennis leisure=pitch";
258 assertNoMatch: "node sport=beachvolleyball natural=beach";
259 assertNoMatch: "node sport=skiiing landuse=piste";
260 assertNoMatch: "node sport=swimming tourism=hotel";
261 assertNoMatch: "node sport=10pin amenity=restaurant";
262}
263
264/* see #10140 */
265*[building:levels][!building][!building:part] {
266 throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.key}");
267}
268
269/* see #10471 */
270way[waterway] > node[ford?] { set ford_on_waterway; }
271way[highway] > node[ford?] { set ford_on_highway; }
272node[ford?]:in-downloaded-area!.ford_on_waterway, node[ford?]:in-downloaded-area!.ford_on_highway {
273 throwWarning: tr("{0} should be on the node where {1} and {2} intersect", "ford", "highway", "waterway");
274}
275
276/* any other *_name tag (with some exceptions) but not a name , see #10837 #11297 #11539 */
277*[/_name$/][!name][!old_name][!loc_name][!uic_name][!artist_name][!"osak:municipality_name"][!"osak:street_name"][noname!=yes] {
278 throwWarning: tr("alternative name without {0}", "{1.key}");
279}
280
281/* see #10837 */
282way[destination][!oneway?][highway] {
283 throwWarning: tr("incomplete usage of {0} on a way without {1}", "{0.key}", "{1.key}");
284 suggestAlternative: "destination:forward";
285 suggestAlternative: "destination:backward";
286}
287
288/* see #11389 */
289way["maxspeed:forward"=*"maxspeed:backward"][!maxspeed] {
290 throwWarning: tr("Same value of {0} and {1}", "{0.key}", "{1.key}");
291 suggestAlternative: "maxspeed";
292 fixChangeKey: "maxspeed:forward=>maxspeed";
293 fixRemove: "maxspeed:backward";
294}
295way["maxspeed:forward"=*maxspeed]["maxspeed:backward"=*maxspeed][maxspeed] {
296 throwWarning: tr("Same value of {0}, {1} and {2}", "{0.key}", "{1.key}", "{2.key}");
297 set AllSameMaxspeed;
298 suggestAlternative: "maxspeed";
299 fixRemove: "maxspeed:forward";
300 fixRemove: "maxspeed:backward";
301}
302way["maxspeed:forward"]["maxspeed:backward"][maxspeed]!.AllSameMaxspeed {
303 throwWarning: tr("{0} and {1} together with {2} and conflicting values", "{0.key}", "{1.key}", "{2.key}");
304}
305way["maxspeed:forward"][maxspeed][!"maxspeed:backward"],
306way["maxspeed:backward"][maxspeed][!"maxspeed:forward"] {
307 throwWarning: tr("{0} together with {1}", "{0.key}", "{1.key}");
308}
Note: See TracBrowser for help on using the repository browser.