Ticket #8902: whiletoforeach.diff

src/org/openstreetmap/josm/actions/FollowLineAction.java

@@ -84 +84 @@
         if (referrers.size() < 2) return; // There's nothing to follow
 
         Node newPoint = null;
-        Iterator<OsmPrimitive> i = referrers.iterator();
-        while (i.hasNext()) {
-            OsmPrimitive referrer = i.next();
+        for (OsmPrimitive referrer : referrers) {
             if (!referrer.getType().equals(OsmPrimitiveType.WAY)) { // Can't follow points or relations
                 continue;
             }

src/org/openstreetmap/josm/command/DeleteCommand.java

@@ -394 +394 @@
 
         // remove the objects from their parent relations
         //
-        Iterator<Relation> iterator = OsmPrimitive.getFilteredSet(OsmPrimitive.getReferrer(primitivesToDelete), Relation.class).iterator();
-        while (iterator.hasNext()) {
-            Relation cur = iterator.next();
+        for (Relation cur : OsmPrimitive.getFilteredSet(OsmPrimitive.getReferrer(primitivesToDelete), Relation.class)) {
             Relation rel = new Relation(cur);
             rel.removeMembersFor(primitivesToDelete);
             cmds.add(new ChangeCommand(cur, rel));

src/org/openstreetmap/josm/data/conflict/ConflictCollection.java

@@ -58 +58 @@
     }
 
     protected void fireConflictRemoved() {
-        Iterator<IConflictListener> it = listeners.iterator();
-        while(it.hasNext()) {
-            it.next().onConflictsRemoved(this);
+        for (IConflictListener listener : listeners) {
+            listener.onConflictsRemoved(this);
         }
     }
 

src/org/openstreetmap/josm/gui/dialogs/ConflictDialog.java

@@ -381 +381 @@
                     0,
                     getSize()
             );
-            Iterator<ListDataListener> it = listeners.iterator();
-            while(it.hasNext()) {
-                it.next().contentsChanged(evt);
+            for (ListDataListener listener : listeners) {
+                listener.contentsChanged(evt);
             }
         }
 

src/org/openstreetmap/josm/gui/dialogs/relation/GenericRelationEditor.java

@@ -772 +772 @@
             if (primitives == null || primitives.isEmpty())
                 return primitives;
             ArrayList<OsmPrimitive> ret = new ArrayList<OsmPrimitive>();
-            Iterator<OsmPrimitive> it = primitives.iterator();
-            while(it.hasNext()) {
-                OsmPrimitive primitive = it.next();
+            for (OsmPrimitive primitive : primitives) {
                 if (primitive instanceof Relation && getRelation() != null && getRelation().equals(primitive)) {
                     warnOfCircularReferences(primitive);
                     continue;
                 }
-                if (isPotentialDuplicate(primitive))  {
+                if (isPotentialDuplicate(primitive)) {
                     if (confirmAddingPrimitive(primitive)) {
                         ret.add(primitive);
                     }

src/org/openstreetmap/josm/gui/layer/geoimage/CorrelateGpxWithImages.java

@@ -451 +451 @@
         // Construct the list of loaded GPX tracks
         Collection<Layer> layerLst = Main.map.mapView.getAllLayers();
         GpxDataWrapper defaultItem = null;
-        Iterator<Layer> iterLayer = layerLst.iterator();
-        while (iterLayer.hasNext()) {
-            Layer cur = iterLayer.next();
+        for (Layer cur : layerLst) {
             if (cur instanceof GpxLayer) {
                 GpxLayer curGpx = (GpxLayer) cur;
                 GpxDataWrapper gdw = new GpxDataWrapper(curGpx.getName(), curGpx.data, curGpx.data.storageFile);