Ticket #3910: lassoOnS-5449.patch

src/org/openstreetmap/josm/gui/MapFrame.java

@@ -112 +112 @@
     public final SelectAction mapModeSelect;
     private final MapMode mapModeDraw;
     private final MapMode mapModeZoom;
+    public final MapMode mapModeLassoSelect; 
 
     /**
      * The panel list of all toggle dialog icons. To add new toggle dialog actions, use addToggleDialog
@@ -159 +160 @@
         // toolbar
         toolBarActions.setFloatable(false);
         addMapMode(new IconToggleButton(mapModeSelect = new SelectAction(this)));
-        addMapMode(new IconToggleButton(new LassoModeAction(), true));
+        addMapMode(new IconToggleButton(mapModeLassoSelect = new LassoModeAction(), true))  ;
         addMapMode(new IconToggleButton(mapModeDraw = new DrawAction(this)));
         addMapMode(new IconToggleButton(mapModeZoom = new ZoomAction(this)));
         addMapMode(new IconToggleButton(new DeleteAction(this), true));
@@ -361 +362 @@
             return false;
 
         MapMode oldMapMode = this.mapMode;
-        if (newMapMode == oldMapMode)
+        if (newMapMode == oldMapMode) {
+            newMapMode.reenterMode();
             return true;
+        }
         if (oldMapMode != null) {
             oldMapMode.exitMode();
         }

src/org/openstreetmap/josm/actions/LassoModeAction.java

@@ -5 +5 @@
 
 import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.actions.mapmode.MapMode;
+import org.openstreetmap.josm.tools.ImageProvider;
 
 public class LassoModeAction extends MapMode {
 
@@ -13 +14 @@
                 "rope",
                 tr("Lasso selection mode: select objects within a hand-drawn region"),
                 null,
-                null);
+                ImageProvider.getCursor("normal", "rope"));
     }
 
     @Override
@@ -31 +32 @@
         Main.map.mapModeSelect.exitMode();
         super.exitMode();
     }
+    
+    @Override
+    public void reenterMode() {
+        if (Main.map != null && Main.map.mapModeSelect.repeatedKeySwitchLassoOption) {
+            Main.map.selectMapMode(Main.map.mapModeSelect);
+        }
+    }
 }

src/org/openstreetmap/josm/actions/mapmode/SelectAction.java

@@ -100 +100 @@
     }
 
     private boolean lassoMode = false;
+    public boolean repeatedKeySwitchLassoOption;
 
     // Cache previous mouse event (needed when only the modifier keys are
     // pressed but the mouse isn't moved)
@@ -180 +181 @@
         mv.addMouseMotionListener(this);
         mv.setVirtualNodesEnabled(Main.pref.getInteger("mappaint.node.virtual-size", 8) != 0);
         drawTargetHighlight = Main.pref.getBoolean("draw.target-highlight", true);
+        repeatedKeySwitchLassoOption = Main.pref.getBoolean("mappaint.select.toggle-lasso-on-repeated-S", true);
         cycleManager.init();
         virtualManager.init();
         // This is required to update the cursors when ctrl/shift/alt is pressed
@@ -873 +875 @@
         this.lassoMode = lassoMode;
     }
     
+    @Override 
+    public void reenterMode() { 
+        if (Main.map!=null && repeatedKeySwitchLassoOption) {
+            Main.map.selectMapMode(Main.map.mapModeLassoSelect);
+        } 
+    } 
+    
     CycleManager cycleManager = new CycleManager();
     VirtualManager virtualManager = new VirtualManager();
     

src/org/openstreetmap/josm/actions/mapmode/MapMode.java

@@ -57 +57 @@
         putValue("active", false);
         Main.map.mapView.resetCursor(this);
     }
+    /**
+     * For optionlal overloading - called when action is repeated while mapmode
+     * is already active
+     */
+    public void reenterMode() {
+    }
 
     protected void updateStatusLine() {
         Main.map.statusLine.setHelpText(getModeHelpText());