Ticket #21124: 21124.patch

src/org/openstreetmap/josm/gui/tagging/presets/items/Text.java

@@ -21 +21 @@
 import javax.swing.JLabel;
 import javax.swing.JPanel;
 import javax.swing.JToggleButton;
-import javax.swing.SwingUtilities;
 
 import org.openstreetmap.josm.data.osm.Tag;
 import org.openstreetmap.josm.gui.tagging.ac.AutoCompletingTextField;
@@ -249 +248 @@
     }
 
     private void setupListeners(AutoCompletingTextField textField, TaggingPresetItemGuiSupport support) {
-        textField.getDocument().addDocumentListener(DocumentAdapter.create(ignore ->
-                support.fireItemValueModified(this, key, textField.getText())));
-
-        if (valueTemplate != null) {
+        // don't fire on calculated fields because you can easily get into a loop
+        if (valueTemplate == null) { 
+            textField.getDocument().addDocumentListener(DocumentAdapter.create(event ->
+                    support.fireItemValueModified(this, key, textField.getText())));
+        } else {
             textField.setForeground(Color.BLUE);
             support.addListener((source, key, newValue) -> {
-                if (source != this) {
-                    String valueTemplateText = valueTemplate.getText(support);
-                    Logging.trace("Evaluating value_template {0} for key {1} from {2} with new value {3} => {4}",
-                            valueTemplate, key, source, newValue, valueTemplateText);
-                    if (!textField.getText().equals(valueTemplateText)) {
-                        SwingUtilities.invokeLater(() -> textField.setItem(valueTemplateText));
-                    }
-                }
+                String valueTemplateText = valueTemplate.getText(support);
+                Logging.trace("Evaluating value_template {0} for key {1} from {2} with new value {3} => {4}",
+                        valueTemplate, key, source, newValue, valueTemplateText);
+                textField.setItem(valueTemplateText);
             });
         }
     }