Ticket #18523: 18523.revert_gridbaglayout_add_seemingly_unnecessary_call.patch

src/org/openstreetmap/josm/gui/io/BasicUploadSettingsPanel.java

@@ -3 +3 @@
 
 import static org.openstreetmap.josm.tools.I18n.tr;
 
+import java.awt.BorderLayout;
 import java.awt.GridBagLayout;
 import java.awt.event.ActionEvent;
 import java.awt.event.ActionListener;
@@ -176 +177 @@
     }
 
     protected void build() {
-        setLayout(new GridBagLayout());
+        setLayout(new BorderLayout());
         setBorder(BorderFactory.createEmptyBorder(3, 3, 3, 3));
-        add(buildUploadCommentPanel(), GBC.eol().fill(GBC.BOTH));
-        add(pnlUploadParameterSummary, GBC.eol().fill(GBC.BOTH));
-        add(cbRequestReview, GBC.eol().fill(GBC.BOTH));
+        add(buildUploadCommentPanel(), BorderLayout.NORTH);
+        add(pnlUploadParameterSummary, BorderLayout.CENTER);
+        add(cbRequestReview, BorderLayout.SOUTH);
         cbRequestReview.addItemListener(e -> changesetReviewModel.setReviewRequested(e.getStateChange() == ItemEvent.SELECTED));
     }
 

src/org/openstreetmap/josm/gui/io/UploadDialog.java

@@ -432 +432 @@
     static final class CompactTabbedPane extends JTabbedPane {
         @Override
         public Dimension getPreferredSize() {
+            // This probably fixes #18523. Don't know why. Don't know how. It just does.
+            super.getPreferredSize();
             // make sure the tabbed pane never grabs more space than necessary
             return super.getMinimumSize();
         }