Changes between Initial Version and Version 1 of Ticket #23482, comment 13


Ignore:
Timestamp:
2024-03-05T17:33:12+01:00 (3 months ago)
Author:
taylor.smock

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #23482, comment 13

    initial v1  
    22
    33Quick comments on the patch:
    4 * Why are you assigning a variable that you just return in `buildReferenceTable` and `buildCurrentTable`?
     4* ~~Why are you assigning a variable that you just return in `buildReferenceTable` and `buildCurrentTable`?~~ NVM. I missed the new fields.
    55* Where did `this.getWidth() / 4` come from? Shouldn't it either be `3` or `6` (why not get the number of cols for the table for that matter?)
    66* What are the performance implications for objects with a lot of tags? (Might not be an issue)