# # ChangeLog for / in josm # # Generated by Trac 1.6 # 2024-05-10T04:58:53+02:00 Sat, 27 Apr 2024 08:24:46 GMT GerdP [19064] * trunk/src/org/openstreetmap/josm/data/algorithms/Tarjan.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/NodeGraph.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/tests/CycleDetector.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/osm/WaySegmentTest.java (modified) see #21881 Add a check for loops in directional waterways - fix @since xxx - adapt unit test Sat, 27 Apr 2024 07:11:12 GMT GerdP [19063] * trunk/src/org/openstreetmap/josm/gui/history/HistoryLoadTask.java (modified) see #21881: revert unintended change for different ticket Sat, 27 Apr 2024 06:58:28 GMT GerdP [19062] * trunk/src/org/openstreetmap/josm/data/algorithms (added) * trunk/src/org/openstreetmap/josm/data/algorithms/Tarjan.java (added) * trunk/src/org/openstreetmap/josm/data/algorithms/package-info.java (added) * trunk/src/org/openstreetmap/josm/data/osm/NodeGraph.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/WaySegment.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/OsmValidator.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/tests/CycleDetector.java (added) * trunk/src/org/openstreetmap/josm/gui/history/HistoryLoadTask.java (modified) * trunk/test/data/regress/21881 (added) * trunk/test/data/regress/21881/CycleDetector_test_wikipedia.osm (added) * trunk/test/data/regress/21881/not_consecutive.osm (added) * trunk/test/unit/org/openstreetmap/josm/data/validation/tests/CycleDetectorTest.java (added) fix #21881: Add a check for loops in directional waterways Patch by gaben, slightly modified - implements Tarjan algorithm to find strongly connected components - new preference `validator.CycleDetector.directionalWaterways` contains the list of waterway values which should be checked Fri, 26 Apr 2024 14:00:41 GMT taylor.smock [19061] * trunk/.github/workflows/ant.yml (modified) * trunk/native/macosx/macos-jpackage.sh (modified) Fix #23643: Move to supported actions for GitHub ant workflow to remove node16 deprecation warnings Fri, 26 Apr 2024 07:41:16 GMT stoecker [19060] * trunk/src/org/openstreetmap/josm/gui/MapView.java (modified) fix pmd Fri, 26 Apr 2024 07:12:28 GMT stoecker [19059] * trunk/.github/workflows/ant.yml (modified) * trunk/.github/workflows/pmd-analysis.yml (modified) drop node16 and Java8, see #23643 Thu, 25 Apr 2024 21:42:21 GMT taylor.smock [19058] * trunk/.github/workflows/ant-test.yml (modified) * trunk/.github/workflows/checkstyle-analysis.yml (modified) * trunk/.github/workflows/codeql-analysis.yml (modified) GitHub CI: Fix deprecation warnings for CodeQL and checkstyle workflows Also drop Java 8 from ant-test. Thu, 25 Apr 2024 07:46:47 GMT stoecker [19057] * trunk/src/org/openstreetmap/josm/gui/MapView.java (modified) * trunk/test/unit/org/openstreetmap/josm/tools/date/DateUtilsTest.java (modified) fix checkstyle Wed, 24 Apr 2024 18:02:57 GMT taylor.smock [19056] * trunk/test/data/renderer/node-shapes-combined/reference-java21.png (copied) * trunk/test/functional/org/openstreetmap/josm/gui/mappaint/MapCSSRendererTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/TestUtils.java (modified) * trunk/test/unit/org/openstreetmap/josm/actions/SessionSaveActionTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/actions/downloadtasks/PluginDownloadTaskTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/preferences/imagery/ImageryPreferenceTestIT.java (modified) * trunk/test/unit/org/openstreetmap/josm/io/remotecontrol/RemoteControlTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/io/session/SessionWriterTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/testutils/annotations/AnnotationUtils.java (modified) * trunk/test/unit/org/openstreetmap/josm/testutils/annotations/BasicWiremock.java (modified) * trunk/test/unit/org/openstreetmap/josm/tools/UtilsTest.java (modified) Fix last failing test in Java 21 * Generate Java 21 image files (probably from r19043: Drop COMPAT locale provider). * Replace most deprecated function calls and classes in tests with non-deprecated functions. Tue, 23 Apr 2024 16:41:05 GMT taylor.smock [19055] * trunk/test/data/ImageProviderTest-java21/housenumber_small-AUTO-08x08.png (modified) * trunk/test/data/ImageProviderTest-java21/housenumber_small-AUTO-16x16.png (modified) * trunk/test/data/ImageProviderTest-java21/housenumber_small-AUTO-24x24.png (modified) * trunk/test/data/ImageProviderTest-java21/housenumber_small-AUTO-36x27.png (modified) * trunk/test/data/ImageProviderTest-java21/housenumber_small-AUTO-default.png (modified) * trunk/test/data/ImageProviderTest-java21/housenumber_small-AUTO-null.png (modified) * trunk/test/data/ImageProviderTest-java21/housenumber_small-BOUNDED-08x08.png (modified) * trunk/test/data/ImageProviderTest-java21/housenumber_small-BOUNDED-16x16.png (modified) * trunk/test/data/ImageProviderTest-java21/housenumber_small-BOUNDED-24x24.png (modified) * trunk/test/data/ImageProviderTest-java21/housenumber_small-PADDED-08x08.png (modified) * trunk/test/data/ImageProviderTest-java21/housenumber_small-PADDED-16x16.png (modified) * trunk/test/data/ImageProviderTest-java21/housenumber_small-PADDED-24x24.png (modified) * trunk/test/data/ImageProviderTest-java8 (deleted) * trunk/test/data/renderer/area-fill-color/reference-java8.png (deleted) * trunk/test/data/renderer/area-fill-image/reference-java8.png (deleted) * trunk/test/data/renderer/area-icon/reference-java8.png (deleted) * trunk/test/data/renderer/area-text/reference-java8.png (deleted) * trunk/test/data/renderer/eval/reference-java8.png (deleted) * trunk/test/data/renderer/node-shapes-combined/reference-java8.png (deleted) * trunk/test/data/renderer/node-shapes-default/reference-java8.png (deleted) * trunk/test/data/renderer/node-shapes/reference-java8.png (deleted) * trunk/test/data/renderer/node-shapes2/reference-java8.png (deleted) * trunk/test/data/renderer/node-text/reference-java8.png (deleted) * trunk/test/data/renderer/node-text2/reference-java8.png (deleted) * trunk/test/data/renderer/order/reference-java8.png (deleted) * trunk/test/data/renderer/relation-linkselector/reference-java8.png (deleted) * trunk/test/data/renderer/relation-parentselector/reference-java8.png (deleted) * trunk/test/data/renderer/way-color/reference-java8.png (deleted) * trunk/test/data/renderer/way-dashes-clamp/reference-java8.png (deleted) * trunk/test/data/renderer/way-dashes/reference-java8.png (deleted) * trunk/test/data/renderer/way-dashes2/reference-java8.png (deleted) * trunk/test/data/renderer/way-repeat-image-clamp/reference-java8.png (deleted) * trunk/test/data/renderer/way-repeat-image/reference-java8.png (deleted) * trunk/test/data/renderer/way-text/reference-java8.png (deleted) * trunk/test/data/renderer/way-width/reference-java8.png (deleted) * trunk/test/functional/org/openstreetmap/josm/gui/mappaint/MapCSSRendererTest.java (modified) * trunk/test/functional/org/openstreetmap/josm/tools/ImageProviderTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/tools/date/DateUtilsTest.java (modified) Fix tests in Java 21 * Regenerate Java 21 image files (probably from r19043: Drop COMPAT locale provider). * Remove Java 8 image files, since we no longer support Java 8. * Fix an issue where Java 21 uses a non-breaking space between time and AM/PM. Tue, 23 Apr 2024 14:13:30 GMT taylor.smock [19054] * trunk/test/unit/org/openstreetmap/josm/tools/JosmDecimalFormatSymbolsProviderTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/tools/date/DateUtilsTest.java (modified) See r19043: Drop COMPAT locale provider The CLDR provider does not currently return the CET for GMT+01:00. Using only SPI will result in the "correct" CET timezone abbreviation. If using both, CLDR wins and returns GMT+01:00. In addition, there are locales that do not use the Western Arabic numeral system. Specifically, Arabic uses the Eastern Arabic numeral system, Persian uses the Urdu numeral system, and Marathi uses the Devanagari numeral system. Of note, while the first character for the Eastern Arabic and Urdu numeral systems ''looks'' the same, it is a different character. Mon, 22 Apr 2024 19:53:19 GMT taylor.smock [19053] * trunk/test/unit/org/openstreetmap/josm/tools/JosmDecimalFormatSymbolsProviderTest.java (modified) See r19043: Drop COMPAT locale provider Update a test that expected a specific locale provider order. This also removes a Java >= 9 version check, since that is now always true. Mon, 22 Apr 2024 19:43:15 GMT taylor.smock [19052] * trunk/test/unit/org/openstreetmap/josm/data/imagery/WMSEndpointTileSourceTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/imagery/WMTSTileSourceTest.java (modified) Fix some wiremock tests -- wiremock no longer considers `//` to be a valid URI. From history, it appears that this may have been a typo (any URL to `//maps`). Mon, 22 Apr 2024 19:21:19 GMT taylor.smock [19051] * trunk/native/windows/win-jpackage.sh (modified) See #23552: Update JOSM version in MS store Change `JOSM HWConsole` to `JOSM (Debug)` in order to attempt to indicate to app reviewer that the HWConsole application is no the "main" app. Mon, 22 Apr 2024 18:59:26 GMT taylor.smock [19050] * trunk/build.xml (modified) * trunk/scripts/TagInfoExtract.java (modified) * trunk/scripts/TaggingPresetSchemeWikiGenerator.java (modified) * trunk/src/org/openstreetmap/josm/actions/AddImageryLayerAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/AutoScaleAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/DownloadOsmInViewAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/JoinAreasAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/SplitWayAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/corrector/ReverseWayNoTagCorrector.java (modified) * trunk/src/org/openstreetmap/josm/actions/downloadtasks/DownloadReferrersTask.java (modified) * trunk/src/org/openstreetmap/josm/actions/mapmode/DeleteAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/mapmode/ParallelWayAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/mapmode/SelectAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/search/SearchAction.java (modified) * trunk/src/org/openstreetmap/josm/command/AddCommand.java (modified) * trunk/src/org/openstreetmap/josm/command/ChangeCommand.java (modified) * trunk/src/org/openstreetmap/josm/command/ChangePropertyCommand.java (modified) * trunk/src/org/openstreetmap/josm/command/DeleteCommand.java (modified) * trunk/src/org/openstreetmap/josm/command/PurgeCommand.java (modified) * trunk/src/org/openstreetmap/josm/command/conflict/ModifiedConflictResolveCommand.java (modified) * trunk/src/org/openstreetmap/josm/command/conflict/VersionConflictResolveCommand.java (modified) * trunk/src/org/openstreetmap/josm/data/UndoRedoHandler.java (modified) * trunk/src/org/openstreetmap/josm/data/cache/JCSCachedTileLoaderJob.java (modified) * trunk/src/org/openstreetmap/josm/data/coor/conversion/LatLonParser.java (modified) * trunk/src/org/openstreetmap/josm/data/imagery/TMSCachedTileLoaderJob.java (modified) * trunk/src/org/openstreetmap/josm/data/imagery/WMTSTileSource.java (modified) * trunk/src/org/openstreetmap/josm/data/oauth/OAuth20Exception.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/DataSetMerger.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/OsmDataManager.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/PrimitiveComparator.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/search/SearchCompiler.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/StyledMapRenderer.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/relations/Multipolygon.java (modified) * trunk/src/org/openstreetmap/josm/data/preferences/JosmBaseDirectories.java (modified) * trunk/src/org/openstreetmap/josm/data/preferences/JosmUrls.java (modified) * trunk/src/org/openstreetmap/josm/data/preferences/PreferencesReader.java (modified) * trunk/src/org/openstreetmap/josm/data/projection/datum/NTV2Proj4DirGridShiftFileSource.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/ValidatorCLI.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/routines/DomainValidator.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/tests/RelationChecker.java (modified) * trunk/src/org/openstreetmap/josm/gui/MainApplication.java (modified) * trunk/src/org/openstreetmap/josm/gui/MainFrame.java (modified) * trunk/src/org/openstreetmap/josm/gui/MainInitialization.java (modified) * trunk/src/org/openstreetmap/josm/gui/MapMover.java (modified) * trunk/src/org/openstreetmap/josm/gui/MenuScroller.java (modified) * trunk/src/org/openstreetmap/josm/gui/NavigatableComponent.java (modified) * trunk/src/org/openstreetmap/josm/gui/NotificationManager.java (modified) * trunk/src/org/openstreetmap/josm/gui/SelectionManager.java (modified) * trunk/src/org/openstreetmap/josm/gui/bbox/SlippyMapController.java (modified) * trunk/src/org/openstreetmap/josm/gui/conflict/pair/nodes/NodeListTableCellRenderer.java (modified) * trunk/src/org/openstreetmap/josm/gui/conflict/pair/properties/PropertiesMergeModel.java (modified) * trunk/src/org/openstreetmap/josm/gui/conflict/pair/relation/RelationMemberTableCellRenderer.java (modified) * trunk/src/org/openstreetmap/josm/gui/conflict/pair/tags/TagMergeTableCellRenderer.java (modified) * trunk/src/org/openstreetmap/josm/gui/conflict/tags/MultiValueCellEditor.java (modified) * trunk/src/org/openstreetmap/josm/gui/conflict/tags/MultiValueCellRenderer.java (modified) * trunk/src/org/openstreetmap/josm/gui/conflict/tags/MultiValueResolutionDecision.java (modified) * trunk/src/org/openstreetmap/josm/gui/conflict/tags/PasteTagsConflictResolverDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/conflict/tags/RelationMemberConflictResolverModel.java (modified) * trunk/src/org/openstreetmap/josm/gui/conflict/tags/TagConflictResolverModel.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/CommandStackDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/ConflictResolutionDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/DeleteFromRelationConfirmationDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/LayerListDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/MapPaintDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/MenuItemSearchDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/SelectionListDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/UserListDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/ChangesetCacheTableCellRenderer.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/ChangesetContentTableCellRenderer.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/ChangesetContentTableModel.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/ChangesetDiscussionTableCellRenderer.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/query/BasicChangesetQueryPanel.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/query/ChangesetQueryDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/layer/MergeGpxLayerDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/properties/PropertiesDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/relation/GenericRelationEditor.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/relation/actions/SetRoleAction.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/relation/sort/RelationSorter.java (modified) * trunk/src/org/openstreetmap/josm/gui/download/OSMDownloadSource.java (modified) * trunk/src/org/openstreetmap/josm/gui/download/PlaceSelection.java (modified) * trunk/src/org/openstreetmap/josm/gui/history/RelationMemberListTableCellRenderer.java (modified) * trunk/src/org/openstreetmap/josm/gui/history/TagTableCellRenderer.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/AbstractUploadTask.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/ChangesetManagementPanel.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/CredentialDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/CustomConfigurator.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/OnlineResourceMenu.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/SaveLayersDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/SaveLayersModel.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/SaveLayersTable.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/UploadPrimitivesTask.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/UploadStrategySelectionPanel.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/AbstractTileSourceLayer.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/ImageryLayer.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/geoimage/CorrelateGpxWithImages.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/geoimage/ImageDisplay.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/geoimage/RemoteEntry.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/gpx/ImportAudioAction.java (modified) * trunk/src/org/openstreetmap/josm/gui/mappaint/mapcss/Selector.java (modified) * trunk/src/org/openstreetmap/josm/gui/mappaint/styleelement/LabelCompositionStrategy.java (modified) * trunk/src/org/openstreetmap/josm/gui/oauth/AuthorizationProcedure.java (modified) * trunk/src/org/openstreetmap/josm/gui/oauth/OAuthAuthorizationWizard.java (modified) * trunk/src/org/openstreetmap/josm/gui/preferences/ToolbarPreferences.java (modified) * trunk/src/org/openstreetmap/josm/gui/preferences/advanced/AbstractTableListEditor.java (modified) * trunk/src/org/openstreetmap/josm/gui/preferences/advanced/ListListEditor.java (modified) * trunk/src/org/openstreetmap/josm/gui/preferences/advanced/MapListEditor.java (modified) * trunk/src/org/openstreetmap/josm/gui/preferences/imagery/WMSLayerTree.java (modified) * trunk/src/org/openstreetmap/josm/gui/preferences/projection/CodeSelectionPanel.java (modified) * trunk/src/org/openstreetmap/josm/gui/preferences/server/OsmApiUrlInputPanel.java (modified) * trunk/src/org/openstreetmap/josm/gui/progress/AbstractProgressMonitor.java (modified) * trunk/src/org/openstreetmap/josm/gui/tagging/TagCellRenderer.java (modified) * trunk/src/org/openstreetmap/josm/gui/tagging/TagEditorModel.java (modified) * trunk/src/org/openstreetmap/josm/gui/tagging/TagTable.java (modified) * trunk/src/org/openstreetmap/josm/gui/tagging/ac/AutoCompEvent.java (modified) * trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetMenu.java (modified) * trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetSelector.java (modified) * trunk/src/org/openstreetmap/josm/gui/util/AdjustmentSynchronizer.java (modified) * trunk/src/org/openstreetmap/josm/gui/util/MultikeyActionsHandler.java (modified) * trunk/src/org/openstreetmap/josm/gui/widgets/JosmTextField.java (modified) * trunk/src/org/openstreetmap/josm/gui/widgets/MultiSplitPane.java (modified) * trunk/src/org/openstreetmap/josm/io/CachedFile.java (modified) * trunk/src/org/openstreetmap/josm/io/ChangesetQuery.java (modified) * trunk/src/org/openstreetmap/josm/io/ChangesetUpdater.java (modified) * trunk/src/org/openstreetmap/josm/io/DiffResultProcessor.java (modified) * trunk/src/org/openstreetmap/josm/io/FileWatcher.java (modified) * trunk/src/org/openstreetmap/josm/io/GpxParser.java (modified) * trunk/src/org/openstreetmap/josm/io/GpxWriter.java (modified) * trunk/src/org/openstreetmap/josm/io/MessageNotifier.java (modified) * trunk/src/org/openstreetmap/josm/io/MultiFetchServerObjectReader.java (modified) * trunk/src/org/openstreetmap/josm/io/NameFinder.java (modified) * trunk/src/org/openstreetmap/josm/io/NoteReader.java (modified) * trunk/src/org/openstreetmap/josm/io/OsmApi.java (modified) * trunk/src/org/openstreetmap/josm/io/OsmChangesetParser.java (modified) * trunk/src/org/openstreetmap/josm/io/OsmHistoryReader.java (modified) * trunk/src/org/openstreetmap/josm/io/OsmPbfReader.java (modified) * trunk/src/org/openstreetmap/josm/io/OsmServerWriter.java (modified) * trunk/src/org/openstreetmap/josm/io/UploadStrategySpecification.java (modified) * trunk/src/org/openstreetmap/josm/io/auth/JosmPreferencesCredentialAgent.java (modified) * trunk/src/org/openstreetmap/josm/io/imagery/ImageryReader.java (modified) * trunk/src/org/openstreetmap/josm/io/nmea/NmeaParser.java (modified) * trunk/src/org/openstreetmap/josm/io/session/GeoImageSessionImporter.java (modified) * trunk/src/org/openstreetmap/josm/io/session/SessionReader.java (modified) * trunk/src/org/openstreetmap/josm/plugins/Plugin.java (modified) * trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java (modified) * trunk/src/org/openstreetmap/josm/tools/CopyList.java (modified) * trunk/src/org/openstreetmap/josm/tools/I18n.java (modified) * trunk/src/org/openstreetmap/josm/tools/ImageResizeMode.java (modified) * trunk/src/org/openstreetmap/josm/tools/ListenerList.java (modified) * trunk/src/org/openstreetmap/josm/tools/Logging.java (modified) * trunk/src/org/openstreetmap/josm/tools/Shortcut.java (modified) * trunk/src/org/openstreetmap/josm/tools/Utils.java (modified) * trunk/src/org/openstreetmap/josm/tools/XmlObjectParser.java (modified) * trunk/src/org/openstreetmap/josm/tools/bugreport/BugReportQueue.java (modified) * trunk/test/performance/org/openstreetmap/josm/gui/mappaint/MapRendererPerformanceTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/actions/UploadActionTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/actions/mapmode/ImproveWayAccuracyActionTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/actions/upload/UploadNotesTaskTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/command/CommandTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/cache/JCSCachedTileLoaderJobTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/gpx/GpxDataTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/imagery/TMSCachedTileLoaderJobTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/imagery/vectortile/mapbox/MapboxVectorTileSourceTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/oauth/OAuth20AuthorizationTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/projection/ProjectionRegressionTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/dialogs/relation/GenericRelationEditorTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/io/SaveLayersDialogTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/preferences/plugin/PluginPreferenceHighLevelTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/io/remotecontrol/handler/AuthorizationHandlerTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/plugins/PluginHandlerJOSMTooOldTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/plugins/PluginHandlerMultiVersionTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/spi/lifecycle/LifecycleTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/tools/LanguageInfoTest.java (modified) Revert most `var` changes from r19048, fix most new compile warnings and checkstyle issues Also, document why various ErrorProne checks were originally disabled and fix generic SonarLint issues. Mon, 22 Apr 2024 11:48:15 GMT stoecker [19049] * trunk/src/org/openstreetmap/josm/io/GpxParser.java (modified) reimport previously exported dgpsid Fri, 19 Apr 2024 14:21:11 GMT taylor.smock [19048] * trunk/build.xml (modified) * trunk/ivy.xml (modified) * trunk/ivysettings.xml (modified) * trunk/src/org/openstreetmap/josm/actions/AddImageryLayerAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/AutoScaleAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/ChangesetManagerToggleAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/DownloadOsmInViewAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/JoinAreasAction.java (modified) * trunk/src/org/openstreetmap/josm/actions/SplitWayAction.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/search/SearchCompiler.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/ValidatorCLI.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/relation/sort/RelationSorter.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/UploadPrimitivesTask.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/geoimage/CorrelateGpxWithImages.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/geoimage/RemoteEntry.java (modified) * trunk/src/org/openstreetmap/josm/gui/mappaint/styleelement/LabelCompositionStrategy.java (modified) * trunk/src/org/openstreetmap/josm/gui/widgets/JosmTextField.java (modified) * trunk/src/org/openstreetmap/josm/io/NoteReader.java (modified) * trunk/src/org/openstreetmap/josm/io/OsmPbfReader.java (modified) * trunk/src/org/openstreetmap/josm/tools/ImageResizeMode.java (modified) * trunk/src/org/openstreetmap/josm/tools/Utils.java (modified) * trunk/tools/eclipse/JOSM (Java 8).launch (deleted) * trunk/tools/ivy.xml (modified) Dependency updates ivy.xml * org.eclipse.parsson:parsson: 1.1.5 -> 1.1.6 * org.apache.commons:commons-compress: 1.25.0 -> 1.26.1 * Note: This deprecated some functions * ch.poole:OpeningHoursParser: 0.28.1 -> 0.28.2 * org.jacoco:org.jacoco.ant: 0.8.11 -> 0.8.12 * com.github.spotbugs:spotbugs-annotations: 4.8.3 -> 4.8.4 * com.github.tomakehurst:wiremock: 2.35.0 -> 3.0.1 * io.github.classgraph:classgraph: 4.8.165 -> 4.8.171 * nl.jqno.equalsverifier:equalsverifier: 3.15.6 -> 3.16.1 * org.awaitility:awaitility: 4.2.0 -> 4.2.1 tools/ivy.xml * com.puppycrawl.tools:checkstyle: 9.3 -> 10.15.0 * com.github.spotbugs:spotbugs: 4.8.3 -> 4.8.4 * com.google.errorprone: 2.(10.0|24.1) -> 2.26.1 * net.sourceforge.pmd:pmd was not updated to 7.0.0 due to a significant number of false positives. There were some additional changes to cleanup new warnings and remove some additional Java 8 files. There are more warnings that need to be cleaned up. Fri, 19 Apr 2024 09:55:53 GMT stoecker [19047] * trunk/native/josm-latest.jnlp (modified) * trunk/native/josm.jnlp (modified) switch JNLP to 11 (hope this is right, can't test here), see #17858 Fri, 19 Apr 2024 09:50:21 GMT stoecker [19046] * trunk/src/org/openstreetmap/josm/tools/LanguageInfo.java (modified) typo in javadoc, see #23627 Fri, 19 Apr 2024 09:48:22 GMT stoecker [19045] * trunk/src/org/openstreetmap/josm/gui/mappaint/styleelement/LabelCompositionStrategy.java (modified) * trunk/src/org/openstreetmap/josm/tools/LanguageInfo.java (modified) support language keys not following the naming of languages in JOSM, allow more than one language specific code, see #23627 Fri, 19 Apr 2024 09:43:25 GMT stoecker [19044] * trunk/build.xml (modified) switch build-xml to java 11 and drop java 9 support, see #17858 Thu, 18 Apr 2024 21:20:21 GMT stoecker [19043] * trunk/build.xml (modified) * trunk/src/org/openstreetmap/josm/tools/I18n.java (modified) drop COMPAT locale provider Thu, 18 Apr 2024 11:46:08 GMT stoecker [19042] * trunk/src/org/openstreetmap/josm/tools/TextTagParser.java (modified) fix #23625 - allow - sign in keys Thu, 18 Apr 2024 05:20:26 GMT GerdP [19041] * trunk/src/org/openstreetmap/josm/tools/PlatformHookWindows.java (modified) see #23619: prefer to show key `SOFTWARE\Microsoft\Windows\NT\CurrentVersion\DisplayVersion` Tue, 16 Apr 2024 07:26:09 GMT stoecker [19040] * trunk/build.xml (modified) add gpl to ant build, see #23552 Tue, 09 Apr 2024 16:11:42 GMT taylor.smock [19039] * trunk/src/org/openstreetmap/josm/data/validation/routines/DomainValidator.java (modified) remove TLD from IANA Mon, 08 Apr 2024 16:03:19 GMT stoecker [19038] * trunk/src/org/openstreetmap/josm/io/OsmPbfReader.java (modified) checkstyle Mon, 08 Apr 2024 15:33:44 GMT taylor.smock [19037] * trunk/nodist/trans/nl.lang (modified) * trunk/resources/data/ar.lang (modified) * trunk/resources/data/ast.lang (modified) * trunk/resources/data/be.lang (modified) * trunk/resources/data/bg.lang (modified) * trunk/resources/data/ca-valencia.lang (modified) * trunk/resources/data/ca.lang (modified) * trunk/resources/data/cs.lang (modified) * trunk/resources/data/da.lang (modified) * trunk/resources/data/de.lang (modified) * trunk/resources/data/el.lang (modified) * trunk/resources/data/en.lang (modified) * trunk/resources/data/en_AU.lang (modified) * trunk/resources/data/en_GB.lang (modified) * trunk/resources/data/es.lang (modified) * trunk/resources/data/et.lang (modified) * trunk/resources/data/fa.lang (modified) * trunk/resources/data/fi.lang (modified) * trunk/resources/data/fr.lang (modified) * trunk/resources/data/gl.lang (modified) * trunk/resources/data/hu.lang (modified) * trunk/resources/data/id.lang (modified) * trunk/resources/data/is.lang (modified) * trunk/resources/data/it.lang (modified) * trunk/resources/data/ja.lang (modified) * trunk/resources/data/km.lang (modified) * trunk/resources/data/ko.lang (modified) * trunk/resources/data/lt.lang (modified) * trunk/resources/data/mr.lang (modified) * trunk/resources/data/nb.lang (modified) * trunk/resources/data/nl.lang (modified) * trunk/resources/data/pl.lang (modified) * trunk/resources/data/pt.lang (modified) * trunk/resources/data/pt_BR.lang (modified) * trunk/resources/data/ru.lang (modified) * trunk/resources/data/sk.lang (modified) * trunk/resources/data/sr-latin.lang (modified) * trunk/resources/data/sv.lang (modified) * trunk/resources/data/uk.lang (modified) * trunk/resources/data/zh_CN.lang (modified) * trunk/resources/data/zh_TW.lang (modified) i18n Mon, 08 Apr 2024 13:57:37 GMT taylor.smock [19036] * trunk/native/macosx/macos-jpackage.sh (modified) See #23600: Native Apple Silicon Support Add entitlements so that the app can start. Mon, 08 Apr 2024 05:34:12 GMT GerdP [19035] * trunk/resources/data/validator/combinations.mapcss (modified) fix #23604: false warning in osmose because of a problem in JOSM - add tag key building:part as a physical feature for sport=* Sat, 06 Apr 2024 08:03:50 GMT GerdP [19034] * trunk/nodist/data/9304-examples.osm (modified) * trunk/src/org/openstreetmap/josm/data/validation/tests/Highways.java (modified) fix #9304: fix #9304: in validator, check for intersecting roads in different layers - exclude highway areas with layer != 0 from test - add one more test case with a bridge that is split (code coverage) Fri, 05 Apr 2024 12:58:43 GMT GerdP [19033] * trunk/src/org/openstreetmap/josm/io/OsmPbfReader.java (modified) * trunk/test/data/regress/23599 (added) * trunk/test/data/regress/23599/visible.osm.pbf (added) * trunk/test/data/regress/23599/w1194668585.drop-author.osm.pbf (added) * trunk/test/data/regress/23599/w1194668585.drop-version.osm.pbf (added) * trunk/test/data/regress/23599/w1194668585.full.osm.pbf (added) * trunk/test/data/regress/23599/w1194668585.orig.osm (added) * trunk/test/unit/org/openstreetmap/josm/gui/io/importexport/OsmPbfImporterTest.java (modified) fix #23599: Error opening osm.pbf if way has negative ID or incomplete metadata This fixes - handling of visible flag as proposed by *Martin* - handling of completely missing denseinfo (ids are always delta encoded), upload is discouraged - handling of denseinfo which only contains version data Thu, 04 Apr 2024 21:42:54 GMT taylor.smock [19032] * trunk/native/macosx/macos-jpackage.sh (modified) See #21533: Native Apple Silicon Support Try to fix code signatures for merged binaries (again). Thu, 04 Apr 2024 20:46:58 GMT taylor.smock [19031] * trunk/native/macosx/macos-jpackage.sh (modified) See #21533: Native Apple Silicon Support Try to fix code signatures for merged binaries. Options largely came from https://github.com/openjdk/jdk21u/blob/master/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacAppImageBuilder.java#getCodesignArgs Thu, 04 Apr 2024 17:24:39 GMT taylor.smock [19030] * trunk/.github/workflows/ant-test.yml (modified) * trunk/.github/workflows/ant.yml (modified) * trunk/native/macosx/macos-jpackage.sh (modified) Fix #21533, see #23600: Native Apple Silicon Support When building on macOS, the macos-jpackage.sh script now takes two arguments: 1. The JOSM revision 2. An additional JDK to build against (this should be of a different architecture) If an additional JDK is specified, it is assumed that it is a different architecture, and the two built apps are combined using lipo for a universal binary. `ant.yml` does have some changes to make it easier to debug packaging issues in PRs; the PR does still need to upload the specific package and add its branch to the triggers. Thu, 04 Apr 2024 13:19:33 GMT GerdP [19029] * trunk/nodist/data/9304-examples.osm (added) * trunk/src/org/openstreetmap/josm/data/validation/tests/Highways.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/validation/tests/HighwaysTest.java (modified) fix #9304: in validator, check for intersecting roads in different layers - initial implementation of the test - functional test with examples, also checks code coverage Wed, 03 Apr 2024 12:12:52 GMT GerdP [19028] * trunk/resources/data/validator/unnecessary.mapcss (modified) fix #23596: name=Bâtiment (French for "building"), especially on buildings, is suspicious and worth flagging by validator Wed, 03 Apr 2024 08:03:07 GMT GerdP [19027] * trunk/resources/data/validator/ignoretags.cfg (modified) see #23177: fix syntax error Tue, 02 Apr 2024 19:41:08 GMT taylor.smock [19026] * trunk/resources/data/defaultpresets.xml (modified) * trunk/resources/images/presets/vehicle/bicycle_wash.svg (added) * trunk/resources/styles/standard/elemstyles.mapcss (modified) Fix #23350: Add `amenity=bicycle_wash` as a preset (patch by mcliquid) The proposal (osmwiki:Proposal:Bicycle_Wash) was approved on 2023-12-18. Tue, 02 Apr 2024 18:50:57 GMT taylor.smock [19025] * trunk/resources/data/defaultpresets.xml (modified) * trunk/resources/data/validator/deprecated.mapcss (modified) * trunk/resources/data/validator/ignoretags.cfg (modified) * trunk/test/unit/org/openstreetmap/josm/data/validation/tests/TagCheckerTest.java (modified) Fix #23177: Change `ref:gnis` to `gnis:feature_id` in the waterway tagging options `ref:gnis`, `gnis:id`, `tiger:PLACENS`, `NHS:GNIS_ID`, and `nhs:gnis_id` have been merged into `gnis:feature_id`. The wiki pages have been stable for 6 months, and the changes were discussed on the OSM forum. Tue, 02 Apr 2024 16:57:56 GMT taylor.smock [19024] * trunk/src/org/openstreetmap/josm/io/OsmPbfReader.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/io/importexport/OsmPbfImporterTest.java (modified) Fix #23550: Error when deserializing PBF Blog (patch by giora.kosoi, modified) Modifications are as follows: * Added non-regression test * Removed unnecessary changes in Blob Tue, 02 Apr 2024 15:46:38 GMT taylor.smock [19023] * trunk/native/windows/MLConsole.properties (modified) * trunk/native/windows/win-jpackage.sh (modified) See #23552: Update version in MS Store The reviewer didn't like the `HWConsole` program. This changes it to be `JOSM HWConsole`, which they will ''hopefully'' be OK with. Thu, 28 Mar 2024 08:29:34 GMT GerdP [19022] * trunk/src/org/openstreetmap/josm/gui/conflict/tags/CombinePrimitiveResolverDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/conflict/tags/TagConflictResolverModel.java (modified) see #23305 and #23555: -revert most of the changes in r18988, it caused too many problems with plugins which relied on the old behaviour Tue, 26 Mar 2024 06:41:13 GMT GerdP [19021] * trunk/src/org/openstreetmap/josm/gui/layer/geoimage/ImageViewerDialog.java (modified) fix #23574: Preference geoimage.viewer.centre.on.image=true is ignored on startup - let the preference set the flag centerView instead of enabling the action only Sat, 23 Mar 2024 06:32:28 GMT GerdP [19020] * trunk/src/org/openstreetmap/josm/gui/history/VersionInfoPanel.java (modified) see #23482: optimize the space in the history view (column width) and consider adding line wrapping - avoid misaligned tables caused by invisible fields (in many but not all cases) Thu, 21 Mar 2024 20:35:35 GMT stoecker [19019] * trunk/src/org/openstreetmap/josm/gui/MainApplication.java (modified) see #23355, wrong translation Wed, 20 Mar 2024 14:56:13 GMT taylor.smock [19018] * trunk/native/linux/latest/usr/bin/josm-latest (modified) * trunk/native/linux/tested/usr/bin/josm (modified) See #17858/#23564: Update Java versions in Linux start scripts Additions: * Java 19-20 (EOL, added for completeness) * Java 21 (preferred LTS) * Java 22 (latest Java version) * Java 23 (next Java version) Removals: * Java 8, 9, and 10: We no longer support Java < 11. Tue, 12 Mar 2024 16:31:19 GMT taylor.smock [19017] * trunk/nodist/trans/zh_TW.lang (modified) * trunk/resources/data/ar.lang (modified) * trunk/resources/data/ast.lang (modified) * trunk/resources/data/be.lang (modified) * trunk/resources/data/bg.lang (modified) * trunk/resources/data/ca-valencia.lang (modified) * trunk/resources/data/ca.lang (modified) * trunk/resources/data/cs.lang (modified) * trunk/resources/data/da.lang (modified) * trunk/resources/data/de.lang (modified) * trunk/resources/data/el.lang (modified) * trunk/resources/data/en.lang (modified) * trunk/resources/data/en_AU.lang (modified) * trunk/resources/data/en_GB.lang (modified) * trunk/resources/data/es.lang (modified) * trunk/resources/data/et.lang (modified) * trunk/resources/data/fa.lang (modified) * trunk/resources/data/fi.lang (modified) * trunk/resources/data/fr.lang (modified) * trunk/resources/data/gl.lang (modified) * trunk/resources/data/hu.lang (modified) * trunk/resources/data/id.lang (modified) * trunk/resources/data/is.lang (modified) * trunk/resources/data/it.lang (modified) * trunk/resources/data/ja.lang (modified) * trunk/resources/data/km.lang (modified) * trunk/resources/data/ko.lang (modified) * trunk/resources/data/lt.lang (modified) * trunk/resources/data/mr.lang (modified) * trunk/resources/data/nb.lang (modified) * trunk/resources/data/nl.lang (modified) * trunk/resources/data/pl.lang (modified) * trunk/resources/data/pt.lang (modified) * trunk/resources/data/pt_BR.lang (modified) * trunk/resources/data/ru.lang (modified) * trunk/resources/data/sk.lang (modified) * trunk/resources/data/sr-latin.lang (modified) * trunk/resources/data/sv.lang (modified) * trunk/resources/data/uk.lang (modified) * trunk/resources/data/zh_CN.lang (modified) * trunk/resources/data/zh_TW.lang (modified) i18n update Mon, 11 Mar 2024 22:00:21 GMT taylor.smock [19016] * trunk/src/org/openstreetmap/josm/gui/dialogs/ValidatorDialog.java (modified) Fix #23540: When a Linux distribution removes the Bing png from JMapViewer, JOSM hangs when loading a Bing imagery layer This is due to an interaction between JOSM preferences, the ValidatorDialog, and the cached Bing imagery layer. The specific interaction that leads to the freeze is as follows: 1. User starts process of adding a Bing imagery layer to JOSM 2. In the ''EDT'' we call a `synchronized` method in `MainLayerManager` 3. In the ''EDT'' we block on a separate thread that is fetching the Bing attribution data 4. In the separate thread, we attempt to set cache information in preferences 5. Setting the preference fires a preference change event 6. One of the listeners, specifically `ValidatorDialog`, then calls another `synchronized` method in `MainLayerManager` Steps 2 and 6 are the problem points. This patch fixes that by ''only'' attempting to perform the update by only listening to a specific preference, instead of all of them. The alternative to this patch uses `Config#addKeyPreferenceChangeListener` instead. This was not done since `ToggleDialog` is already listening to all preference changes. Fri, 08 Mar 2024 12:22:01 GMT taylor.smock [19015] * trunk/resources/data/defaultpresets.xml (modified) * trunk/resources/images/presets/vehicle/crossing_markings_dashes.svg (added) * trunk/resources/images/presets/vehicle/crossing_markings_dots.svg (added) * trunk/resources/images/presets/vehicle/crossing_markings_ladder.svg (added) * trunk/resources/images/presets/vehicle/crossing_markings_ladder_paired.svg (added) * trunk/resources/images/presets/vehicle/crossing_markings_ladder_skewed.svg (added) * trunk/resources/images/presets/vehicle/crossing_markings_lines.svg (added) * trunk/resources/images/presets/vehicle/crossing_markings_lines_paired.svg (added) * trunk/resources/images/presets/vehicle/crossing_markings_surface.svg (added) * trunk/resources/images/presets/vehicle/crossing_markings_zebra_bicolour.svg (added) * trunk/resources/images/presets/vehicle/crossing_markings_zebra_double.svg (added) * trunk/resources/images/presets/vehicle/crossing_markings_zebra_paired.svg (added) * trunk/resources/images/presets/vehicle/crossing_ref_zebra.svg (modified) * trunk/resources/styles/standard/elemstyles.mapcss (modified) See #22630, see #22442: Add crossing:markings icons These icons were created by me using crossing_ref_zebra.svg as the base and inspiration from osmwiki:Key:crossing:markings. Fri, 08 Mar 2024 09:58:03 GMT GerdP [19014] * trunk/src/org/openstreetmap/josm/gui/dialogs/relation/GenericRelationEditor.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/relation/actions/ApplyAction.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/relation/actions/CancelAction.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/relation/actions/IRelationEditorActionAccess.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/dialogs/relation/actions/RelationEditorActionsTest.java (modified) fix #23527: Memory leak in relation editor - add new method `wouldRelationBeUseful()` in `IRelationEditorActionAccess` which doesn't call the problematic method `getChangedRelation()` to evaluate whether a relation would be useful if saved. - add comments and code in unit test for the method that shows how to handle the result of `getChangedRelation()` in case it is not needed any longer to avoid the memory leak. Fri, 08 Mar 2024 09:02:48 GMT GerdP [19013] * trunk/src/org/openstreetmap/josm/gui/history/HistoryBrowser.java (modified) * trunk/src/org/openstreetmap/josm/gui/history/HistoryBrowserDialogManager.java (modified) * trunk/src/org/openstreetmap/josm/gui/history/TagInfoViewer.java (modified) * trunk/src/org/openstreetmap/josm/gui/history/TagTableColumnModel.java (modified) see #23482: optimize the space in the history view (column width) and consider adding line wrapping - use TableHelper.adjustColumnWidth to adjust column widths each time when the displayed tag data changes - set maximum width for the "Since" column Thu, 07 Mar 2024 19:05:10 GMT taylor.smock [19012] * trunk/src/org/openstreetmap/josm/gui/MainApplication.java (modified) Fix #23437: Offer to reset JOSM if JOSM fails to finish startup multiple times Thu, 07 Mar 2024 15:08:06 GMT GerdP [19011] * trunk/test/data/regress/22817 (added) * trunk/test/data/regress/22817/data.osm (added) * trunk/test/unit/org/openstreetmap/josm/gui/io/SaveLayersDialogTest.java (modified) fix #23509: Test-Failure because of r18994,r18996 The patch changes the failing test so that it - doesn't use a new file but reads from an existing one so that the result doesn't depend on that part - tests more methods to show the differences between `DataSet.requiresUploadToServer()` and `OsmDataLayer.requiresUploadToServer()` - tests the effect of the upload policy on the `SaveLayersDialog` Thu, 07 Mar 2024 14:34:45 GMT taylor.smock [19010] * trunk/src/org/openstreetmap/josm/data/validation/routines/DomainValidator.java (modified) remove TLD from IANA Thu, 07 Mar 2024 08:45:26 GMT stoecker [19009] * trunk/src/org/openstreetmap/josm/tools/WikiReader.java (modified) fix #23536 - somebody added useless space in Trac, so our empty-page detection failed Wed, 06 Mar 2024 14:07:01 GMT taylor.smock [19008] * trunk/src/org/openstreetmap/josm/data/oauth/OAuthParameters.java (modified) * trunk/src/org/openstreetmap/josm/gui/oauth/AdvancedOAuthPropertiesPanel.java (modified) * trunk/src/org/openstreetmap/josm/gui/oauth/FullyAutomaticAuthorizationUI.java (modified) * trunk/src/org/openstreetmap/josm/gui/oauth/OAuthAuthorizationWizard.java (modified) * trunk/src/org/openstreetmap/josm/gui/preferences/server/OAuthAuthenticationPreferencesPanel.java (modified) Fix an issue with custom OAuth2 parameters where the custom parameters would be replaced by default parameters Mon, 04 Mar 2024 16:06:32 GMT taylor.smock [19007] * trunk/src/org/openstreetmap/josm/gui/preferences/server/OAuthAuthenticationPreferencesPanel.java (modified) OAuth2: Fix an issue where a valid URL would have no host Mon, 04 Mar 2024 07:22:42 GMT GerdP [19006] * trunk/src/org/openstreetmap/josm/gui/dialogs/properties/TagEditHelper.java (modified) fix #22814: Command stack shows "Set 1 tags for 0 objects" - add check to avoid a no-change-command on the undo/redo stack Sun, 03 Mar 2024 15:38:02 GMT GerdP [19005] * trunk/src/org/openstreetmap/josm/data/validation/ValidationTask.java (modified) fix #23519: Don't automatically enlarge "Validation Results" panel - show and unfurl "Validation Results" panel if not yet visible unless the tree is empty and the validation was triggered by an upload (see #23187) Thu, 29 Feb 2024 10:49:20 GMT GerdP [19004] * trunk/test/unit/org/openstreetmap/josm/gui/preferences/map/TaggingPresetPreferenceTestIT.java (modified) see #23514: add @Territories annotation Thu, 29 Feb 2024 09:11:29 GMT GerdP [19003] * trunk/test/functional/org/openstreetmap/josm/data/osm/TaginfoTestIT.java (modified) fix #23514: add @Territories annotation Thu, 29 Feb 2024 07:20:32 GMT GerdP [19002] * trunk/src/org/openstreetmap/josm/gui/conflict/tags/TagConflictResolverModel.java (modified) see #23305: correct @since xxx Thu, 29 Feb 2024 06:51:49 GMT GerdP [19001] * trunk/src/org/openstreetmap/josm/data/validation/tests/MultipolygonTest.java (modified) fix #23517: "Tools->Create multipolygon" sorts inner before outer - reorder members so that all outer rings come first and for rings with same role those with more members come first (before calling `RelationSorter.sortMembersByConnectivity()`) Thu, 29 Feb 2024 06:48:30 GMT GerdP [19000] * trunk/src/org/openstreetmap/josm/actions/upload/ValidateUploadHook.java (modified) * trunk/src/org/openstreetmap/josm/data/preferences/sources/ValidatorPrefHelper.java (modified) * trunk/src/org/openstreetmap/josm/data/validation/ValidationTask.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/ValidatorDialog.java (modified) fix #23519: Don't automatically enlarge "Validation Results" panel - implement new preference validator.force.unfurl.window with default value true, if set to false the window is not unfurled - code cleanup to remove duplicate or obsolete code Mon, 26 Feb 2024 14:00:15 GMT taylor.smock [18999] * trunk/src/org/openstreetmap/josm/gui/MainApplication.java (modified) See #23355: Ensure that the dialog has read the preference key for the sanity check Mon, 26 Feb 2024 12:46:54 GMT taylor.smock [18998] * trunk/src/org/openstreetmap/josm/gui/MainApplication.java (modified) See #23355: Don't store stop answers for startup sanity check Fri, 23 Feb 2024 13:48:51 GMT taylor.smock [18997] * trunk/resources/data/defaultpresets.xml (modified) Fix #23361: Add `mouth` as an optional role for waterway relations (patch by hhtznr) Additional notes: * The optional role was added to osmwiki:Relation:waterway on 2023-04-25. * Of 104058 waterway relations, 845 have a `mouth` role. Thu, 22 Feb 2024 17:49:11 GMT stoecker [18996] * trunk/src/org/openstreetmap/josm/gui/io/SaveLayersDialog.java (modified) see #23506, see #23408 - readd the bracket lost in last checkin Thu, 22 Feb 2024 15:50:30 GMT taylor.smock [18995] * trunk/resources/data/defaultpresets.xml (modified) Add `turning_circle` tag (a subkey for `highway=turning_circle`) (patch by guylamar2006, see https://github.com/JOSM/josm/pull/137) Thu, 22 Feb 2024 15:49:07 GMT stoecker [18994] * trunk/src/org/openstreetmap/josm/gui/io/SaveLayersDialog.java (modified) fix #23506, see #23408 - fix the save/upload layer preconditions - neither the original, nor the #23408 variant makes real sense Thu, 22 Feb 2024 15:45:28 GMT taylor.smock [18993] * trunk/.github/workflows/ant-test.yml (modified) * trunk/.github/workflows/ant.yml (modified) * trunk/.github/workflows/checkstyle-analysis.yml (modified) * trunk/.github/workflows/codeql-analysis.yml (modified) * trunk/.github/workflows/pmd-analysis.yml (modified) * trunk/.github/workflows/spotbugs-analysis.yml (modified) Update actions to ones that support node 20 (patch by guylamar2006, see https://github.com/JOSM/josm/pull/136 ) Thu, 22 Feb 2024 14:49:01 GMT taylor.smock [18992] * trunk/test/unit/org/openstreetmap/josm/data/imagery/WMSEndpointTileSourceTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/imagery/WMTSTileSourceTest.java (modified) See #23485/r18989: Fix broken tests The tests just needed to have a category set. Wed, 21 Feb 2024 20:26:18 GMT taylor.smock [18991] * trunk/ivy.xml (modified) * trunk/src/org/openstreetmap/josm/data/oauth/OAuth20Parameters.java (modified) * trunk/src/org/openstreetmap/josm/data/oauth/OAuthAccessTokenHolder.java (modified) * trunk/src/org/openstreetmap/josm/data/oauth/OAuthParameters.java (modified) * trunk/src/org/openstreetmap/josm/data/oauth/OAuthToken.java (deleted) * trunk/src/org/openstreetmap/josm/data/oauth/OAuthVersion.java (modified) * trunk/src/org/openstreetmap/josm/data/oauth/SignpostAdapters.java (deleted) * trunk/src/org/openstreetmap/josm/gui/oauth/AbstractAuthorizationUI.java (modified) * trunk/src/org/openstreetmap/josm/gui/oauth/AccessTokenInfoPanel.java (modified) * trunk/src/org/openstreetmap/josm/gui/oauth/AdvancedOAuthPropertiesPanel.java (modified) * trunk/src/org/openstreetmap/josm/gui/oauth/FullyAutomaticAuthorizationUI.java (modified) * trunk/src/org/openstreetmap/josm/gui/oauth/ManualAuthorizationUI.java (modified) * trunk/src/org/openstreetmap/josm/gui/oauth/OAuthAuthorizationWizard.java (modified) * trunk/src/org/openstreetmap/josm/gui/oauth/OsmLoginFailedException.java (deleted) * trunk/src/org/openstreetmap/josm/gui/oauth/OsmOAuthAuthorizationClient.java (deleted) * trunk/src/org/openstreetmap/josm/gui/oauth/RetrieveAccessTokenTask.java (deleted) * trunk/src/org/openstreetmap/josm/gui/oauth/RetrieveRequestTokenTask.java (deleted) * trunk/src/org/openstreetmap/josm/gui/oauth/SemiAutomaticAuthorizationUI.java (deleted) * trunk/src/org/openstreetmap/josm/gui/oauth/TestAccessTokenTask.java (modified) * trunk/src/org/openstreetmap/josm/gui/preferences/server/AuthenticationPreferencesPanel.java (modified) * trunk/src/org/openstreetmap/josm/gui/preferences/server/OAuthAuthenticationPreferencesPanel.java (modified) * trunk/src/org/openstreetmap/josm/io/MessageNotifier.java (modified) * trunk/src/org/openstreetmap/josm/io/OsmApi.java (modified) * trunk/src/org/openstreetmap/josm/io/OsmConnection.java (modified) * trunk/src/org/openstreetmap/josm/io/auth/CredentialsAgent.java (modified) * trunk/src/org/openstreetmap/josm/io/auth/CredentialsManager.java (modified) * trunk/src/org/openstreetmap/josm/io/auth/JosmPreferencesCredentialAgent.java (modified) * trunk/src/org/openstreetmap/josm/tools/ExceptionUtil.java (modified) * trunk/test/unit/org/openstreetmap/josm/TestUtils.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/oauth/OAuth20AuthorizationTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/oauth/OAuthParametersTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/oauth/OAuthTokenTest.java (deleted) * trunk/test/unit/org/openstreetmap/josm/data/oauth/SignpostAdaptersTest.java (deleted) * trunk/test/unit/org/openstreetmap/josm/gui/io/DownloadOpenChangesetsTaskTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/oauth/FullyAutomaticAuthorizationUITest.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/oauth/ManualAuthorizationUITest.java (modified) * trunk/test/unit/org/openstreetmap/josm/gui/oauth/OsmOAuthAuthorizationClientTest.java (deleted) * trunk/test/unit/org/openstreetmap/josm/gui/oauth/SemiAutomaticAuthorizationUITest.java (deleted) * trunk/test/unit/org/openstreetmap/josm/gui/preferences/server/OAuthAuthenticationPreferencesPanelTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/io/auth/CredentialsAgentTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/testutils/annotations/BasicPreferences.java (modified) * trunk/test/unit/org/openstreetmap/josm/testutils/annotations/TestUser.java (modified) Fix #22810: OSM OAuth 1.0a/Basic auth deprecation and removal As of 2024-02-15, something changed in the OSM server configuration. This broke our OAuth 1.0a implementation (see #23475). As such, we are removing OAuth 1.0a from JOSM now instead of when the OSM server removes support in June 2024. For third-party OpenStreetMap servers, the `Basic Authentication` method has been kept. However, they should be made aware that it may be removed if a non-trivial bug occurs with it. We highly recommend that the third-party servers update to the current OpenStreetMap website implementation (if only for their own security). Failing that, the third-party server can implement RFC8414. As of this commit, we currently use the `authorization_endpoint` and `token_endpoint` fields. To check and see if their third-party server implements RFC8414, they can go to `/.well-known/oauth-authorization-server`. Prominent third-party OpenStreetMap servers may give us a client id for their specific server. That client id ''may'' be added to the hard-coded client id list ''at maintainer discretion''. At a minimum, the server ''must'' be publicly available ''and'' have a significant user base. Tue, 20 Feb 2024 17:14:31 GMT taylor.smock [18990] * trunk/src/org/openstreetmap/josm/tools/Geometry.java (modified) Fix #23472: Decrease cost of Geometry#polygonIntersectionResult (specifically for geometry.mapcss) When profiling the validator with an overpass download of Mesa County, Colorado, ~50% of the total CPU time are taken up by `Geometry#polygonIntersectionResult`. Specifically (inside the function), the improvements for this patch are as follows: * CPU cycles: -95.7% * Memory allocations: -97.9% When taken as a whole, the total time taken by the validator was reduced by ~75%. Tue, 20 Feb 2024 15:44:22 GMT taylor.smock [18989] * trunk/scripts/SyncEditorLayerIndex.java (modified) * trunk/src/org/openstreetmap/josm/data/imagery/ImageryInfo.java (modified) * trunk/src/org/openstreetmap/josm/data/imagery/ImageryLayerInfo.java (modified) Fix #23485: JOSM crashes when opening Imagery Preferences * `SyncEditorLayerIndex.java` now checks to see if imagery entries are valid; if not, it prints the missing fields and the standard description. * `ImageryInfo` now has `isValid` and `getMissingFields`; the latter method should only be called in tests or `SyncEditorLayerIndex`. * `ImageryLayerInfo` removes invalid `ImageryInfo` objects after parsing the source Fri, 16 Feb 2024 10:13:51 GMT GerdP [18988] * trunk/src/org/openstreetmap/josm/gui/conflict/tags/CombinePrimitiveResolverDialog.java (modified) * trunk/src/org/openstreetmap/josm/gui/conflict/tags/TagConflictResolverModel.java (modified) fix #23305: conflict detection not working for combine way with one null and one tag set (23305-alt.patch) - adds code to check if a conflict exists where one or more tagged ways don't have the same tag value and - if so - show the conflict dialog. - adds a preference combine-conflict-precise . If set to false the old behaviour is restored. - changes the preference for the non-expert relation member ship warning popup from `combine_tags` to `combine_relation_member`, so that both dialogs have separate settings Fri, 16 Feb 2024 07:53:31 GMT GerdP [18987] * trunk/src/org/openstreetmap/josm/actions/mapmode/ExtrudeAction.java (modified) fix #23477: crash when undoing changes while in extrude mode - add sanity checks in performExtrusion() to detect when undo was pressed, this always cancels the current extrude - removes the try/catch clause which might hide a data corruption (reverts r12512) Thu, 15 Feb 2024 15:06:37 GMT taylor.smock [18986] * trunk/src/org/openstreetmap/josm/gui/MainApplication.java (modified) * trunk/src/org/openstreetmap/josm/tools/PlatformHook.java (modified) * trunk/tools/eclipse/JOSM (Java 11).launch (modified) * trunk/tools/eclipse/JOSM (Java latest).launch (modified) See #23355: Sanity check JVM arguments on startup Change the icon for `Continue` and be a more lenient when comparing expected JVM arguments against actual JVM arguments. This additionally updates the Eclipse launch files. Wed, 14 Feb 2024 17:11:54 GMT taylor.smock [18985] * trunk/build.xml (modified) * trunk/native/linux/latest/DEBIAN/control (modified) * trunk/native/linux/tested/DEBIAN/control (modified) * trunk/src/org/openstreetmap/josm/gui/MainApplication.java (modified) * trunk/src/org/openstreetmap/josm/gui/MainInitialization.java (modified) * trunk/src/org/openstreetmap/josm/tools/PlatformHook.java (modified) * trunk/src/org/openstreetmap/josm/tools/PlatformHookOsx.java (modified) * trunk/src/org/openstreetmap/josm/tools/PlatformHookUnixoid.java (modified) * trunk/src/org/openstreetmap/josm/tools/PlatformHookWindows.java (modified) * trunk/test/unit/org/openstreetmap/josm/tools/PlatformHookOsxTest.java (modified) * trunk/test/unit/org/openstreetmap/josm/tools/PlatformHookWindowsTest.java (modified) Fix #23355: Sanity check JVM arguments on startup See #17858: JOSM will no longer continue running if the user is on an unsupported Java version (for this commit, older than Java 11; message indicates Java 17). This does update the link for Azul from Java 17 to Java 21 as well. In order to (hopefully) reduce confusion, the webstart and Java update nags will also be reset in the event that JOSM will exit due to old Java versions. This is mostly so that users will get the messages to update to OpenWebstart or the appropriate Java link for their platform and architecture. Additionally, this will (hopefully) reduce the number of tickets we have to close due to missing JVM arguments by informing users of the missing arguments at startup. Wed, 14 Feb 2024 16:07:07 GMT GerdP [18984] * trunk/src/org/openstreetmap/josm/data/validation/tests/TagChecker.java (modified) see #17035: enable counter that shows "{0} of {1} elements done" for the tested OSM elements also in TagChecker Wed, 14 Feb 2024 14:57:09 GMT taylor.smock [18983] * trunk/src/org/openstreetmap/josm/tools/AlphanumComparator.java (modified) * trunk/test/unit/org/openstreetmap/josm/tools/AlphanumComparatorTest.java (modified) Fix #23471: fix an inconsistency between fast ASCII sort and slower unicode-aware sort Tue, 13 Feb 2024 22:09:42 GMT taylor.smock [18982] * trunk/src/org/openstreetmap/josm/tools/AlphanumComparator.java (modified) See #23471: Temporarily disable fast sorting Tue, 13 Feb 2024 21:24:20 GMT taylor.smock [18981] * trunk/test/unit/org/openstreetmap/josm/data/validation/tests/TagCheckerTest.java (modified) See #23290/r18980: Update test messages Tue, 13 Feb 2024 17:25:12 GMT taylor.smock [18980] * trunk/src/org/openstreetmap/josm/data/validation/tests/TagChecker.java (modified) Fix #23290: Improve region check messages and run region checks when informational warnings are disabled Tue, 13 Feb 2024 17:04:08 GMT taylor.smock [18979] * trunk/ivy.xml (modified) * trunk/ivysettings.xml (modified) * trunk/src/org/openstreetmap/josm/tools/Tag2Link.java (modified) * trunk/tools/ivy.xml (modified) Dependency updates ivy.xml * OpeningHoursParser: 0.28.0 -> 0.28.1 * junit: 5.10.1 -> 5.10.2 * equalsverifier: 3.15.5 -> 3.15.6 * tag2link: 2023.11.21 -> 2024.2.8 tools/ivy.xml * proguard: 7.4.1 -> 7.4.2 * error_prone: 2.24.0 -> 2.24.1 Tue, 13 Feb 2024 15:04:22 GMT taylor.smock [18978] * trunk/src/org/openstreetmap/josm/tools/AlphanumComparator.java (modified) See #23468: Improve performance in the validator tree window Add missing `-` character. Tue, 13 Feb 2024 14:58:15 GMT taylor.smock [18977] * trunk/src/org/openstreetmap/josm/tools/AlphanumComparator.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/osm/DefaultNameFormatterTest.java (modified) See #23468: Improve performance in the validator tree window This fixes an issue where there was a difference in sorting algorithms between the faster ASCII only sorting method and the sorting method used by non-ASCII strings. Tue, 13 Feb 2024 08:29:09 GMT GerdP [18976] * trunk/src/org/openstreetmap/josm/data/validation/tests/DuplicateRelation.java (modified) * trunk/test/unit/org/openstreetmap/josm/data/validation/tests/DuplicateRelationTest.java (modified) fix #20424, fix #20425: Duplicate relations not detected with incomplete members, Duplicate Relation test is too lazy/too aggressive - add code to compare just members so that it doesn't matter if they are complete - change original test which compares geometry to use a list instead of a set to store members. That means that the order of members is taken into account as well as duplicated members - before comparing tags only the "discardable" tag keys are removed, previously all "uninteresting" keys were removed, so fixme=* or note=* was ignored - if two relations have the same members in the same order but different tags the new message informational message "Identical members" is produced. Mon, 12 Feb 2024 22:02:57 GMT taylor.smock [18975] * trunk/src/org/openstreetmap/josm/io/session/SessionReader.java (modified) See #23465: Add missing documentation for SessionReader Mon, 12 Feb 2024 22:00:59 GMT taylor.smock [18974] * trunk/build.xml (modified) * trunk/test/unit/org/openstreetmap/josm/testutils/PluginServer.java (modified) * trunk/test/unit/org/openstreetmap/josm/testutils/annotations/ResetUniquePrimitiveIdCounters.java (modified) * trunk/test/unit/org/openstreetmap/josm/testutils/annotations/TaggingPresets.java (modified) * trunk/test/unit/org/openstreetmap/josm/testutils/annotations/TestUser.java (modified) * trunk/test/unit/org/openstreetmap/josm/testutils/annotations/Timezone.java (modified) * trunk/tools/checkstyle/.classpath (deleted) * trunk/tools/checkstyle/.project (deleted) * trunk/tools/checkstyle/.settings (deleted) * trunk/tools/checkstyle/josm_checks.xml (modified) * trunk/tools/checkstyle/josm_filters.xml (modified) * trunk/tools/checkstyle/src (deleted) Fix #23465: Remove custom checkstyle plugin TopLevelJavadocCheck.java is duplicating functionality from MissingJavadocType. Our custom class is from #14794 (closed 2017-10-16). The check that makes it redundant was added in checkstyle 8.20 (released 2019-04-28). This adds the missing javadocs for the more comprehensive checkstyle version. Mon, 12 Feb 2024 17:12:15 GMT taylor.smock [18973] * trunk/src/org/openstreetmap/josm/tools/AlphanumComparator.java (modified) Fix #23468: Improve performance in the Validator tree window A large number of entries in the validator tree would cause the UI to lock for significant periods of time when switching to a layer with many errors. Most of the time spent was in `AlphanumComparator.compare`. We need to use `AlphanumComparator` since `String.compare` would improperly sort strings with accented characters. The performance optimizations for this patch come from the following locations: * Extracting string chunk comparison to its own method (which can be compiled to native code) * Using `String.substring` instead of a `StringBuilder` when getting a string chunk for comparison Both of those methods may be compiled to native code, but absent code compilation, the performance improvements are as follows (as measured using an overpass download of `Mesa County, Colorado`): * -86.4% CPU usage (3.366s to 0.459s) * -99.9% memory allocations (2.37 GB to 2.07 MB) Fri, 09 Feb 2024 14:26:06 GMT taylor.smock [18972] * trunk/src/org/openstreetmap/josm/actions/JoinAreasAction.java (modified) * trunk/src/org/openstreetmap/josm/data/osm/Filter.java (modified) * trunk/src/org/openstreetmap/josm/gui/conflict/pair/AbstractListMergeModel.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/relation/sort/WayConnectionType.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/CustomConfigurator.java (modified) * trunk/src/org/openstreetmap/josm/gui/io/SaveLayersModel.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/ImageryLayer.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/JumpToMarkerActions.java (modified) * trunk/src/org/openstreetmap/josm/gui/layer/markerlayer/MarkerLayer.java (modified) * trunk/src/org/openstreetmap/josm/gui/mappaint/StyleSetting.java (modified) * trunk/src/org/openstreetmap/josm/gui/mappaint/mapcss/ExpressionFactory.java (modified) * trunk/src/org/openstreetmap/josm/gui/preferences/ToolbarPreferences.java (modified) * trunk/src/org/openstreetmap/josm/gui/preferences/map/TaggingPresetPreference.java (modified) * trunk/src/org/openstreetmap/josm/gui/preferences/projection/CustomProjectionChoice.java (modified) * trunk/src/org/openstreetmap/josm/gui/util/MultikeyShortcutAction.java (modified) * trunk/src/org/openstreetmap/josm/tools/template_engine/Tokenizer.java (modified) * trunk/test/unit/org/openstreetmap/josm/testutils/annotations/AssertionsInEDT.java (modified) * trunk/test/unit/org/openstreetmap/josm/testutils/annotations/FakeImagery.java (modified) * trunk/test/unit/org/openstreetmap/josm/testutils/annotations/HTTPS.java (modified) * trunk/test/unit/org/openstreetmap/josm/testutils/annotations/LayerManager.java (modified) * trunk/test/unit/org/openstreetmap/josm/testutils/annotations/Logging.java (modified) * trunk/test/unit/org/openstreetmap/josm/testutils/annotations/MapPaintStyles.java (modified) * trunk/test/unit/org/openstreetmap/josm/testutils/annotations/MeasurementSystem.java (modified) * trunk/test/unit/org/openstreetmap/josm/testutils/annotations/OsmApi.java (modified) * trunk/test/unit/org/openstreetmap/josm/testutils/annotations/ProjectionNadGrids.java (modified) See #23465: Add additional javadoc comments This also fixes some sonarlint issues Fri, 09 Feb 2024 12:55:06 GMT taylor.smock [18971] * trunk/resources/data/validator/deprecated.mapcss (modified) Fix #23148: Remove `fenced` from deprecation warnings The tag's deprecation status was changed on 2023-06-14, and is used as a supplementary tag for features to indicate that the feature is fenced. Example: `leisure=playground` + `fenced=yes`. Thu, 08 Feb 2024 20:37:15 GMT taylor.smock [18970] * trunk/src/org/openstreetmap/josm/data/validation/routines/DomainValidator.java (modified) remove TLD from IANA Mon, 05 Feb 2024 11:56:34 GMT taylor.smock [18969] * trunk/nodist/trans/fr.lang (modified) * trunk/nodist/trans/zh_TW.lang (modified) * trunk/resources/data/ar.lang (modified) * trunk/resources/data/ast.lang (modified) * trunk/resources/data/be.lang (modified) * trunk/resources/data/bg.lang (modified) * trunk/resources/data/ca-valencia.lang (modified) * trunk/resources/data/ca.lang (modified) * trunk/resources/data/cs.lang (modified) * trunk/resources/data/da.lang (modified) * trunk/resources/data/de.lang (modified) * trunk/resources/data/el.lang (modified) * trunk/resources/data/en.lang (modified) * trunk/resources/data/en_AU.lang (modified) * trunk/resources/data/en_GB.lang (modified) * trunk/resources/data/es.lang (modified) * trunk/resources/data/et.lang (modified) * trunk/resources/data/fa.lang (modified) * trunk/resources/data/fi.lang (modified) * trunk/resources/data/fr.lang (modified) * trunk/resources/data/gl.lang (modified) * trunk/resources/data/hu.lang (modified) * trunk/resources/data/id.lang (modified) * trunk/resources/data/is.lang (modified) * trunk/resources/data/it.lang (modified) * trunk/resources/data/ja.lang (modified) * trunk/resources/data/km.lang (modified) * trunk/resources/data/ko.lang (modified) * trunk/resources/data/lt.lang (modified) * trunk/resources/data/mr.lang (modified) * trunk/resources/data/nb.lang (modified) * trunk/resources/data/nl.lang (modified) * trunk/resources/data/pl.lang (modified) * trunk/resources/data/pt.lang (modified) * trunk/resources/data/pt_BR.lang (modified) * trunk/resources/data/ru.lang (modified) * trunk/resources/data/sk.lang (modified) * trunk/resources/data/sr-latin.lang (modified) * trunk/resources/data/sv.lang (modified) * trunk/resources/data/uk.lang (modified) * trunk/resources/data/zh_CN.lang (modified) * trunk/resources/data/zh_TW.lang (modified) i18n update Fri, 02 Feb 2024 14:25:09 GMT GerdP [18968] * trunk/src/org/openstreetmap/josm/gui/dialogs/relation/GenericRelationEditor.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/relation/actions/DeleteCurrentRelationAction.java (modified) fix #23447:Fatal "crash" attempting to delete all "Outer" members & then multipolygon - revert changes from r18967 - simply close relation editor dialog for the already deleted relation instead of generating an additional delete command Thu, 01 Feb 2024 12:56:33 GMT GerdP [18967] * trunk/src/org/openstreetmap/josm/gui/dialogs/relation/GenericRelationEditor.java (modified) * trunk/src/org/openstreetmap/josm/gui/dialogs/relation/actions/DeleteCurrentRelationAction.java (modified) fix #23447: Fatal "crash" attempting to delete all "Outer" members & then multipolygon - disable the delete action in the relation editor if the relation has the status `deleted` - in `DeleteCurrentRelationAction` updateEnabledState() now uses getRelaion() instead of getRelationSnapshot(), similar to the actionPerformed() method Tue, 30 Jan 2024 19:57:09 GMT taylor.smock [18966] * trunk/resources/data/tagging-preset.xsd (modified) See #23290: Add missing regions attributes to `text`, `combo` and `multiselect` simonpoole (Vespucci dev) pointed out that we were using `regions` for those attributes on but did not have them documented in the xsd. Tue, 30 Jan 2024 19:06:45 GMT taylor.smock [18965] * trunk/src/org/openstreetmap/josm/actions/mapmode/ImproveWayAccuracyAction.java (modified) * trunk/test/unit/org/openstreetmap/josm/actions/mapmode/ImproveWayAccuracyActionTest.java (modified) See #23444: Fix an additional NPE found during testing ImproveWayAccuracyAction The NPE could be reproduced by selecting a node with ''only'' an incomplete parent way, and switching from select mode to improve way mode. This additionally adds simple tests for ImproveWayAccuracyAction and refactors some methods to have a lower complexity.