Changeset 19029 in josm

Timestamp:

2024-04-04T15:19:33+02:00 (5 weeks ago)

Author:

GerdP

Message:

fix #9304: in validator, check for intersecting roads in different layers

• initial implementation of the test
• functional test with examples, also checks code coverage

Location:

trunk

Files:

• nodist/data/9304-examples.osm (added)
• src/org/openstreetmap/josm/data/validation/tests/Highways.java (modified) (4 diffs)
• test/unit/org/openstreetmap/josm/data/validation/tests/HighwaysTest.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/validation/tests/Highways.java

@@ -12 +12 @@
 import java.util.Locale;
 import java.util.Map;
+import java.util.Map.Entry;
 import java.util.Set;
 import java.util.stream.Collectors;
@@ -39 +40 @@
     protected static final int SOURCE_MAXSPEED_CONTEXT_MISMATCH_VS_HIGHWAY = 2706;
     protected static final int SOURCE_WRONG_LINK = 2707;
+    protected static final int DIFFERENT_LAYERS = 2708;
 
     protected static final String SOURCE_MAXSPEED = "source:maxspeed";
@@ -90 +92 @@
                 // as maxspeed is not set on highways here but on signs, speed cameras, etc.
                 testSourceMaxspeed(n, false);
+            }
+            if (n.isReferredByWays(2)) {
+                testDifferentLayers(n);
             }
         }
@@ -299 +304 @@
         }
     }
+
+    /**
+     * See #9304: Find Highways connected to bridges or tunnels at the wrong place.
+     * @param connection the connection node of two or more different ways
+     */
+    private void testDifferentLayers(Node connection) {
+        List<Way> ways = connection.getParentWays();
+        ways.removeIf(w -> !w.hasTag("highway") || w.hasTag("highway", "steps"));
+        if (ways.size() < 2 || ways.stream().noneMatch(w -> w.hasKey("layer")))
+            return;
+        // check if connection has ways with different layers
+        Map<String, List<Way>> layerCount = new HashMap<>();
+        for (Way w : ways) {
+            String layer = w.get("layer");
+            if (layer == null)
+                layer = "0";
+            layerCount.computeIfAbsent(layer, k-> new ArrayList<>()).add(w);
+        }
+        if (layerCount.size() == 1)
+            return; // all on the same layer
+
+        for (Entry<String, List<Way>> entry : layerCount.entrySet()) {
+            if ("0".equals(entry.getKey()))
+                continue;
+            if (checkLayer(connection, entry.getValue())) {
+                errors.add(TestError.builder(this, Severity.WARNING, DIFFERENT_LAYERS)
+                        .message(tr("Node connects highways on different layers"))
+                        .primitives(connection)
+                        .build());
+                return;
+            }
+        }
+    }
+
+    /**
+     * Check if there are at least two neighbouring nodes on the given ways.
+     * If so, the connection node can be considered to be at a specific layer, else it marks the end of such a layer
+     * @param connection the connection node
+     * @param ways the ways with the same layer attribute connected to that node
+     * @return true if the node can be considered to be at a specific layer
+     */
+    private static boolean checkLayer(Node connection, List<Way> ways) {
+        int count = 0;
+        for (Way w : ways) {
+            if (!w.isFirstLastNode(connection))
+                return true; // connection node has two neighbouring nodes
+            count++;
+        }
+        return count > 1;
+    }
 }

trunk/test/unit/org/openstreetmap/josm/data/validation/tests/HighwaysTest.java

@@ -115 +115 @@
         }
     }
+
+    /**
+     * Test all error cases manually created in data.osm.
+     * @throws Exception in case of error
+     */
+    @Test
+    void testTicket9304() throws Exception {
+        final Highways test = new Highways();
+        ValidatorTestUtils.testSampleFile("nodist/data/9304-examples.osm", DataSet::getNodes, null, test);
+    }
+
 }