Changeset 19020 in josm

Timestamp:

2024-03-23T07:32:28+01:00 (7 weeks ago)

Author:

GerdP

Message:

see #23482: optimize the space in the history view (column width) and consider adding line wrapping

• avoid misaligned tables caused by invisible fields (in many but not all cases)

File:

• trunk/src/org/openstreetmap/josm/gui/history/VersionInfoPanel.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/history/VersionInfoPanel.java

@@ -294 +294 @@
 
         final Changeset oppCs = model != null ? model.getPointInTime(pointInTimeType.opposite()).getChangeset() : null;
-        updateText(cs, "comment", texChangesetComment, null, oppCs, texChangesetComment);
-        updateText(cs, "source", texChangesetSource, lblSource, oppCs, pnlChangesetSource);
-        updateText(cs, "imagery_used", texChangesetImageryUsed, lblImageryUsed, oppCs, pnlChangesetImageryUsed);
+        updateText(cs, "comment", texChangesetComment, oppCs, texChangesetComment);
+        updateText(cs, "source", texChangesetSource, oppCs, pnlChangesetSource);
+        updateText(cs, "imagery_used", texChangesetImageryUsed, oppCs, pnlChangesetImageryUsed);
     }
 
@@ -303 +303 @@
     }
 
-    protected static void updateText(Changeset cs, String attr, JTextArea textArea, JLabel label, Changeset oppCs, JComponent container) {
+    protected static void updateText(Changeset cs, String attr, JTextArea textArea, Changeset oppCs, JComponent container) {
         final String text = cs != null ? cs.get(attr) : null;
-        // Update text, hide prefixing label if empty
-        if (label != null) {
-            label.setVisible(text != null && !Utils.isStripEmpty(text));
-        }
         textArea.setText(text);
         // Hide container if values of both versions are empty