Changeset 18980 in josm

Timestamp:

2024-02-13T18:25:12+01:00 (3 months ago)

Author:

taylor.smock

Message:

Fix #23290: Improve region check messages and run region checks when informational warnings are disabled

File:

• trunk/src/org/openstreetmap/josm/data/validation/tests/TagChecker.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/data/validation/tests/TagChecker.java

@@ -750 +750 @@
                 if (isInRegion == preset.exclude_regions()) {
                     errors.add(TestError.builder(this, Severity.WARNING, INVALID_REGION)
-                            .message(tr("Invalid region for this preset"),
+                            .message(tr("Preset is invalid in this region"),
                                     marktr("Preset {0} should not be applied in this region"),
                                     preset.getLocaleName())
@@ -826 +826 @@
                         .primitives(p);
                 if (value == null) {
-                    builder.message(tr("Invalid region for this preset"),
+                    builder.message(tr("Key from a preset is invalid in this region"),
                             marktr("Preset {0} should not have the key {1}"),
                             preset.getLocaleName(), key);
                 } else {
-                    builder.message(tr("Invalid region for this preset"),
+                    builder.message(tr("Value from a preset is invalid in this region"),
                             marktr("Preset {0} should not have the tag {1}={2}"),
                             preset.getLocaleName(), key, value);
@@ -1267 +1267 @@
         }
 
-        checkRegions = includeOtherSeverity && Config.getPref().getBoolean(PREF_CHECK_REGIONS, true);
+        checkRegions = Config.getPref().getBoolean(PREF_CHECK_REGIONS, true);
         if (isBeforeUpload) {
             checkRegions = checkRegions && Config.getPref().getBoolean(PREF_CHECK_REGIONS_BEFORE_UPLOAD, true);